From patchwork Tue Sep 20 06:30:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 76588 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1323057qgf; Mon, 19 Sep 2016 23:31:22 -0700 (PDT) X-Received: by 10.66.86.9 with SMTP id l9mr20934719paz.72.1474353082371; Mon, 19 Sep 2016 23:31:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si30458066paz.44.2016.09.19.23.31.22; Mon, 19 Sep 2016 23:31:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016AbcITGbK (ORCPT + 27 others); Tue, 20 Sep 2016 02:31:10 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34955 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422AbcITGbI (ORCPT ); Tue, 20 Sep 2016 02:31:08 -0400 Received: by mail-pf0-f194.google.com with SMTP id 6so477020pfl.2; Mon, 19 Sep 2016 23:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=z+2wfo0b6l6wRH7/HQaKHUXFfNd/UYIgFbhjFrZaMxc=; b=cD3ejeUeqKgfegktNCdcrCDtadEKCANanLzgnWM/YKTK1zmO0GXmpKlwx1Ce7lcYW3 9TmHcrHwd0eheRuDZljiS7AdWnCdgISmYkOjN5E13MJU+/kAePWFW4uRXAQIJNvpVM3q DEzqjwDjfDwUaMfyC2BcSIx5A09I8N718YtJjPReNmN6hiRJI32yFZ9B4C6zHFV/bGiR nMQiwoF7kB93dBhLu9TwQF6jntmbOczUQJ30xaYmVTnF0oQacwnMk9JGZi9b/Ol8Te2V r/x6ziVoACaXTQeMs+uI8QDK/wCuc+cf2Qg9reDqwFHHvrSYGO17qKXUJcsPBmXF++S3 xhvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=z+2wfo0b6l6wRH7/HQaKHUXFfNd/UYIgFbhjFrZaMxc=; b=iyZeqwqtyB7ZLoWT2MXU3iAxnCvLauVPcG35nkPifcPtAZvYukt7tdPv+TD0eGTZEu WnC+bSKGZsGW4tF2+wQT3BVasxxb8mvfIBHbtUk9MP3EgQygvKHmR0Gxdb+zfO2pLaA+ hO66WxIhUMgei71rFnAF0An3amH+DAAbzgl7cSaLE0wu3l7clK9zBHfReVieJJfDhCeV USwyGew8sQYW6OM8Qr3SvRPc8Va8Z+rwroB6leXlF4+uUqF01qVTJKTQuDJ4caQldCTu jjwQImnR1t/Bf5s7AutFFUOELbzO6RFFGYZexUxc2fxlX+I3DTaY8aakjtSRMZYwYVO1 fVrA== X-Gm-Message-State: AE9vXwNZKNJkpLtJukVHdqvRrxpyCZ9Ndpy9rt9o7Im9v0VKaguFe8Q+5i2KzT+yj8/RPQ== X-Received: by 10.98.223.22 with SMTP id u22mr53500123pfg.128.1474353067538; Mon, 19 Sep 2016 23:31:07 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id d5sm75919872pfa.44.2016.09.19.23.31.03 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 19 Sep 2016 23:31:06 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Tue, 20 Sep 2016 16:01:00 +0930 From: Joel Stanley To: davem@davemloft.net Cc: gwshan@linux.vnet.ibm.com, andrew@lunn.ch, andrew@aj.id.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org Subject: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs Date: Tue, 20 Sep 2016 16:00:06 +0930 Message-Id: <20160920063007.24291-7-joel@jms.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20160920063007.24291-1-joel@jms.id.au> References: <20160920063007.24291-1-joel@jms.id.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.300000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG This is because the driver was enabling low-level sensitive interrupt generation where the systems are wired for high-level. All CPU cycles are spent servicing this interrupt. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.9.3 diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 7ba0f2d58a8b..5466df028381 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -223,6 +223,10 @@ static void ftgmac100_start_hw(struct ftgmac100 *priv, int speed) { int maccr = MACCR_ENABLE_ALL; + if (of_machine_is_compatible("aspeed,ast2500")) { + maccr &= ~FTGMAC100_MACCR_PHY_LINK_LEVEL; + } + switch (speed) { default: case 10: