From patchwork Wed Sep 7 16:08:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101834 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp483747qgf; Wed, 7 Sep 2016 12:33:58 -0700 (PDT) X-Received: by 10.98.87.90 with SMTP id l87mr86053730pfb.133.1473276838797; Wed, 07 Sep 2016 12:33:58 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p184si42594370pfp.114.2016.09.07.12.33.58; Wed, 07 Sep 2016 12:33:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756465AbcIGTdz (ORCPT + 27 others); Wed, 7 Sep 2016 15:33:55 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61617 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbcIGTdx (ORCPT ); Wed, 7 Sep 2016 15:33:53 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0MbPlM-1bR9gg1MGK-00IiD1; Wed, 07 Sep 2016 21:33:42 +0200 From: Arnd Bergmann To: Steven Rostedt , Ingo Molnar Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] tracing/hwlat: select TRACER_MAX_TRACE Date: Wed, 7 Sep 2016 18:08:31 +0200 Message-Id: <20160907193421.2571527-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:gOjwJ3mUtczi7BOVsFzGBUny63909EMzqk5tY1i4rj2dpptSxwP GmBEAK88Za7cPmXY9oRQaIYAYYelL2t3oSt/tO3H8g6sJdSxsB4Z+k07SRXEWwZ6EzNYBSd cI4VVB9T3SqTNiM49FbLjb4nm6qRarmxZUxH4Z+QpFcmXC2ObmJcBTWPn1xuXKW4N/VDBI/ 3Hh2NfN58xVuXjr+fvVzg== X-UI-Out-Filterresults: notjunk:1; V01:K0:J1AqfuPbeik=:yNrEQn9TV2gOxevtuA5qc9 pXQl0237PbA0e6cweQOdXOhRkTL7H9y8QzUEGzvsnhKGqecrvzSpaJJK0Yf8zTrDw3ZbTWXRc A0mJ9i3abRVS0H7BK2uvTCKPX+W74dfrQRPpT9mVh+gESNO6DUGAcl4b26GQvKwos4PYKoBBQ l4S+yYCNJFhYTGC+wBi0vwcgYW0bN09he5cgCmvLjjAPQz2V5NuJeEjNREO2kbu+SIPHkNuKL fAnXyWygGk22Sh8SIP5NlKF6CjEzQJ5i4jsXRPwKZ5jZfSRni7UmKlu9irB0i9mn7JCw7iK+i AX4W2psrelprDmsJJYzlSSoQiXDJ0X8ubHFycIX/kCJdzc02KtfKSExrD39sLJrR8E1LhEa2O pC4mvNHj1LjKLbpdOkHqnGyo7mGcrvt1xw/9FVJkO80z3jIBwkAXlX4hpZMyuYiXBTg6kt2vf 0k8tEbww3al5H9/mnq7zZUAau8ODUESSLFQZbi4QMvDY8ZJF8SOETOpMlxdG6wEklP3VYx1oU 9BBOFsRjXErrW08AjEsnxvyXaDpCvNs6/QSjA9ucAZOjLydx1NzNvv83Gl3zNxXfPVPNLXcN1 w7XOXKP9/bs0TgldCr1VOuyN1sy1Tw61oLUSVPFkgw9aN9E+Psfr+eqyOODOTo+hUX8jlsrgV KUNxbv5o0y+oaRsF65gtietlHSxCKvtLvgM2B+u/R8cjKCMX6rFWlpGx3Fj8kx5d2gu0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hwlat_trace cannot work without CONFIG_TRACER_MAX_TRACE: kernel/trace/trace_hwlat.c: In function 'get_sample': kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'? if (sample > tr->max_latency) ^~ kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'? tr->max_latency = sample; ^~ kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init': kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'? tr->max_latency = 0; We also have to enable CONFIG_TRACER_SNAPSHOT, which in turn is a dependency of CONFIG_TRACER_MAX_TRACE. Signed-off-by: Arnd Bergmann Fixes: e7c15cd8a113 ("tracing: Added hardware latency tracer") --- kernel/trace/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 2a96b063d659..54ef701dbd8a 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -219,6 +219,8 @@ config SCHED_TRACER config HWLAT_TRACER bool "Tracer to detect hardware latencies (like SMIs)" select GENERIC_TRACER + select TRACER_MAX_TRACE + select TRACER_SNAPSHOT help This tracer, when enabled will create one or more kernel threads, depening on what the cpumask file is set to, which each thread