From patchwork Thu Sep 1 08:33:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Morten Rasmussen X-Patchwork-Id: 75180 Delivered-To: patch@linaro.org Received: by 10.140.29.8 with SMTP id a8csp168025qga; Thu, 1 Sep 2016 01:33:05 -0700 (PDT) X-Received: by 10.66.132.104 with SMTP id ot8mr3360489pab.66.1472718785841; Thu, 01 Sep 2016 01:33:05 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zi9si4505187pac.192.2016.09.01.01.33.05; Thu, 01 Sep 2016 01:33:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbcIAIdC (ORCPT + 27 others); Thu, 1 Sep 2016 04:33:02 -0400 Received: from foss.arm.com ([217.140.101.70]:51382 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcIAIc6 (ORCPT ); Thu, 1 Sep 2016 04:32:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A21B7CFC; Thu, 1 Sep 2016 01:32:57 -0700 (PDT) Received: from e105550-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 189FD3F220; Thu, 1 Sep 2016 01:32:55 -0700 (PDT) Date: Thu, 1 Sep 2016 09:33:12 +0100 From: Morten Rasmussen To: peterz@infradead.org, mingo@redhat.com Cc: dietmar.eggemann@arm.com, yuyang.du@intel.com, vincent.guittot@linaro.org, mgalbraith@suse.de, sgurrappadi@nvidia.com, freedom.tan@mediatek.com, keita.kobayashi.ym@renesas.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/5] sched: Clean-ups and asymmetric cpu capacity support Message-ID: <20160901083311.GA9409@e105550-lin.cambridge.arm.com> References: <1472640739-8778-1-git-send-email-morten.rasmussen@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1472640739-8778-1-git-send-email-morten.rasmussen@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 11:52:14AM +0100, Morten Rasmussen wrote: > v4: > > - Removed patches already in tip/sched/core. Just discovered an error on the comment of one of those patches :-/ ----8<---- >From a0040f8dfe60696d7e6429f50906d6b17671bbcc Mon Sep 17 00:00:00 2001 From: Morten Rasmussen Date: Thu, 1 Sep 2016 09:24:35 +0100 Subject: [PATCH] sched/fair: Fix wrong comment for capacity_margin The comment for capacity_margin introduced in "sched/fair: Let asymmetric cpu configurations balance at wake-up" got its usage the wrong way round. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 27534e36555b..161fd8eba234 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -116,7 +116,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL; /* * The margin used when comparing utilization with CPU capacity: - * util * 1024 < capacity * margin + * util * margin < capacity * 1024 */ unsigned int capacity_margin = 1280; /* ~20% */