From patchwork Tue Jul 21 02:31:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 51294 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id DDA8C20323 for ; Tue, 21 Jul 2015 02:31:28 +0000 (UTC) Received: by lagw2 with SMTP id w2sf44730737lag.3 for ; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=y0E/OHiKj60KoT4ZtqXLhaGd0W+OfMsaVVf0dGN1BGI=; b=Ywgf9EEAsEC8ASGK01UcysWP80okl7ExZOzNLxWn4ev0SckLl2diGka1jsh8TQ/Af3 arWJNaDYmRC3cqZLbOG+agQk2sDBNfFzW9wVtiE+NalHpv6y7YE8xLJLPJD33DtY1LnO s+bATZ0kOwTQkBi6UK6CwrBOJn2oS3NxoGOBHOVv4+t19O9ADbP6BssZmokqPCscV52m I6obvh2Jazt4rXw6zzNqf1J6Dgd92xA43iQkMUMOm9QiIKjmbQlI66q5rHzkQHSuuELt FgRl4HhagUXFxeXiWmY0jTzMazfMT+h2IcT1AN/3O8LMQfXZ6lRHYStL+lvRF0ji863L 6lNg== X-Gm-Message-State: ALoCoQnaFskfsAG8s+9PtDPXde+2HaypZt65a72hgwYo1BmswagguTD/Hbba5y0ZwirZpoi9kmEd X-Received: by 10.112.253.135 with SMTP id aa7mr16199629lbd.11.1437445887728; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.9.7 with SMTP id v7ls469954laa.107.gmail; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) X-Received: by 10.112.221.9 with SMTP id qa9mr30321733lbc.23.1437445887243; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id x1si2868686lax.165.2015.07.20.19.31.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jul 2015 19:31:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by laem6 with SMTP id m6so108391753lae.0 for ; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) X-Received: by 10.152.207.76 with SMTP id lu12mr18254108lac.29.1437445887089; Mon, 20 Jul 2015 19:31:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1134223lba; Mon, 20 Jul 2015 19:31:26 -0700 (PDT) X-Received: by 10.66.55.41 with SMTP id o9mr66844981pap.148.1437445885345; Mon, 20 Jul 2015 19:31:25 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si39953154pdr.179.2015.07.20.19.31.24; Mon, 20 Jul 2015 19:31:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbbGUCbU (ORCPT + 28 others); Mon, 20 Jul 2015 22:31:20 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:34997 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbbGUCbS (ORCPT ); Mon, 20 Jul 2015 22:31:18 -0400 Received: by pdrg1 with SMTP id g1so110933389pdr.2 for ; Mon, 20 Jul 2015 19:31:18 -0700 (PDT) X-Received: by 10.66.119.105 with SMTP id kt9mr67996580pab.86.1437445878350; Mon, 20 Jul 2015 19:31:18 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id ca13sm1621215pac.25.2015.07.20.19.31.17 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 20 Jul 2015 19:31:17 -0700 (PDT) Date: Tue, 21 Jul 2015 08:01:14 +0530 From: Viresh Kumar To: Guenter Roeck Cc: Daniel Lezcano , Laurent Pinchart , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Message-ID: <20150721023114.GD4994@linux> References: <55AD6314.2050000@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55AD6314.2050000@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 20-07-15, 14:07, Guenter Roeck wrote: > Hi, > > Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface") > in -next causes the following traceback. This is seen with qemu runs for the sh target. > > ------------[ cut here ]------------ > WARNING: at drivers/clocksource/sh_tmu.c:202 > Modules linked in: Can you please try this: diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c index 43c98143f79a..469e776ec17a 100644 --- a/drivers/clocksource/sh_tmu.c +++ b/drivers/clocksource/sh_tmu.c @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced) { struct sh_tmu_channel *ch = ced_to_sh_tmu(ced); - sh_tmu_disable(ch); + if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced)) + sh_tmu_disable(ch); return 0; }