From patchwork Wed Jul 30 17:48:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 34558 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 015DD20792 for ; Wed, 30 Jul 2014 17:48:12 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id kx10sf9923448pab.0 for ; Wed, 30 Jul 2014 10:48:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition; bh=O4K5itReXSmZjAfbdMMpEC0hcmfZp54r7aijlNYJZWI=; b=hpTyxTpHjN/cHbrbYKt7MCMWmgIExfM9Y3V88l5KTA3G2q21TyxMQcPnCOWPV2sHPX zNijY9j7/HGIIIPA3gv3hsyxfC27W/SMVapmxDEYEjpHvr7r61yr5HLiveZwlCIDVwGK 3gSPYGKQvPVvr63MXem6MHpPnH3r6w0kIPEBtzR2PvjPC7/Pt8FthZtK4JRJJinj9yxj 2SEP7A9mpVACtMVYEHSaOKm23y9oQYSFN0fv6oGZdqcqeZ15xDdYnwAzCTWXfoGBX3o2 rcqdyfFoXcLKrmZnC+W7Na7HeWdk2u401NMjpmJizxveMADvDgRkw+MBJ277jsfHnvv8 We+g== X-Gm-Message-State: ALoCoQlM3369LuVHP0TAUwk4rL3cDwHzanj/4um8S46gFLo2/4gxxuNNlHZi6MFTjD5h0X9BlFKO X-Received: by 10.66.148.199 with SMTP id tu7mr2339758pab.5.1406742492235; Wed, 30 Jul 2014 10:48:12 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.20.132 with SMTP id 4ls610671qgj.12.gmail; Wed, 30 Jul 2014 10:48:12 -0700 (PDT) X-Received: by 10.221.56.132 with SMTP id wc4mr6850818vcb.38.1406742492026; Wed, 30 Jul 2014 10:48:12 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id cl2si2426268vcb.98.2014.07.30.10.48.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Jul 2014 10:48:11 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id hq11so2390072vcb.2 for ; Wed, 30 Jul 2014 10:48:11 -0700 (PDT) X-Received: by 10.52.129.200 with SMTP id ny8mr9688780vdb.27.1406742491917; Wed, 30 Jul 2014 10:48:11 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp45556vcb; Wed, 30 Jul 2014 10:48:11 -0700 (PDT) X-Received: by 10.70.128.17 with SMTP id nk17mr699733pdb.89.1406742490996; Wed, 30 Jul 2014 10:48:10 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id wu7si3152217pbc.34.2014.07.30.10.48.10 for ; Wed, 30 Jul 2014 10:48:10 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755689AbaG3RsI (ORCPT + 6 others); Wed, 30 Jul 2014 13:48:08 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:45265 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755670AbaG3RsH (ORCPT ); Wed, 30 Jul 2014 13:48:07 -0400 Received: from leverpostej (leverpostej.cambridge.arm.com [10.1.205.151]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id s6UHm3wo019068; Wed, 30 Jul 2014 18:48:04 +0100 (BST) Date: Wed, 30 Jul 2014 18:48:03 +0100 From: Mark Rutland To: Rob Herring Cc: Robert Richter , Catalin Marinas , Will Deacon , Rob Herring , Arnd Bergmann , Pawel Moll , Ian Campbell , Kumar Gala , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Radha Mohan Chintakuntla , Robert Richter , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC Message-ID: <20140730174803.GF20162@leverpostej> References: <1406732794-20920-1-git-send-email-rric@kernel.org> <1406732794-20920-3-git-send-email-rric@kernel.org> <20140730154626.GD20162@leverpostej> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mark.rutland@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline [...] > >> + gic0: interrupt-controller@801000000000 { > > > > To make this easier to read, please place a comma between 32-bit > > portions of the unit address (e.g. here have 8010,00000000). > > Mark, perhaps a dtc or checkpatch.pl check for this? Sure. Dodgy first atttempt at checkpatch below. ---->8---- It would also be nice to check matching unit-address and reg, but doing that correctly requires knowing #address-cells, which sounds a little painful. I'm not sure where I picked up the comma convention, as it doesn't seem to be in ePAPR. It does seem common though, and is my personal preference: [mark@leverpostej:~/src/linux]% git grep '@[a-z0-9]\+,[a-b0-9]\+' \ -- arch/arm/boot/dts | wc -l 254 [mark@leverpostej:~/src/linux]% git grep '@[a-z0-9]\+,[a-b0-9]\+' \ -- arch/powerpc/boot/dts | wc -l 370 [mark@leverpostej:~/src/linux]% git grep '@[a-z0-9]\+,[a-b0-9]\+' \ -- arch/*/boot/dts | wc -l 631 [...] > >> + uaa0: serial@87e024000000 { > >> + compatible = "arm,pl011", "arm,primecell"; > >> + reg = <0x87e0 0x24000000 0x0 0x1000>; > >> + interrupts = <1 21 4>; > >> + clocks = <&refclk50mhz>; > >> + clock-names = "apb_pclk"; > > > > Is this actually the apb_pclk, or is the the uartclk? I assume it's the > > latter. > > Shouldn't new bindings have both clocks here? A single clock was a > mistake I think (mine in fact). I don't think we fixed it up in the end. It made drivers look a bit messy and it dropped off my priority queue. Cheers, Mark. --- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 182be0f..8aee3f5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2136,6 +2136,14 @@ sub process { } } +# check for difficult-to-read unit-addresses + if (defined $root && + ($realfile =~ /\.dtsi?$/ && $line =~ /([a-z0-9._\-+]++@([0-9a-f]+))\s*{/gi) && + (length($2) > 8)) { + WARN("LONG_DT_UNIT_ADDRESS", + "Consider splitting long unit address \"$2\" with a comma between cells\n" . $herecurr); + } + # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); ----8<----