From patchwork Fri Jun 20 13:23:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 32282 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 99C8B203F4 for ; Fri, 20 Jun 2014 13:23:27 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id db11sf12391001veb.5 for ; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition; bh=tXC8D5cnQJ4IYDCsaUeDVn761mMLA7v/JpoGrU9Z9KE=; b=TwLecG0upz12O5oHKrc1t1rGyobgGiX1EdhDk96K62aXRz7K3t8b27MjRZ8KJupiD5 REGwA+8dNKt9HTB5C34QQZQW2NHrG0nDwDYULC6JFkorHW6N2ROG5V+KIqgwo/SnFDeY 5gvS6I6tyauIZxvJKzyAEI3ipxifs+YqadQVY+UAK9xdt+BHL883Iu8qxabLC4RfKK98 xQNOeaQtMPylk8xochjIuoGOI2G8xlq/m53KMfPsVG/xmSm18YnpbPumnQjdDr/+I5VH Y9tmrsK3Vcun+xls98LYrKU88eTFMVX4YXMmzU2Q/usoQkMJ2kwvQYn0CZ1akBAbi0RJ 3gLQ== X-Gm-Message-State: ALoCoQlX2E0aeoFaPO9Kgz3SyI48AcW6IDHUC5grN1ng1HR2V7ay/pBvA4ABx+klwz8Ql1Hq5pha X-Received: by 10.58.34.47 with SMTP id w15mr1310867vei.20.1403270607373; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.82.201 with SMTP id h67ls983576qgd.2.gmail; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) X-Received: by 10.58.150.100 with SMTP id uh4mr2912707veb.30.1403270607231; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id em7si3986913vdb.53.2014.06.20.06.23.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Jun 2014 06:23:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id la4so3450375vcb.14 for ; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) X-Received: by 10.52.52.168 with SMTP id u8mr2519030vdo.25.1403270607059; Fri, 20 Jun 2014 06:23:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp22069vcb; Fri, 20 Jun 2014 06:23:26 -0700 (PDT) X-Received: by 10.68.129.42 with SMTP id nt10mr4740439pbb.134.1403270606046; Fri, 20 Jun 2014 06:23:26 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xk1si9817513pab.68.2014.06.20.06.23.25; Fri, 20 Jun 2014 06:23:25 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967646AbaFTNXX (ORCPT + 15 others); Fri, 20 Jun 2014 09:23:23 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:45666 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966834AbaFTNXV (ORCPT ); Fri, 20 Jun 2014 09:23:21 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s5KDNBA1019375; Fri, 20 Jun 2014 08:23:11 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5KDNBeu014982; Fri, 20 Jun 2014 08:23:11 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Fri, 20 Jun 2014 08:23:11 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s5KDNBBx031941; Fri, 20 Jun 2014 08:23:11 -0500 Date: Fri, 20 Jun 2014 08:23:10 -0500 From: Nishanth Menon To: Alexandre Courbot CC: Mark Brown , Stephen Warren , Keerthy , Thierry Reding , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Subject: Palmas regulator broken (was Re: [PATCH] ARM: tegra: TN7: relax some regulators) Message-ID: <20140620132310.GA11936@kahuna> References: <1403164154-1362-1-git-send-email-acourbot@nvidia.com> <53A308C8.2070004@wwwdotorg.org> <20140619175643.GR5099@sirena.org.uk> <53A3C613.8030207@nvidia.com> <53A3D85E.7030704@nvidia.com> <20140620094119.GT5099@sirena.org.uk> <53A4039B.7000504@nvidia.com> MIME-Version: 1.0 In-Reply-To: <53A4039B.7000504@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nm@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline + l-o, http://marc.info/?t=140316427500004&r=1&w=2 full thread Minor change in subject to indicate palmas regulator fail On 18:49-20140620, Alexandre Courbot wrote: > On 06/20/2014 06:41 PM, Mark Brown wrote: > >* PGP Signed by an unknown key > > > >On Fri, Jun 20, 2014 at 03:44:46PM +0900, Alexandre Courbot wrote: > > > >>dbabd624d > >>regulator: palmas: Reemove open coded functions with helper functions > > > >>Keerthy, Nishanth, could it be that there is still something wrong with the > >>REGULATOR_LINEAR_RANGE() definitions? > > > >>This seems to be the cause for our trouble, but the other questions might > >>still stand, in case there is interest in discussing them. > > > >There was a bug fix to the Palmas driver which just went to Linus the > >other day, are you sure this isn't fixed in mainline (or -next, it's > >been in -next for a week or something)? > > If you are talking about > > 6b7f2d82d5 > regulator: palmas: Fix SMPS list for 0V > > then it is in my tree. There is actually no difference on > palmas-regulator.c between my tree and the current -next (or Linus' > tree for that instance). > > So it seems to be something else we are dealing with here. Your quote earlier in the thread " _regulator_is_enabled() *also* returns false " Got me curious. Looking at the patch: dbabd624d4eec50b623bab070d1e39a854b2d65c (regulator: palmas: Reemove open coded functions with helper functions) I noticed the following change palmas_is_enabled_smps -> regulator_is_enabled_regmap So I decided to search for enable_reg in palmas-regulator.c and I think it needs valid enable_reg, mask, value for regulator_is_enabled_regmap to work :). Maybe to be sure, we could print the following: PALMAS_SMPS8_VOLTAGE, PALMAS_SMPS8_CTRL, PALMAS_SMPS8_TSTEP, Anyways, I quickly boot tested the following on DRA7evm (which also uses Palmas): [ 1.933939] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 [ 1.944210] smps123: 850 <--> 1250 mV at 1060 mV [ 1.950717] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 [ 1.960754] smps45: 850 <--> 1150 mV at 1060 mV [ 1.967048] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 [ 1.977072] smps6: 850 <--> 1650 mV at 1060 mV [ 1.983077] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 [ 1.992994] smps7: 850 <--> 1030 mV at 1030 mV [ 1.999238] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 [ 2.009161] smps8: 850 <--> 1250 mV at 1060 mV [ 2.015304] palmas-pmic 48070000.i2c:tps659038@58:tps659038_pmic: enable_reg = 0x00, mask =0x00 It does seem to me that either set_mode also should use core functions OR you still need a palmas specific is_enable, enable/disable functions (contrary to the claim of the patch in question - which I think introduced regressions). Otherwise, completely untested diff below - can you give this a shot? diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index b982f0f..bbfe22f 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -964,6 +964,20 @@ static int palmas_regulators_probe(struct platform_device *pdev) return ret; pmic->current_reg_mode[id] = reg & PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; + + dev_err(&pdev->dev, "enable_reg = 0x%02x, mask =0x%02x\n", + pmic->desc[id].enable_reg, + pmic->desc[id].enable_mask); + pmic->desc[id].enable_reg = + PALMAS_BASE_TO_REG(PALMAS_LDO_BASE, + palmas_regs_info[id].ctrl_addr); + pmic->desc[id].enable_mask = + PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; + /* + * The following completely ignores + * pmic->current_reg_mode[id] (set_mode) + */ + pmic->desc[id].enable_val = SMPS_CTRL_MODE_ON; } pmic->desc[id].type = REGULATOR_VOLTAGE;