From patchwork Tue May 13 14:56:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 30057 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f199.google.com (mail-ie0-f199.google.com [209.85.223.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 28DE320369 for ; Tue, 13 May 2014 14:57:18 +0000 (UTC) Received: by mail-ie0-f199.google.com with SMTP id rl12sf2079481iec.10 for ; Tue, 13 May 2014 07:57:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=bfyzVrsAy6fLqlvu1zaElM6STk/bGSBojQZQwWpV1FI=; b=jUJcDHgbpcYm77dKH983aLJuQxF/bPnEe7XyYLEeLfBFTHYIFrfD7xhmJ+NTSLoZTu SfO5Fx2PL/NxSV30f+Qoy5WB0NkPrbPNVWr51+8Y8DC3GLTN4+LhGu5GwtpxaFAUX3XT uZgp89tSgQ6eaiAn0t6k/kOONCA/iM7v0DO/A6Q51oijzYapYgoSNWIa67l0ebKkl3R0 MK78FrN6JOWx5yEBqjZhcXLaU7WvxQIix1pzrHx06/F2HHfkCV61cV7x5VlPACUbLNNN eCgEw0M48kG0i5+JlYzZvc2mfoV/0RUJ8hDNqnM3kIkaue3dArgmPg4Slyr2/u/egWmu S9Yw== X-Gm-Message-State: ALoCoQmZkfa+nOE3BUnflTJN9zgJ0LYRHhuNnJbbHY3ATyCuS4x6Ajpnkt4oqUXCecFp4rAl7aSz X-Received: by 10.182.125.4 with SMTP id mm4mr7457257obb.49.1399993037393; Tue, 13 May 2014 07:57:17 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.24.181 with SMTP id 50ls567210qgr.92.gmail; Tue, 13 May 2014 07:57:17 -0700 (PDT) X-Received: by 10.52.14.72 with SMTP id n8mr211829vdc.73.1399993037242; Tue, 13 May 2014 07:57:17 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id gu9si2684920vdc.88.2014.05.13.07.57.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 May 2014 07:57:17 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id ld13so607058vcb.12 for ; Tue, 13 May 2014 07:57:17 -0700 (PDT) X-Received: by 10.52.2.229 with SMTP id 5mr24414491vdx.24.1399993037171; Tue, 13 May 2014 07:57:17 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp157716vcb; Tue, 13 May 2014 07:57:15 -0700 (PDT) X-Received: by 10.68.141.102 with SMTP id rn6mr5874387pbb.43.1399993035194; Tue, 13 May 2014 07:57:15 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ek4si8131745pbc.167.2014.05.13.07.57.14; Tue, 13 May 2014 07:57:14 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964948AbaEMO5G (ORCPT + 27 others); Tue, 13 May 2014 10:57:06 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51752 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933006AbaEMO5D (ORCPT ); Tue, 13 May 2014 10:57:03 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s4DEutOT000423; Tue, 13 May 2014 09:56:55 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4DEusl4016637; Tue, 13 May 2014 09:56:54 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Tue, 13 May 2014 09:56:54 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4DEurdB016998; Tue, 13 May 2014 09:56:54 -0500 Date: Tue, 13 May 2014 09:56:48 -0500 From: Felipe Balbi To: Jim Davis CC: Stephen Rothwell , linux-next , linux-kernel , balbi , Greg Kroah-Hartman , Grant Likely , Rob Herring , linux-usb Subject: Re: randconfig build error with next-20140513, in drivers/usb/phy/phy-msm-usb.c Message-ID: <20140513145648.GD1151@saruman.home> Reply-To: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Tue, May 13, 2014 at 06:46:05AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’: > drivers/usb/phy/phy-msm-usb.c:1461:2: error: implicit declaration of > function ‘devm_reset_control_get’ > [-Werror=implicit-function-declaration] > motg->link_rst = devm_reset_control_get(&pdev->dev, "link"); > ^ > drivers/usb/phy/phy-msm-usb.c:1461:17: warning: assignment makes > pointer from integer without a cast [enabled by default] > motg->link_rst = devm_reset_control_get(&pdev->dev, "link"); > ^ > drivers/usb/phy/phy-msm-usb.c:1465:16: warning: assignment makes > pointer from integer without a cast [enabled by default] > motg->phy_rst = devm_reset_control_get(&pdev->dev, "phy"); > ^ > cc1: some warnings being treated as errors > make[3]: *** [drivers/usb/phy/phy-msm-usb.o] Error 1 Here's a patch: will send it shortly diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index fbbced8..ec531a4 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -173,6 +173,7 @@ config USB_ISP1301 config USB_MSM_OTG tristate "Qualcomm on-chip USB OTG controller support" depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST) + depends on RESET_CONTROLLER select USB_PHY help Enable this to support the USB OTG transceiver on Qualcomm chips. It