From patchwork Tue Dec 10 13:55:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Olsa X-Patchwork-Id: 22211 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D44D623908 for ; Tue, 10 Dec 2013 13:55:54 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id v10sf23032533pde.0 for ; Tue, 10 Dec 2013 05:55:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-disposition; bh=hRu2HwZvtkXgf0dgOsFcqvxAGY3I+9k50/BM5SvnvGQ=; b=AmiluZERvR1phQb8emCSXBQX8xnUk03S0MrUC9BWenvQXsC7pN33DlQzIcnqPrGHZm EYbMmocLHz3yaRnUPtoKnWfsQRmJsUAouCvovOe2UuA1A+KzZ/SsntB8bq7/PyEww6HQ K9YWC32TzUEv7it8and/e0dCvFnHpjCqC5MmdviwwQeFmfFWl6sAKc2Q6idQQi2EV4sT sxkUlD1Jg36Wr/hyTo1f5hEa6ADYhb1S5kcZ7YahAVSCB0kvfwwZWmnxreBa1nVWEOMz 0BCmN1FYsxnFmMx2L4sxBWRiYgEVQW/s9C/yIcmlhDkENSHIrx60mx+PgD7TXknlGNOq GLeg== X-Gm-Message-State: ALoCoQmyFzQhb4Nm1RY8bgBfvjAtA+GjqLg1SiOlNGXQov2BPsjlsiWDjwv1Hkl+DjnmE0OX80g5 X-Received: by 10.66.219.97 with SMTP id pn1mr14333266pac.9.1386683753482; Tue, 10 Dec 2013 05:55:53 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.97.201 with SMTP id ec9ls2541690qeb.60.gmail; Tue, 10 Dec 2013 05:55:53 -0800 (PST) X-Received: by 10.220.174.200 with SMTP id u8mr13968923vcz.6.1386683753359; Tue, 10 Dec 2013 05:55:53 -0800 (PST) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx.google.com with ESMTPS id be7si5158207vcb.110.2013.12.10.05.55.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 05:55:53 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.54; Received: by mail-vb0-f54.google.com with SMTP id g10so564741vbg.27 for ; Tue, 10 Dec 2013 05:55:53 -0800 (PST) X-Received: by 10.53.2.36 with SMTP id bl4mr118758vdd.32.1386683753052; Tue, 10 Dec 2013 05:55:53 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp189699vcz; Tue, 10 Dec 2013 05:55:52 -0800 (PST) X-Received: by 10.49.2.170 with SMTP id 10mr44016476qev.24.1386683751791; Tue, 10 Dec 2013 05:55:51 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id r5si11970343qat.176.2013.12.10.05.55.51 for ; Tue, 10 Dec 2013 05:55:51 -0800 (PST) Received-SPF: pass (google.com: domain of jolsa@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBADtjOS006618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Dec 2013 08:55:45 -0500 Received: from krava.brq.redhat.com (dhcp-1-115.brq.redhat.com [10.34.1.115]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id rBADthFb025085; Tue, 10 Dec 2013 08:55:43 -0500 Date: Tue, 10 Dec 2013 14:55:42 +0100 From: Jiri Olsa To: Jean Pihet Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, Ingo Molnar , Arnaldo , patches@linaro.org, Will Deacon Subject: [PATCH 1/2] perf tools: Automate setup of FEATURE_CHECK_(C|LD)FLAGS-all variables Message-ID: <20131210135542.GE8108@krava.brq.redhat.com> References: <1386678244-13535-1-git-send-email-jean.pihet@linaro.org> MIME-Version: 1.0 In-Reply-To: <1386678244-13535-1-git-send-email-jean.pihet@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: jolsa@redhat.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline On Tue, Dec 10, 2013 at 01:24:02PM +0100, Jean Pihet wrote: > Add CFLAGS and LDFLAGS for each feature to be checked during the > build. This allows to pass particular flags and parameters to the > feature checks compilation. > > Use the per-feature check flags for the unwinding feature in order > to correctly compile the test-all, libunwind and libunwind-debug-frame > feature checks. > > This change set simplifies the flags passing mechanism between the > Makefiles in config/Makefile and config/feature-checks; this > could be farther optimized by moving the compilation flags to the > per-feature check flags for all features to be checked. > > Tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR > set in 'make -C tools/perf' > > > Jean Pihet (2): > perf: add per-feature check flags > perf: unwinding: use the per-feature check flags > > tools/perf/config/Makefile | 52 ++++++++++++++++++------------- > tools/perf/config/feature-checks/Makefile | 8 ++--- > 2 files changed, 34 insertions(+), 26 deletions(-) > while at it, how about following update thanks, jirka --- Instead of explicitly adding same value into FEATURE_CHECK_(C|LD)FLAGS-all variables we can do that automatically. Signed-off-by: Jiri Olsa --- tools/perf/config/Makefile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index f75d814..05fd0e2 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -55,9 +55,6 @@ else FEATURE_CHECK_LDFLAGS-libunwind = $(LIBUNWIND_LDFLAGS) FEATURE_CHECK_CFLAGS-libunwind-debug-frame = $(LIBUNWIND_CFLAGS) FEATURE_CHECK_LDFLAGS-libunwind-debug-frame = $(LIBUNWIND_LDFLAGS) - # and the flags for the test-all case - FEATURE_CHECK_CFLAGS-all += $(LIBUNWIND_CFLAGS) - FEATURE_CHECK_LDFLAGS-all += $(LIBUNWIND_LDFLAGS) endif ifeq ($(NO_PERF_REGS),0) @@ -168,6 +165,17 @@ CORE_FEATURE_TESTS = \ stackprotector-all \ timerfd +# Set FEATURE_CHECK_(C|LD)FLAGS-all for all CORE_FEATURE_TESTS features. +# If in the future we need per-feature checks/flags for features not +# mentioned in this list we need to refactor this ;-). +set_test_all_flags = $(eval $(set_test_all_flags_code)) +define set_test_all_flags_code + FEATURE_CHECK_CFLAGS-all += $(FEATURE_CHECK_CFLAGS-$(1)) + FEATURE_CHECK_LDFLAGS-all += $(FEATURE_CHECK_LDFLAGS-$(1)) +endef + +$(foreach feat,$(CORE_FEATURE_TESTS),$(call set_test_all_flags,$(feat))) + # # So here we detect whether test-all was rebuilt, to be able # to skip the print-out of the long features list if the file