From patchwork Thu Nov 28 09:58:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Olsa X-Patchwork-Id: 21831 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8AEA823FCB for ; Thu, 28 Nov 2013 09:58:37 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id g10sf20795857pdj.5 for ; Thu, 28 Nov 2013 01:58:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-disposition; bh=tA0Ryj1P3dENoELtPnklG4qUoLbKAbmZnZnNKjyiCVQ=; b=e5mejHuiikvULaLyanRtmj4XuljbmjUWwC12267I22O6heHMGpGLqvPAurgG9G8Jnl R0V2XrwkBxOp+emiPkZEWeSj3KVcrJC5yICQQvyXErDALQR24L8jdN4V7RXza5aEDa0l cDHXJCQ0V094i+QRw3Aj9lTFdniMkkEURTx0X6nX3B/Ymp2IpFtgWTc0Nt/+hpbCjNma U8bmvU4O+b2j0Swc7AZsLkYKerHvUJO/mXc5cQgAZ81PEFSdEfcwH0+sNLwOyssXJji0 e/u61b4tNiibAM0S4A8l2KJUQ2x57dTSKVA99tHfnjKrj8GtoTM6CNLgqdSYFVxcBzmt xKbQ== X-Gm-Message-State: ALoCoQk2+Zh/L884/Ux9B9yaQSqhsBmI62LzRE7FPi/9WrIL7ZPliDvg1Tyx9abkCP2LbaNAepGo X-Received: by 10.66.219.97 with SMTP id pn1mr13083256pac.9.1385632716273; Thu, 28 Nov 2013 01:58:36 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.82.49 with SMTP id f17ls2667011qey.54.gmail; Thu, 28 Nov 2013 01:58:36 -0800 (PST) X-Received: by 10.58.118.84 with SMTP id kk20mr12277219veb.26.1385632716052; Thu, 28 Nov 2013 01:58:36 -0800 (PST) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id pv1si22607615veb.132.2013.11.28.01.58.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Nov 2013 01:58:36 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id lc6so5832523vcb.27 for ; Thu, 28 Nov 2013 01:58:36 -0800 (PST) X-Received: by 10.220.192.198 with SMTP id dr6mr17287492vcb.19.1385632715736; Thu, 28 Nov 2013 01:58:35 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp2779vcz; Thu, 28 Nov 2013 01:58:35 -0800 (PST) X-Received: by 10.42.215.11 with SMTP id hc11mr8554329icb.47.1385632714738; Thu, 28 Nov 2013 01:58:34 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id w9si31255648iga.3.2013.11.28.01.58.34 for ; Thu, 28 Nov 2013 01:58:34 -0800 (PST) Received-SPF: pass (google.com: domain of jolsa@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAS9w4fI025522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Nov 2013 04:58:04 -0500 Received: from krava.brq.redhat.com (dhcp-1-243.brq.redhat.com [10.34.1.243]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id rAS9w1x5003719; Thu, 28 Nov 2013 04:58:02 -0500 Date: Thu, 28 Nov 2013 10:58:01 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jean Pihet , Arnaldo Carvalho de Melo , Will Deacon , linaro-kernel@lists.linaro.org, patches@linaro.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check flags Message-ID: <20131128095801.GA1245@krava.brq.redhat.com> References: <1385583394-3703-1-git-send-email-acme@infradead.org> <1385583394-3703-35-git-send-email-acme@infradead.org> <20131127224323.GB1350@krava.redhat.com> MIME-Version: 1.0 In-Reply-To: <20131127224323.GB1350@krava.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: jolsa@redhat.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline On Wed, Nov 27, 2013 at 11:43:23PM +0100, Jiri Olsa wrote: > On Wed, Nov 27, 2013 at 05:16:34PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Jean Pihet > > > > Use the per-feature check flags for the unwinding feature in order to > > correctly compile the libunwind and libunwind-debug-frame feature > > checks. > > > > Tested on ARMv7 and ARMv8 with 'make DEBUG=1 LIBUNWIND_DIR=/usr/local -C > > tools/perf' > > this one makes my build fail: > > [jolsa@krava perf]$ make > BUILD: Doing 'make -j4' parallel build > > Auto-detecting system features: > ... backtrace: [ on ] > ... dwarf: [ on ] > ... fortify-source: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... gtk2-infobar: [ on ] > ... libaudit: [ on ] > ... libbfd: [ on ] > ... libelf: [ on ] > ... libelf-getphdrnum: [ on ] > ... libelf-mmap: [ on ] > ... libnuma: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libpython-version: [ on ] > ... libslang: [ on ] > ... libunwind: [ OFF ] > ... on-exit: [ on ] > ... stackprotector: [ on ] > ... stackprotector-all: [ on ] > ... timerfd: [ on ] > > config/Makefile:335: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 1.1 > > ... > > LINK perf > /bin/ld: cannot find -lunwind > /bin/ld: cannot find -lunwind-x86_64 > collect2: error: ld returned 1 exit status > make[1]: *** [perf] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [all] Error 2 > > > I haven't checked this one.. will do tomorrow we need to plug libunwind flags/libs only if the $(feature-libunwind) is enabled.. NO_LIBUNWIND - user's decision not to link with libunwind or architecture that does not support it $(feature-libunwind) - if it's actually installed attached change fixies that for me, feel free to use/merge it jirka diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 80ea6d8..5f531db 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -345,12 +345,12 @@ ifndef NO_LIBUNWIND # non-ARM has no dwarf_find_debug_frame() function: CFLAGS += -DNO_LIBUNWIND_DEBUG_FRAME endif - endif - CFLAGS += -DHAVE_LIBUNWIND_SUPPORT - EXTLIBS += $(LIBUNWIND_LIBS) - CFLAGS += $(LIBUNWIND_CFLAGS) - LDFLAGS += $(LIBUNWIND_LDFLAGS) + CFLAGS += -DHAVE_LIBUNWIND_SUPPORT + CFLAGS += $(LIBUNWIND_CFLAGS) + EXTLIBS += $(LIBUNWIND_LIBS) + LDFLAGS += $(LIBUNWIND_LDFLAGS) + endif # ifneq ($(feature-libunwind), 1) endif ifndef NO_LIBAUDIT