From patchwork Wed Jul 17 15:18:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 18403 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f197.google.com (mail-vc0-f197.google.com [209.85.220.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C95CC25D87 for ; Wed, 17 Jul 2013 15:18:30 +0000 (UTC) Received: by mail-vc0-f197.google.com with SMTP id ha12sf2873339vcb.0 for ; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to:date:from :to:cc:subject:message-id:references:mime-version:in-reply-to :user-agent:sender:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition; bh=j+HZlpUQ1zQLn5PHSOFFk1pU6eEChx2xJjz9mTL27KU=; b=VgsAE+xkluzmzGkTHJ8jZfVbWANh0c26+DgnTSg7ydzggO9cvA1jcP8MPdguH8kmhp WJk754jo7i4FutCky53yhVHEAujVFBFX/qACssvZ+OPry5m6Up2PbFK9ZIRySiXLSNCL oP9akeijS/sPLzL6sZnvduNPi3HzF4CkwxAmVB/Nodm9chYmgcEtCRJzbpCxBN6uT7iy YYxfH/0aELTA+vflr9o0ODFkbxfdDdoh50n4am7PmbMq/B6FO8xJoVzMt2VPzJiqLzaT 6H+geKp0eGdLA2GoOirtwbNoFxIPmo8Hb3ixTZkBQAEHbdqCnEyAf53CV9Rle2Z4zHrF nw+A== X-Received: by 10.236.111.40 with SMTP id v28mr3886195yhg.27.1374074310445; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.13.168 with SMTP id i8ls919654qec.65.gmail; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) X-Received: by 10.58.97.199 with SMTP id ec7mr2305429veb.72.1374074310204; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) Received: from mail-vb0-x22b.google.com (mail-vb0-x22b.google.com [2607:f8b0:400c:c02::22b]) by mx.google.com with ESMTPS id s7si1490102vcr.24.2013.07.17.08.18.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Jul 2013 08:18:30 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::22b is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::22b; Received: by mail-vb0-f43.google.com with SMTP id e12so1467018vbg.30 for ; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) X-Received: by 10.220.198.133 with SMTP id eo5mr2285562vcb.24.1374074310130; Wed, 17 Jul 2013 08:18:30 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.149.77 with SMTP id s13csp177750vcv; Wed, 17 Jul 2013 08:18:29 -0700 (PDT) X-Received: by 10.180.82.196 with SMTP id k4mr16535410wiy.0.1374074308759; Wed, 17 Jul 2013 08:18:28 -0700 (PDT) Received: from caramon.arm.linux.org.uk (caramon.arm.linux.org.uk. [78.32.30.218]) by mx.google.com with ESMTPS id bs16si737558wib.78.2013.07.17.08.18.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 17 Jul 2013 08:18:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux+multiple=linaro.org@arm.linux.org.uk designates 78.32.30.218 as permitted sender) client-ip=78.32.30.218; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:42371) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1UzTUh-0000bx-1O; Wed, 17 Jul 2013 16:18:19 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1UzTUe-000175-OH; Wed, 17 Jul 2013 16:18:16 +0100 Date: Wed, 17 Jul 2013 16:18:16 +0100 From: Russell King - ARM Linux To: Stefano Stabellini Cc: Ian Campbell , Arnd Bergmann , patches@linaro.org, Julien Grall , linux-kernel@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled Message-ID: <20130717151816.GN24642@n2100.arm.linux.org.uk> References: <1373897706-15331-1-git-send-email-julien.grall@linaro.org> <20130717151148.GM24642@n2100.arm.linux.org.uk> MIME-Version: 1.0 In-Reply-To: <20130717151148.GM24642@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: Russell King - ARM Linux X-Gm-Message-State: ALoCoQlOpZxD/fsLZ2yDKnMOQtX8uk107n7uN68z2jhLK3BMJDwuVS8CL64z9q7h0I79h/eBIgpx X-Original-Sender: linux@arm.linux.org.uk X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::22b is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass (test mode) header.i=@arm.linux.org.uk Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline On Wed, Jul 17, 2013 at 04:11:48PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 17, 2013 at 02:25:38PM +0100, Stefano Stabellini wrote: > > On Mon, 15 Jul 2013, Julien Grall wrote: > > > Even if uncompress debug is disabled, some board will continue to print > > > information during uncompress step. > > > > Are you talking about DEBUG_UNCOMPRESS? > > Should I read the sentence as "even if DEBUG_UNCOMPRESS is not selected, > > some board will continue to print information during the uncompress step"? > > > > Isn't this a bug in the platform specific code that should be fixed anyway? > > Hang on, let's be clear what's going on here. > > 1. The normal output from the decompressor is *not* debugging. By that > I mean the "Uncompressing kernel... done" message. That is part of > user output. > > 2. In non-multiplatform environments, the decompressor will normally use > the putc/flush functions found in arch/arm/mach-*/include/mach/uncompress.h > to implement its output, irrespective of the DEBUG_UNCOMPRESS setting. > (An interesting point is that DEBUG_UNCOMPRESS really should depend on > MULTIPLATFORM so that this point is explicit - the option requires > MULTIPLATFORM to be set.) > > 3. DEBUG_UNCOMPRESS allows the functions which we've implemented for LL > debug to be re-used for decompressor output. > > 4. When DEBUG_UNCOMPRESS is not set in a multiplatform kernel, the > decompressors putc() and flush() functions are stubbed out. > > So, it's quite right that you get output from the decompressor even when > DEBUG_UNCOMPRESS is not set. There's no problem with that. Does this patch help to explain this? arch/arm/Kconfig.debug | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index e401a76..583f4a0 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -804,9 +804,19 @@ config DEBUG_LL_INCLUDE config DEBUG_UNCOMPRESS bool - default y if ARCH_MULTIPLATFORM && DEBUG_LL && \ - !DEBUG_OMAP2PLUS_UART && \ + depends on ARCH_MULTIPLATFORM + default y if DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \ !DEBUG_TEGRA_UART + help + This option influences the normal decompressor output only for + multiplatform kernels. Normally, multiplatform kernels disable + decompressor output because it is not possible to know where to + send the decompressor output. + + When this option is set, the selected DEBUG_LL output method + will be re-used for normal decompressor output on multiplatform + kernels. + config UNCOMPRESS_INCLUDE string