From patchwork Tue Nov 12 09:30:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 179176 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp7855934ilf; Tue, 12 Nov 2019 01:34:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyrtc0xApSqxy/mVWaxfAJ7BiHksNnigl+9qbYLMOLZmxcXRLMvy4y2foRhepZpc3pWiXB/ X-Received: by 2002:a17:906:1d59:: with SMTP id o25mr26661964ejh.17.1573551285803; Tue, 12 Nov 2019 01:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573551285; cv=none; d=google.com; s=arc-20160816; b=hQ4rtWS1z8FgEuQP0xwj6Owbq90pUlOvsZcKhSVJ20tNz6HHDvoFInuOgFV0xfwshz xzNrPYPdrATBRfVFl6FFPJGR84OmhRkQtOij9Q0fFG+xJSCVRxkl5xc3yqgtG59VQsx2 kEDLLZrzs3aBz7ZctINkmyCDfU1VoY4N8p5MvmXGK87Fa8HbNkehaeGLLfDyU0A5bzvO IPu0TTcV3nUrr5JiiD+Xqc98oLoKJGzIuVRUYeBUuL6bgMe5dKhfBxuv/gj6ZuUhdyW1 LZfuur4vdHOGa4D0BD7FkSI96qW9eGiB0WTE2fiIk0ehZCKx/HntKctPSlbyeenNMWaw kgjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=wCSewvXVUgMDz5w6dvSazxnK7bEtLa5TAautWTc/+jM=; b=TUqX9vKe3/GoO/3SDH6km17n3fCOvgyqo5bxHi1kHWTIpTHsUpiUdKh5VcgFcez0Uz +K0Al9Tg2r4ZQF7SCA1Jd9OwRRsEif9xyTOIZHPBIq5dyGYzVEqMRS+gPhxL8ld6m7Ao rguPdGGQ2DWwZUz/21+ixrlYzX/73TCJfABn1MjG76drppHz5f5p6kZvuqdbikhUCofi 4Lzk9Z1wWcWo9aRNxCGSBnhhf6+onCxfLqDl1o7AWH67uSiiPlJkxs9PlKrQHocoAElu mlKaua+/Aow3r55OuVSppYgWSyUDxQCkm2Ne8CYjEVlmDc2QBPBx2bj0+hWdugbGWcCn LyUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cx17si8305812ejb.421.2019.11.12.01.34.45; Tue, 12 Nov 2019 01:34:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727451AbfKLJe2 (ORCPT + 26 others); Tue, 12 Nov 2019 04:34:28 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:6203 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727126AbfKLJe0 (ORCPT ); Tue, 12 Nov 2019 04:34:26 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CAD395C1204561B52913; Tue, 12 Nov 2019 17:34:24 +0800 (CST) Received: from localhost.localdomain (10.69.192.58) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Tue, 12 Nov 2019 17:34:19 +0800 From: John Garry To: , CC: , , , John Garry Subject: [PATCH 4/4] scsi: hisi_sas: Stop converting a bool into a bool Date: Tue, 12 Nov 2019 17:30:59 +0800 Message-ID: <1573551059-107873-5-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1573551059-107873-1-git-send-email-john.garry@huawei.com> References: <1573551059-107873-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The !! operator on a bool is pointless, so remove an example in hisi_sas_rescan_topology(). Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index c72fc59353bd..03588ec3c394 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1413,7 +1413,7 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 state) struct hisi_sas_phy *phy = &hisi_hba->phy[phy_no]; struct asd_sas_phy *sas_phy = &phy->sas_phy; struct asd_sas_port *sas_port = sas_phy->port; - bool do_port_check = !!(_sas_port != sas_port); + bool do_port_check = _sas_port != sas_port; if (!sas_phy->phy->enabled) continue;