From patchwork Mon Jun 3 15:49:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suzuki K Poulose X-Patchwork-Id: 165649 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp4646917ili; Mon, 3 Jun 2019 08:54:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdlyZATeuvvsTXSFLpWUmS3/A1rj7CWwIIjRr+1f9fi8cVFJznlH3MNP+Q/F36v9qQoB/O X-Received: by 2002:a17:90a:898e:: with SMTP id v14mr4892028pjn.119.1559577246268; Mon, 03 Jun 2019 08:54:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559577246; cv=none; d=google.com; s=arc-20160816; b=b2WyeMlKrvi2FaJ9oEz7t8SP+9lNLH1WBQ3xT5yJQHakyn3473Blp5vvQoA59L3cXF dKahhmD2JzNYHp3RK2UYAKyQSOrCZRbEPzjc3ZcubdJNVKMoDKSMq4MiudjDWGJgS6fY 0LmmjQF4f2d5gj2HAWvEIWrPftYXpP2754Mt0UDmkgvJUamF5P5BF6ct66ZPa/RZ/MSv Ye6R9AWzOuNgMPotKODxDy8MdD+opGlEUyZdYcOH3vVzd/7QeU0VAH5tWg5sEWwMHJsj Q/mkWEuqVrmRgUr6TlH3BDKDQ6cAbWsaU8zAOYLjPSpFDYGEHzlTV+pEMSYbtv5kDHax BZUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=O7ISRCXzymDpF64+4Ey3SWB2dAYGuKtYlOL4EnWaatg=; b=j8IArHDA9o80UyUvPpJBPU0V2UMMPyDPKj6Kpno4uvYrgVUi+xxuAMJorq9rfm8Z4K CNlcVNJBPVUL0tsoaikzLLjDfh6GC7y1okEuSf10SC0PmQewW106V+QdUJYNWWneUolP 07uWnRWPs23yu/T6/rOQ2DvZ2y5McNPxA5xGJJOQyNbqrIyz2KRwYqWlO3PSArQc7GHg lMTEFjwKvwgiG6vey3bFjfeoHyrap//xB2rBTvUBU2fNmdzmkMeBzWjSirDOIWcjdeID t9VbCOW+vb/hTwiG5AS4w8oNF0UK0rV7WkUgUYt+p0rfO3YmsulmEiifKpzXKl2zYh6B Xo6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u126si15462989pgu.117.2019.06.03.08.54.05; Mon, 03 Jun 2019 08:54:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729708AbfFCPyF (ORCPT + 30 others); Mon, 3 Jun 2019 11:54:05 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53770 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729229AbfFCPvf (ORCPT ); Mon, 3 Jun 2019 11:51:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 80ADD1715; Mon, 3 Jun 2019 08:51:35 -0700 (PDT) Received: from en101.cambridge.arm.com (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 94DA63F246; Mon, 3 Jun 2019 08:51:34 -0700 (PDT) From: Suzuki K Poulose To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, suzuki.poulose@arm.com Subject: [RFC PATCH 25/57] drivers: Add generic match by name helper Date: Mon, 3 Jun 2019 16:49:51 +0100 Message-Id: <1559577023-558-26-git-send-email-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559577023-558-1-git-send-email-suzuki.poulose@arm.com> References: <1559577023-558-1-git-send-email-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a generic helper to match a device by its name. Also use the generic match by device name helper for bus_find_device_by_name. Since the new match function is also exported, let us convert this to a static inline function. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Signed-off-by: Suzuki K Poulose --- drivers/base/bus.c | 24 ------------------------ drivers/base/core.c | 6 ++++++ include/linux/device.h | 21 ++++++++++++++++++--- 3 files changed, 24 insertions(+), 27 deletions(-) -- 2.7.4 diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 0a58e96..229e83ee 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -342,30 +342,6 @@ struct device *bus_find_device(struct bus_type *bus, } EXPORT_SYMBOL_GPL(bus_find_device); -static int match_name(struct device *dev, void *data) -{ - const char *name = data; - - return sysfs_streq(name, dev_name(dev)); -} - -/** - * bus_find_device_by_name - device iterator for locating a particular device of a specific name - * @bus: bus type - * @start: Device to begin with - * @name: name of the device to match - * - * This is similar to the bus_find_device() function above, but it handles - * searching by a name automatically, no need to write another strcmp matching - * function. - */ -struct device *bus_find_device_by_name(struct bus_type *bus, - struct device *start, const char *name) -{ - return bus_find_device(bus, start, (void *)name, match_name); -} -EXPORT_SYMBOL_GPL(bus_find_device_by_name); - /** * subsys_find_device_by_id - find a device with a specific enumeration number * @subsys: subsystem diff --git a/drivers/base/core.c b/drivers/base/core.c index db19185..88fa037 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3352,3 +3352,9 @@ int device_match_devt(struct device *dev, void *pdevt) return dev->devt == *(dev_t *)pdevt; } EXPORT_SYMBOL_GPL(device_match_devt); + +int device_match_name(struct device *dev, void *name) +{ + return sysfs_streq(dev_name(dev), name); +} +EXPORT_SYMBOL_GPL(device_match_name); diff --git a/include/linux/device.h b/include/linux/device.h index 6ad1a27..b4a9cd2 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -167,15 +167,30 @@ int device_match_of_node(struct device *dev, void *np); int device_match_acpi_dev(struct device *dev, void *adev); int device_match_fwnode(struct device *dev, void *fwnode); int device_match_devt(struct device *dev, void *pdevt); +int device_match_name(struct device *dev, void *name); int bus_for_each_dev(struct bus_type *bus, struct device *start, void *data, int (*fn)(struct device *dev, void *data)); struct device *bus_find_device(struct bus_type *bus, struct device *start, void *data, int (*match)(struct device *dev, void *data)); -struct device *bus_find_device_by_name(struct bus_type *bus, - struct device *start, - const char *name); + +/** + * bus_find_device_by_name - device iterator for locating a particular device + * of a specific name. + * @bus: bus type + * @start: Device to begin with + * @name: name of the device to match + * + * This is similar to the bus_find_device() function, but it handles + * searching by a name automatically. + */ +static inline struct device *bus_find_device_by_name(struct bus_type *bus, + struct device *start, + const char *name) +{ + return bus_find_device(bus, start, (void *)name, device_match_name); +} /** * bus_find_device_by_of_node : device iterator for locating a particular device