From patchwork Mon Jun 3 15:49:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Suzuki K Poulose X-Patchwork-Id: 165648 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp4646887ili; Mon, 3 Jun 2019 08:54:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRKhxsKko16R23ssevQLZu6i/s+UmjaDeLkWPhoNXWewwhUbrLf5G0eDsWCwrkaWOFg4bT X-Received: by 2002:a63:4045:: with SMTP id n66mr1253417pga.386.1559577244788; Mon, 03 Jun 2019 08:54:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559577244; cv=none; d=google.com; s=arc-20160816; b=KmdMG4UEfAE3DlYjpvN3wq1aEIrHuZxYLvwpDkwykL6mycjljyIdS4PvnIYEOUtx6A 8fRzvFaKbsInisypI9GrXpDXMgvBJ24/tl3KXKyPiui+fQB71mCEjnk1+IEHdD2d2ab9 hxfYcKWzM5UOeF0kQK1a/JBPHhTUETsEwCC6YG634XfrJ3tpNhOgbV2XYddhGeLHx0q1 4JdduFrLqEr4FjcCDju/oaT34uFkct7zXfythV2nEHm2g7FR3N57AOzqOePOAQWc2+l2 dQLJjehCEd+LU1clxdQksr57K02C5VUgxHXBk6MYFnowIcAS8zdKB7HT04U36t1Nf4lt txoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=af6She6IJAV5l/88Wa5gKZPByxQdtf0ENhtouIPAnOo=; b=N2DEli67s/xQadzLCMb87M7YztQLfed+u6Xoxte9HW4bJNHnzY8udUR0fin83ahDeT sWWaF2RG1nqsjD+hYIbNkLcdeP1pVqa1FZ0wWwxMrS6CR8GBtWdqI21bMAHBD2qi/QDw vlyJMp3kquc8AWtCdSASAgup4fBKUn+tp6F8KUg/OiTTo1cYx2zjSyBBV/eQ3tl9U9EK hfYwQWJtDBfUDBcv2Li5oHxoKlDLstQDFpoEJdC20SQmMpOiRebdWcZuP8Vv5qkGB/Fu LH1R8EM4Q/wcwDWLDE31PazrQNOlmrhog3Aznl2RMB2TKReSX99ibfZTcocOfTWh2DTu 7CTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u126si15462989pgu.117.2019.06.03.08.54.04; Mon, 03 Jun 2019 08:54:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbfFCPvf (ORCPT + 30 others); Mon, 3 Jun 2019 11:51:35 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53724 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728963AbfFCPv3 (ORCPT ); Mon, 3 Jun 2019 11:51:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF225174E; Mon, 3 Jun 2019 08:51:28 -0700 (PDT) Received: from en101.cambridge.arm.com (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 322BE3F246; Mon, 3 Jun 2019 08:51:27 -0700 (PDT) From: Suzuki K Poulose To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, suzuki.poulose@arm.com, Inki Dae , Seung-Woo Kim , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Eric Anholt Subject: [RFC PATCH 20/57] platform: Add a helper to find device by driver Date: Mon, 3 Jun 2019 16:49:46 +0100 Message-Id: <1559577023-558-21-git-send-email-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559577023-558-1-git-send-email-suzuki.poulose@arm.com> References: <1559577023-558-1-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are a couple of places where we reuse platform specific match to find a device. Instead of spilling the global varilable everywhere, let us provide a helper to do the same. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Inki Dae Cc: Seung-Woo Kim Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Eric Anholt Signed-off-by: Suzuki K Poulose --- drivers/base/platform.c | 14 ++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 9 +++------ drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +-- drivers/gpu/drm/vc4/vc4_drv.c | 3 +-- include/linux/platform_device.h | 3 +++ 5 files changed, 22 insertions(+), 10 deletions(-) -- 2.7.4 Tested-by: Heiko Stuebner diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 4d17298..daca44f 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -1197,6 +1197,20 @@ struct bus_type platform_bus_type = { }; EXPORT_SYMBOL_GPL(platform_bus_type); +/** + * platform_find_device_by_driver - Find a platform device with a given + * driver. + * @start: The device to start the search from. + * @drv: The device driver to look for. + */ +struct device *platform_find_device_by_driver(struct device *start, + const struct device_driver *drv) +{ + return bus_find_device(&platform_bus_type, start, (void *)drv, + (int (*)(struct device *, void *))platform_match); +} +EXPORT_SYMBOL_GPL(platform_find_device_by_driver); + int __init platform_bus_init(void) { int error; diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index ba8932a..b357e0d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -244,9 +244,7 @@ static struct component_match *exynos_drm_match_add(struct device *dev) if (!info->driver || !(info->flags & DRM_COMPONENT_DRIVER)) continue; - while ((d = bus_find_device(&platform_bus_type, p, - &info->driver->driver, - (void *)platform_bus_type.match))) { + while ((d = platform_find_device_by_driver(p, &info->driver->driver))) { put_device(p); if (!(info->flags & DRM_FIMC_DEVICE) || @@ -414,9 +412,8 @@ static void exynos_drm_unregister_devices(void) if (!info->driver || !(info->flags & DRM_VIRTUAL_DEVICE)) continue; - while ((dev = bus_find_device(&platform_bus_type, NULL, - &info->driver->driver, - (void *)platform_bus_type.match))) { + while ((dev = platform_find_device_by_driver(NULL, + &info->driver->driver))) { put_device(dev); platform_device_unregister(to_platform_device(dev)); } diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index cb938d3..4eb4fb8 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -338,8 +338,7 @@ static struct component_match *rockchip_drm_match_add(struct device *dev) struct device *p = NULL, *d; do { - d = bus_find_device(&platform_bus_type, p, &drv->driver, - (void *)platform_bus_type.match); + d = platform_find_device_by_driver(p, &drv->driver); put_device(p); p = d; diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 6d9be20..d159eb5 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -236,8 +236,7 @@ static void vc4_match_add_drivers(struct device *dev, struct device_driver *drv = &drivers[i]->driver; struct device *p = NULL, *d; - while ((d = bus_find_device(&platform_bus_type, p, drv, - (void *)platform_bus_type.match))) { + while ((d = platform_find_device_by_driver(p, drv))) { put_device(p); component_match_add(dev, match, compare_dev, d); p = d; diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index cc46485..a82b3ec 100644 --- a/include/linux/platform_device.h +++ b/include/linux/platform_device.h @@ -52,6 +52,9 @@ extern struct device platform_bus; extern void arch_setup_pdev_archdata(struct platform_device *); extern struct resource *platform_get_resource(struct platform_device *, unsigned int, unsigned int); +extern struct device * +platform_find_device_by_driver(struct device dev*, + const struct device_driver *drv); extern void __iomem * devm_platform_ioremap_resource(struct platform_device *pdev, unsigned int index);