From patchwork Wed May 29 09:58:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 165368 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp9655859ili; Wed, 29 May 2019 03:00:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzeGwiMQGZG9ox5yxmiy0ZsY3ZqcC3Zt9GCphWpBoIsrXmzi6SHscQFBhxvD4ZSwOy/rQgQ X-Received: by 2002:a17:902:8214:: with SMTP id x20mr117042174pln.308.1559124040352; Wed, 29 May 2019 03:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559124040; cv=none; d=google.com; s=arc-20160816; b=GnFxXEkzLe8GyVv7stO5EeQOlUjYc2G0REn5EZ+Q1WiBOGbe5UjfBWvzZvNpaxbo4q /FzuP/3klDRZ5usdtIiWEAGNIvPMpgS5I6eQJB3XE7dwP/bJ0koihFwZly4uyQxpJ7rk bR82P8pQsO4awy9WdXT8dwnQnUxOvE41yQdXvx7V+urJreeMME+OIZVL3hE9GV/mmd8q PFwKTvGqmBY1OWKsOqn2HY4s6B78S1LTqY4JVJLBdG/SfWfcmKrjtsR3oYJ5d34Dwh7c IS12pGHc+pEhGVOOTtLldd/avUpPuNcN7nyrUaNKKoZmKDdgl7JutKO9+bIl2Z1c6ngb XJSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=Rxv397qlEiS2ToB7sxNyNC43iMkEDkKRa+Awvu8ylNI=; b=AElpKR1RgkBbe0IOqgZpgqEd5xGVRN5HWknfvVBLltFWTP6RQ0nNbdFEdpWVNefP5Q GXE6ux8J7G1g6IvxgjxptxFvAIC5faMqLo8XQqtT+cfQ9aSofqld8Uq8W9KsQP06LPzx PErGRsCoKQ704SPCDFrsVEItZxTmrpjuHAvNeiQ4nNxWjdoLmQ20CI0HnYKbwbaEKDeL tkHmOSCvYQOT+Ny9Tj3BENE+d4pOwe7A1OwWRSFEEsFEH2KbdNtHVD6AyXttEZWIDeZz cEn+/vzFRoETml4yOjxfLL3aiQHrKx+Fl2iMnYzy+SJdfa1x2JfBIjUIUySRaOr753wO QGkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si1264509pfn.226.2019.05.29.03.00.40; Wed, 29 May 2019 03:00:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbfE2KAj (ORCPT + 30 others); Wed, 29 May 2019 06:00:39 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:35662 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726670AbfE2KAY (ORCPT ); Wed, 29 May 2019 06:00:24 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 98DF4438F3D9E84A517B; Wed, 29 May 2019 18:00:22 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Wed, 29 May 2019 18:00:12 +0800 From: John Garry To: , CC: , , , Xiang Chen , "John Garry" Subject: [PATCH 6/6] scsi: hisi_sas: Disable stash for v3 hw Date: Wed, 29 May 2019 17:58:47 +0800 Message-ID: <1559123927-160502-7-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1559123927-160502-1-git-send-email-john.garry@huawei.com> References: <1559123927-160502-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiang Chen For v3 hw, stash is enabled to promote performance, but it does little help for promoting performance according to current test. What's more, it causes exception for some situations, so disable it. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index fbf0a1e9c8c2..b92aa6b37e1d 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -28,6 +28,7 @@ #define ITCT_CLR_EN_MSK (0x1 << ITCT_CLR_EN_OFF) #define ITCT_DEV_OFF 0 #define ITCT_DEV_MSK (0x7ff << ITCT_DEV_OFF) +#define SAS_AXI_USER3 0x50 #define IO_SATA_BROKEN_MSG_ADDR_LO 0x58 #define IO_SATA_BROKEN_MSG_ADDR_HI 0x5c #define SATA_INITI_D2H_STORE_ADDR_LO 0x60 @@ -554,6 +555,7 @@ static void init_reg_v3_hw(struct hisi_hba *hisi_hba) /* Global registers init */ hisi_sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, (u32)((1ULL << hisi_hba->queue_count) - 1)); + hisi_sas_write32(hisi_hba, SAS_AXI_USER3, 0); hisi_sas_write32(hisi_hba, CFG_MAX_TAG, 0xfff0400); hisi_sas_write32(hisi_hba, HGC_SAS_TXFAIL_RETRY_CTRL, 0x108); hisi_sas_write32(hisi_hba, CFG_AGING_TIME, 0x1);