From patchwork Wed Apr 3 08:37:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 161685 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp52907jan; Wed, 3 Apr 2019 01:37:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpYeFTwRAXhyU9hBnzQ1sGJ0vkXRtPGboFbEtrkgycSDgvOD2LKCKUOXgSZMI8MdgdIqwf X-Received: by 2002:a63:e818:: with SMTP id s24mr1713182pgh.190.1554280662570; Wed, 03 Apr 2019 01:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554280662; cv=none; d=google.com; s=arc-20160816; b=wliQu9kdoBpTEipQc+otiyOvISXjSInToxihmUUIGZB829oVcYSTveMjpCqPHtO+69 1BcRm9FwmJgxHSDIUuNVNu2YdXEDJW+e8VFaxsF8Dh8GuAh6sl0t9PRrQHlVaH6Uw8WV Y8GX+5LFULaKhhyOl+VHOVXNzsKQNj6ldsZbVmQ8ur6f6YwbClkHSjBSSbCu/e/1t7rS T7MzLnpsLmOj6W6o4Gqun8hZM52V+KTw3bi2ANsp3e1L1qOH25XigYRLjavv7zUhEELM rIvIc7IigDFYsdpLeBWaK0UeZ5jncfG9scXZHSZk1lH7DVly7SuGD+waMhijVUFwrmq7 OJIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=NXrOmhTOgezL4ubc/Y0MTBBLZoVfYe2kvigugO9+MJc=; b=cOOoK0I/dWh7hh6lEFRhFbsEA6YjDHP5qKrL7cWpDxSqFfBH4Yn4hZLFAIlnwMNCa0 yv7kUU7UQg+7GTbCcUrmwbJKJSdveXrCPTAfy1h9kz4fn8NQdspkpLyEcvArpM4BqdH+ zpxywsB9rO5BjlelH4Bqn8uXYq4TFclJdpGQ48FTOif6sVpIAvA2phXIkDekReSdSFDv QYuEavbzFbdn2P3mw5VdXFCMEeOCHyAurin3pyO465K0oIig7rmDWivKOhe8OphRXfw0 WLmMH6COUHGTZrHSiHvmneJcS7OoSF8TFg10z5JXt/B5MjTId5vils6YkB/KeFi4OHaX TZRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=q3Zptqq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4si13436368pls.183.2019.04.03.01.37.42; Wed, 03 Apr 2019 01:37:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=q3Zptqq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbfDCIhl (ORCPT + 31 others); Wed, 3 Apr 2019 04:37:41 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:49898 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbfDCIhk (ORCPT ); Wed, 3 Apr 2019 04:37:40 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id x338bLIC027479; Wed, 3 Apr 2019 17:37:22 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x338bLIC027479 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1554280642; bh=NXrOmhTOgezL4ubc/Y0MTBBLZoVfYe2kvigugO9+MJc=; h=From:To:Cc:Subject:Date:From; b=q3Zptqq6VUXcs7m7nyLAYRqWHTXrIkrQiPyPEMQVgsMqZPZ55GO34FopFgNmguoh4 bxm46Uhqb1kp06t/DOh4u9BOB6tyBt1+jKVTuF2W6/xPK1wMnzFLonVHqVVdtpQqNk tTPObt20l0MQp3SCbCEuPfUqu+b/Q4AAQjm0F37JXldViTCfnsuCSrMPLF8EPAMzGH k8MRQ8AYTBjSeyy0rDOo440t197s+g36fdv34Q/XrF4m9rRQW7QbNui1m+dpdCfi/h JQHO7N8cfJU3PC9/vnIfwx6sKoDLQN6puUbexbC+dvVy5OAYah5mZ9+fp3cuPSLGg+ sVkPgXP4vZdag== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Greentime Hu , Vincent Chen Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] nds32: vdso: fix and clean-up Makefile Date: Wed, 3 Apr 2019 17:37:13 +0900 Message-Id: <1554280633-11457-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - $(call if_changed,...) must have FORCE as a prerequisite - vdso.lds is a generated file, so it should be prefixed with $(obj)/ instead of $(src)/. - cmd_vdsosym is a one-liner rule, so the assignment with '=' is simpler. Signed-off-by: Masahiro Yamada --- arch/nds32/kernel/vdso/Makefile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- 2.7.4 Acked-by: Greentime Hu diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile index e6c50a7..01a9610 100644 --- a/arch/nds32/kernel/vdso/Makefile +++ b/arch/nds32/kernel/vdso/Makefile @@ -28,7 +28,7 @@ CPPFLAGS_vdso.lds += -P -C -U$(ARCH) $(obj)/vdso.o : $(obj)/vdso.so # Link rule for the .so file, .lds has to be first -$(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) +$(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE $(call if_changed,vdsold) @@ -40,9 +40,7 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE # Generate VDSO offsets using helper script gen-vdsosym := $(srctree)/$(src)/gen_vdso_offsets.sh quiet_cmd_vdsosym = VDSOSYM $@ -define cmd_vdsosym - $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@ -endef + cmd_vdsosym = $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@ include/generated/vdso-offsets.h: $(obj)/vdso.so.dbg FORCE $(call if_changed,vdsosym) @@ -65,7 +63,7 @@ gettimeofday.o : gettimeofday.c FORCE # Actual build commands quiet_cmd_vdsold = VDSOL $@ - cmd_vdsold = $(CC) $(c_flags) -Wl,-n -Wl,-T $^ -o $@ + cmd_vdsold = $(CC) $(c_flags) -Wl,-n -Wl,-T $(real-prereqs) -o $@ quiet_cmd_vdsoas = VDSOA $@ cmd_vdsoas = $(CC) $(a_flags) -c -o $@ $< quiet_cmd_vdsocc = VDSOA $@