From patchwork Thu Feb 14 03:05:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 158297 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp835187jaa; Wed, 13 Feb 2019 19:06:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IZv1bEUPRPTwflnbxtrL2pFvd0peyEYdWxLqJSQEkqIOkjNUg/uLNYM5kDQPoexmcjHJ0BJ X-Received: by 2002:a63:f253:: with SMTP id d19mr1595145pgk.14.1550113603460; Wed, 13 Feb 2019 19:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550113603; cv=none; d=google.com; s=arc-20160816; b=NAJymS7fKk1ivBx0CSTyBZTkSDU5jPDc2r07dRMcUPg3UzBUqzY6yWihD6j/sVXRUp hPzWSA3vO+WdR9f8qUO/+icJYfxNDrExd+HmdfTz7Q763YbVb8RQzgHWh/bKaV38zvBY IR0N/EwK7WMRqd9+NWfj9fJNHQ50JQzRfUbyYt/EUq+5XgVbTTdd/MIT13wB+qN+wHku QCnD7SPRgM1GWO4Ze1fhbqghWoDx1MIr5Rv4LtKfwDPE3MWE29l5Zhu4Dttng8QPrldZ AbmoJZoTvMSYoIvtCoWUGvwqOmCqYfQnWuyFxmfY7GUX8qVORkEZXhmjDKoOnNS9yW2e sZvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=qmqFYzrO309vIKYtqQ9mMRdEh6RcNYvW13KnAIs8pHM=; b=vFjkyXJ/u6CvCH9upd/EX7LTFT3X/4XGEwqwlBG1hkFMnWEdpu1Bo0anXkQPENsHWH F9nfI8h98MqHjyHmqG6EnI7FYB7nBxYIUkpakQCQgWOWEr3u4mDmfFWnNh/lgEf0Q9FA hJNEc8ZJxJwfKAxFHEmgrNcqcfuD/o8UK+b/azKb4mSUveoVHrSWqmmkeOBgicSZp5za DoyuCjH2GMYRVmIzjpuXbddimI+ZgFRgm5Tn+vhURNL23wEORMAvS2fE+BypVuhSmCjZ l9LzBrYBoQzR7eEn0hBNOARGMX0CTu5WeA52D0so01zA2HO/n9MYNSsBFBHMIFW2A7EF FW8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=gogeCQ+a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7si1139616pls.290.2019.02.13.19.06.43; Wed, 13 Feb 2019 19:06:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=gogeCQ+a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405328AbfBNDGm (ORCPT + 31 others); Wed, 13 Feb 2019 22:06:42 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:64383 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393468AbfBNDGF (ORCPT ); Wed, 13 Feb 2019 22:06:05 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x1E35Pg4020814; Thu, 14 Feb 2019 12:05:26 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x1E35Pg4020814 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1550113527; bh=qmqFYzrO309vIKYtqQ9mMRdEh6RcNYvW13KnAIs8pHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gogeCQ+aeK2rK/zRoyN4DEr2oaQQkFWJzU1sHYgz8JNh1OEpdRF17PLUQ0EROdROE 68/9EMAPqH+gcEcLAcLrvGo8YDGs2hEu8dnY7VNZVXSolDGEnMH+DGkSib03Dsw8KA LixGtZOySh/1Ya29F+xPK70pPsiPhR0KJnyVJjVN101xAvKRyfbb34mC/KXuTL5tXQ EfSW2LsF2T1V1c3kOst+Bgz8+dTo5iARpIx1ZWHBsiKVrWlgOji1TLmJ33Ctd3P2Pp XRNBmy0rbkBMcIu9GXuIMaC5wAeP88Qh7OeFNOOvLtI2+Nl79/5laC89j/Ir61c3LX Fn3zd9l5sxe0g== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 3/8] kbuild: set KBUILD_MODULES=1 all the time for single target %/ Date: Thu, 14 Feb 2019 12:05:16 +0900 Message-Id: <1550113521-23577-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1550113521-23577-1-git-send-email-yamada.masahiro@socionext.com> References: <1550113521-23577-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is fine to set KBUILD_MODULES=1 when CONFIG_MODULES is disabled. It is actually how "make allnoconfig all" works. On the other hand, KBUILD_MODULES=1 is unneeded for the %.ko pattern. It is just a matter of whether modules.order is generated or not. Signed-off-by: Masahiro Yamada --- Makefile | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/Makefile b/Makefile index 3cf253d..fe62de3 100644 --- a/Makefile +++ b/Makefile @@ -1710,16 +1710,13 @@ endif # Modules /: prepare FORCE - $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ - $(build)=$(build-dir) + $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir) # Make sure the latest headers are built for Documentation Documentation/ samples/: headers_install %/: prepare FORCE - $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ - $(build)=$(build-dir) + $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir) %.ko: prepare FORCE - $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ - $(build)=$(build-dir) $(@:.ko=.o) + $(Q)$(MAKE) $(build)=$(build-dir) $(@:.ko=.o) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost # FIXME Should go into a make.lib or something