From patchwork Fri Dec 14 16:01:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 153888 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2236362ljp; Fri, 14 Dec 2018 08:02:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/V9T2NdQ52Stqp9ZZo/2iZYMkDNmSVuHQyeXXHqugm8cKQMdfwud/nEg4IdVigH+3W75W/m X-Received: by 2002:a63:e915:: with SMTP id i21mr3063045pgh.409.1544803338239; Fri, 14 Dec 2018 08:02:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544803338; cv=none; d=google.com; s=arc-20160816; b=rEipmr2YEIc1SZGy4knV54OsgHZDmhJJwvWspWKGM4LJsVPtGH9IH7jPiotD4X04oD bFkNUPV7W19o2ONhsogStrUkq1/uKvH84y9peBRB5B51muWZa0/HOCPBbBFbSKESKeqq 90vZOUOJzKztqP4GlKFFRk+PpChbbMcw6x+H0LYnFfwHrQnRmho+Cu66Jd/sENfEpUZV c9o356l7LH135Ucj2cnTrZh5bj1kLejucA0RMeoDZeUJR/bTmJnDNNlXFCnJ2MKKxa63 kwt4gSu2ZMGMYKtUWWkofrK/lrCO5Xxby0KCntYRpbvLNb3pLGWuXZgbM/Jt4WJozM0P +NaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=bEsSijZyC8zHwK9eeXI5Xlit0fDMhlGIwei2/4qKE5U=; b=QUbt0uAX2Es0sojVqUumeErGa78Hx1XJBJ2sM2Tez3StCf5SUy4h+N9I4PFzuc+x/3 RG7L3SomGepDdSyzzNg0KCec4pGJ6J0QxBEN9zDKD9hY186VxvO0pN57+zHMJvUXI3M/ gmSTW2+vjXzmFZl0/xsk1V/TwDR/O8Ml37Z4OTcZ7mDkqPo8lfiOn3/Xi7X2Ntqp4qBR r6+3IOHwBKMvEiFjjVIXINbJga+dPnMyKwqMh52Hk5ee2g0Yregpj1O5ysLm8HhOd1ji VCS8L2ZP9au1FrWjBb51p2/qMrC6cOHIbnAu2b94qSQv8LRwEFsb4yGlvOsuY7Jn9SV4 Jz+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fb2pJjke; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 133si4640426pfw.64.2018.12.14.08.02.17; Fri, 14 Dec 2018 08:02:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fb2pJjke; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729641AbeLNQCM (ORCPT + 31 others); Fri, 14 Dec 2018 11:02:12 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44456 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbeLNQCI (ORCPT ); Fri, 14 Dec 2018 11:02:08 -0500 Received: by mail-wr1-f66.google.com with SMTP id z5so5910665wrt.11 for ; Fri, 14 Dec 2018 08:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bEsSijZyC8zHwK9eeXI5Xlit0fDMhlGIwei2/4qKE5U=; b=fb2pJjkeqFw4gsOmDX2q3ZBWp+kyZrEWa3zh2f5JCrV4xrawRuMRAMOwX7Cv27iq2d WoKOl1wWuADauCD6inwCoGnp8WlRQmsT5Dwj+zKFj6vW4+yxHpoQ+T85Au5Y9LOAo6wS jG1gUx7otTmGq9rfG7MWhgu9pdZOK+BCC0qPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bEsSijZyC8zHwK9eeXI5Xlit0fDMhlGIwei2/4qKE5U=; b=On9p7VR0nQU78YNYYC8DxpYr5GDPeM0Tl1+5Pd2IBhDj5KwRiT4Zrx6euG9KH53Bvf 5YRiSU93YaHnX+T6vkXTFSyjwgmASqssRdRTEiJERifmqqK2Oh6PFuFxO0os86P5aNa6 SjmjkTY0R+3iwunJftrEOS/jftuQn1drWHCCIQn2b/yEgbAY/ZVQnNw1lm4qt6EKHUTu ZU+j8fhVkFybVTzS2Ex/COq865bRtip0EVDUydwBLfQijcoqlu6Nmvz+Yr1N6b/31X9B PQD+RSAUeP2o1bakV/0bRGmm4BAKEhe4lwS1vFwpUEgsL3Wy9H8wgHqWw3fBuuvAiV3h 1PgQ== X-Gm-Message-State: AA+aEWZ1JZKOrPkOIukdQMaN3hu9inemEt9BvO/uZDr+U+pyCwWWCZPU SMJg7YMvXVdjdROid642pH25gA== X-Received: by 2002:adf:fd87:: with SMTP id d7mr2958962wrr.74.1544803326747; Fri, 14 Dec 2018 08:02:06 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:ed2e:a6ad:f6ef:ff8e]) by smtp.gmail.com with ESMTPSA id e17sm7888738wri.36.2018.12.14.08.02.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Dec 2018 08:02:05 -0800 (PST) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH v2 2/3] sched/fair: trigger asym_packing during idle load balance Date: Fri, 14 Dec 2018 17:01:56 +0100 Message-Id: <1544803317-7610-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544803317-7610-1-git-send-email-vincent.guittot@linaro.org> References: <1544803317-7610-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c215f7a..9591e7a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8861,7 +8861,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but