From patchwork Fri Dec 14 08:05:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 153784 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1782454ljp; Fri, 14 Dec 2018 00:06:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/XU4jTnwT64e1PzrkdFX8R5XXGuZof4N/CvY5FbY1Cu5rCaZ1wo+eWgqQTRI1X1836oftOL X-Received: by 2002:a63:ff62:: with SMTP id s34mr1845373pgk.325.1544774778820; Fri, 14 Dec 2018 00:06:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544774778; cv=none; d=google.com; s=arc-20160816; b=LtvFFFM37sv8g8Djy2Ig3+O11ZX/lAtX/IJsKYDThJ6QeaU+v2xJ/x86VzJOQIpaG3 wlhL4d2ZYx6hoBPV0qcAt4U4oQxiQYHF0HE/Os0woo2MPdBC1C9TH6bHHfVXemxQ+Djq b83o8z0xIUFej/8wmDhA02oYo8vxbeQqjhBNFSIodHMUsPnn0NlsbjMDUEFIKu1PHAPD T8dg9wftEF/foWLUs38fGKle3tiT9HLEumbnLJaOu0ukKWz0EOY+pdZAZ4MR7qeif4nM wzMvM5dfmFMXNQ06OORqmw9gw56TFRG3xyPzrVaQvecrextsGkX6VoG854/c860K9TW7 wD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=vr8fjlTWSuQGReVOV6A95VVc8nQk5JFmiCc4p1232Qs=; b=b3cXscqzlA8z7AkhX/kcjSRUAFlo1omrtM5DdS31J/qn4vJ+j/izqkBKl/aIN7047J 011vtuTVHXvG4C0SKNRXniqyW2X2SsKDaXhmMbdSvg4g7Hxo65Buu3ZgP3RK99IyCKPL kLMSToEPJKkJ3mCotJ2pwfXvqOlpPzX/IGKT45U4i3rxi3EGP5xMDqTDTlO3K3V8qmH1 gzH3s1eZFDoMFzfFrR8CrSX4zlcXnrMdFa83h9YY8zI2rVFo2wEK9J9u/B4xFnAy0fU2 7wCv2Bk4C6k1R16o646KXND3GPx6engNpaCUTb8PbwM5bYqk3/u9f8jhCqcKKUr47ypj jUEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=I3041r5K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 23si3581784pfu.2.2018.12.14.00.06.18; Fri, 14 Dec 2018 00:06:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=I3041r5K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728196AbeLNIGR (ORCPT + 31 others); Fri, 14 Dec 2018 03:06:17 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:28078 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbeLNIGN (ORCPT ); Fri, 14 Dec 2018 03:06:13 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id wBE85gQT007194; Fri, 14 Dec 2018 17:05:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com wBE85gQT007194 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1544774743; bh=vr8fjlTWSuQGReVOV6A95VVc8nQk5JFmiCc4p1232Qs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I3041r5Knm6b+kaLVYalZJWugpGR5GLXvq1xmQwrVq83RYvZBKHQvvuitiOMqSy9O /OwHZlr91OLniJrkopfK8duDBMmi4UbfItTPaP4nl/EE71rMrUbZEhAKKm4sANgzTH OAPY2VAtYXa5q53dD6A6kVBtutfOvLMo7Mu45IZXNEzO2euxRz1Nsk3TaELHfngbPT omCNq8jJWnH8C/OUyv+E/jesd2hU7oENStt6H54OwOdvPccPOQJzs/Sc5wecTRH+fR NmKxcA+U2SQ0F0buUyqq5+7bkwC/Yr4H9MAEK71Eif4otxgrWfLHzEWfABtKdfz1hJ tnH7vTngRUxCA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Nick Desaulniers , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally Date: Fri, 14 Dec 2018 17:05:38 +0900 Message-Id: <1544774739-13471-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544774739-13471-1-git-send-email-yamada.masahiro@socionext.com> References: <1544774739-13471-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden by -Werror=strict-prototype later. Let's add -Werror=strict-prototypes unconditionally because it is supported by GCC 4.6, and also by Clang. Signed-off-by: Masahiro Yamada --- Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.7.4 Reviewed-by: Nick Desaulniers diff --git a/Makefile b/Makefile index 3bbc16a..bcb943e 100644 --- a/Makefile +++ b/Makefile @@ -423,7 +423,7 @@ LINUXINCLUDE := \ $(USERINCLUDE) KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE -KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ +KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \ -Werror-implicit-function-declaration \ -Wno-format-security \ @@ -828,9 +828,6 @@ KBUILD_CFLAGS += $(call cc-option,-fconserve-stack) # disallow errors like 'EXPORT_GPL(foo);' with missing header KBUILD_CFLAGS += $(call cc-option,-Werror=implicit-int) -# require functions to have arguments in prototypes, not empty 'int foo()' -KBUILD_CFLAGS += $(call cc-option,-Werror=strict-prototypes) - # Prohibit date/time macros, which would make the build non-deterministic KBUILD_CFLAGS += $(call cc-option,-Werror=date-time)