From patchwork Mon Nov 26 17:07:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 152052 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp91669ljp; Mon, 26 Nov 2018 09:08:00 -0800 (PST) X-Google-Smtp-Source: AFSGD/XFBZmx/9eWXhpJWUimwgJqMfoDh6eMlfLUHp3On7fgL0m9h9hQIdHYWTrDwSPjsKRqdQw/ X-Received: by 2002:a17:902:e085:: with SMTP id cb5mr28355372plb.24.1543252080204; Mon, 26 Nov 2018 09:08:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543252080; cv=none; d=google.com; s=arc-20160816; b=pO1buyBqWfpSCpk2nle/SzzspNEW6F9+RqLVP+OBVC1QOaMghP75uZz/ESbiloBvHm bkxAbz3yKkYsScoD2IZTewJDtnfsTt/GY34853J1/r1dM1cjRsnW0RVHL8jgNMGjSjNn ABsDmwiDThH/SIkeT+HHjOSXk5F60Dr75CqKmJnjCnfBQl5YWo8iPKFx4BACkj+hT7z2 h+rtmy/tLIl2UJN+dPAKfkyv4D/WkbwhVoURLXKXw5t/hIg8TwTzljC70opvv3J/GI+D iUnXhg0d08YNAkQhlsLxbW99xxnmFpLtMiarUger2g0sbBdvK2zF/uJdgrxJPWlrBuk6 trxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=S3Pe7jCrFGE7JxF6m5RucqgSGzB7M8lCaWDcweULJ1Y=; b=yEIQMap+LewgYiM5086pVCjwXcjwQWT1OgmwqLIT7zLO7D8ESm6IiBT4MWwbJPmTIG Xps1Se5x7wsuRfjNMGKnxt3tEb/JJ8OkPYusAhODe0eHdr5UWzMGai7OAQQrtCI/F+AW HSS7u98UpAcvmemiSu+HEtKoKEf3MJqB1lr4iB0Eo3bZC/E602ToDCI5t97EJVXY7SBU mDE2vOKOVXOhsNkqwZ7nbbv1DD5g2cNn/4wwc9EfyiG6Ft24lcUlpexFVv5/P2u2MCXz 2bUk+JOAjwa7rTVge7HyP1sEmd+0WAQD1qyScW07JTQfMAm0WUgh6a+12fezQut4qQpY IPww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y25si809125pgl.226.2018.11.26.09.07.46; Mon, 26 Nov 2018 09:08:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbeK0ECO (ORCPT + 32 others); Mon, 26 Nov 2018 23:02:14 -0500 Received: from foss.arm.com ([217.140.101.70]:42942 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbeK0ECN (ORCPT ); Mon, 26 Nov 2018 23:02:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAB75169E; Mon, 26 Nov 2018 09:07:30 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BA90A3F911; Mon, 26 Nov 2018 09:07:30 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 3555C1AE0B58; Mon, 26 Nov 2018 17:07:48 +0000 (GMT) From: Will Deacon To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, akpm@linux-foundation.org, sean.j.christopherson@intel.com, Will Deacon Subject: [PATCH v4 3/5] x86/pgtable: Drop pXd_none() checks from pXd_free_pYd_table() Date: Mon, 26 Nov 2018 17:07:45 +0000 Message-Id: <1543252067-30831-4-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1543252067-30831-1-git-send-email-will.deacon@arm.com> References: <1543252067-30831-1-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The core code already has a check for pXd_none(), so remove it from the architecture implementation. Cc: Chintan Pandya Cc: Toshi Kani Cc: Michal Hocko Cc: Andrew Morton Acked-by: Thomas Gleixner Reviewed-by: Toshi Kani Signed-off-by: Will Deacon --- arch/x86/mm/pgtable.c | 6 ------ 1 file changed, 6 deletions(-) -- 2.1.4 diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index 59274e2c1ac4..e95a7d6ac8f8 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -811,9 +811,6 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr) pte_t *pte; int i; - if (pud_none(*pud)) - return 1; - pmd = (pmd_t *)pud_page_vaddr(*pud); pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL); if (!pmd_sv) @@ -855,9 +852,6 @@ int pmd_free_pte_page(pmd_t *pmd, unsigned long addr) { pte_t *pte; - if (pmd_none(*pmd)) - return 1; - pte = (pte_t *)pmd_page_vaddr(*pmd); pmd_clear(pmd);