From patchwork Fri Nov 23 07:57:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 151840 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1755158ljp; Thu, 22 Nov 2018 23:57:53 -0800 (PST) X-Google-Smtp-Source: AFSGD/XZiYV4xJm8UNGQDVLP1cJUbZvJXf7CWhjefVfXl0WBPMSX+ofp8smiiNTeNI25x4aFOOBN X-Received: by 2002:a63:6704:: with SMTP id b4mr13213597pgc.100.1542959873775; Thu, 22 Nov 2018 23:57:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542959873; cv=none; d=google.com; s=arc-20160816; b=ijf7o585yXuOIqEXh3AfS5hod7qkV2P9ldqaascghZd7JJKKySi+AZJ3f5rNC0YS5I QihTq2sa7I8fu8Ee6EAqBmtHN5yCVH/pHvgA6+ENGParU1gidLreUuRlK3sfHbhUyJb0 6hhTBUlh8VGmacNHrlfw4tXtAW4xJqyqQTI720sD4OzEFdBlXouhdqVmcAL4BjqZyhxH VTJiOa3KEpJwOlU/dGoggvzZIg5TQiyjWB8QXTRckL5KzNX2fI3Pb0hp4G3ehjiicOph IdkqiZBG5hHQU41MM/E8eWIz/H75t8scKBRmGq5tTJkIERYKgg/vQ2n5DHOt12c7/Wlz S0/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=QiRqh8yetZM167uoY2zCS9SR1gaXHDJe1PX6A2FbUWk=; b=KJoEEPWdGaQIAUbz4cPUJvqbYDAFyqOiQX6ALvWZ74knjryzlfxsIRKQrzwrNajocV YY/N15jipq5OAOQYcA1dM9bbnGb8tIDOGxgSu+6zB39qgfIi+u6cEfWDy6S4DHuZemli UfOsLHRrzkNQng8ssJFlZA/TOwKloYSwiY5V303I4+d+yc1W24lL9jn3wBkyfrLJbLUY YDur79Y46TS2EFhmo2vlfoLj6xymYKPu/KCHHXoLa41f3vt0jKAWrt39RY77hdKHgllx J5ev1oUx5ldpSpGebfh8RDccD1mCpjIqic+nkk0HeZtYmdBcpRdABE7tVBg/Xe0U5L2T 1oOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uhKImOe4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p64si77663pfa.94.2018.11.22.23.57.53; Thu, 22 Nov 2018 23:57:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uhKImOe4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393559AbeKWSk5 (ORCPT + 32 others); Fri, 23 Nov 2018 13:40:57 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:55964 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390083AbeKWSk5 (ORCPT ); Fri, 23 Nov 2018 13:40:57 -0500 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-08.nifty.com with ESMTP id wAN7vWj3021058; Fri, 23 Nov 2018 16:57:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com wAN7vWj3021058 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1542959853; bh=QiRqh8yetZM167uoY2zCS9SR1gaXHDJe1PX6A2FbUWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uhKImOe4cNfkV3//LxJArl7XFi6B2plvMt7ohzt3Wpmko4J19fQfzRL/gnI/qHEwO o2j2g6qDmTbfVo5AECwUFQvSeiZI91p2116q6ni15tfuXeORwVgPVk5cVB/koeiqYy GzKdVirsASaXzsCt0BtHqu/pQvTaB7dJ1zOvr5/u8z4V6H+KOlhD3NbwseTcZI5J29 hlaOGKNpfodnKryGTeS88R0VFKU7edCnZdV+BuGCovTdSD3sEGozyZkmBWv4IC1GON eMm4y8AYB3SfMfELIMIaVvF18N7NnA0GVy1urLT0lPLlip2W13xdz5/2uzjz4fB5Jn AsCpefVMgGWfQ== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Leonardo Bras , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] modpost: merge module iterations Date: Fri, 23 Nov 2018 16:57:22 +0900 Message-Id: <1542959843-16145-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> References: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Probably, this is just a matter of the order of error/warning messages. Merge the two for-loops. Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.7.4 diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 39432c2..05e41eb 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2484,12 +2484,6 @@ int main(int argc, char **argv) if (files_source) read_symbols_from_files(files_source); - for (mod = modules; mod; mod = mod->next) { - if (mod->skip) - continue; - check_exports(mod); - } - err = 0; for (mod = modules; mod; mod = mod->next) { @@ -2501,6 +2495,7 @@ int main(int argc, char **argv) buf.pos = 0; err |= check_modname_len(mod); + check_exports(mod); add_header(&buf, mod); add_intree_flag(&buf, !external_module); add_retpoline(&buf);