From patchwork Tue Oct 9 15:05:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 148503 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp5017367lji; Tue, 9 Oct 2018 08:05:58 -0700 (PDT) X-Google-Smtp-Source: ACcGV61Shxn2qgDaTmbFomLChuaIOqCGUTPJ74g/oXRbJEoRyCSk8AQ7MPg2M9EEccuyhB2an10l X-Received: by 2002:a63:1555:: with SMTP id 21-v6mr13003622pgv.383.1539097558663; Tue, 09 Oct 2018 08:05:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539097558; cv=none; d=google.com; s=arc-20160816; b=uogCbRX9tby8WM9qOU6mzkRjLxF/do5NU1VkLeDo3b13Z+J2jbl2r9UZkNI58KaFBx jQTxjV9oUf5wdr/52Zn9Q0nVjPvf9fgVHuN7tUGvvGbn636UsqcoHY4KtnB1TNgfm4NQ prolxe8zfpF0gSZq73S0scnhK8//NYzTMMptuonKsFzSe+F5YrdUi5ADdemUC5kE5AoF 2CQ1hW+H2cAFu905TXTMnltKu600DLp7CZ+xO0LHQq34vVGZSWhWsYbNZQpXbhhxOgV4 lX4sFEP3n3VEmoOVE6TGXfhcPGVdDCognz1v7Qz3od1ufNG37eqJ4LpU+6pru2WnljNx APZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=cKq9pBsUaG08Aurz84EMNuwZ5UKcOcz3K/IVYI+bKjk=; b=xO+gd+eXYBIN5pL0c3bocn4RVCU+qg8YsSk6PoHfbewJwupAj+EKPCgBIHp4vEuuzT sZSDVfkeR9VvUSmcW1V6GEt50q95mXwHFcil6Ob/5qa7vJtjGphwjxu1zkKlnqHz9gW9 o1S3fMk79N8bQJ06Jih1c1brEEFUuPXmNf8J6pwV6S8IunNB1ABoopxIFh1C5AeAP1Zs L+59MKzPlJJAxqz8LuQrPJapd1pKvK1+0XJV/u5Pd9BXiRP9w0QokQzPhSGHtSXEn9MY 0d6q76FGfx+S0H9NTKkULefLKFwBWdmZUl/2sR68VknVvvxgseneM/DuPCOIjcfzM7Ti DtCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="BOLhU9/w"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4-v6si20863731plr.51.2018.10.09.08.05.57; Tue, 09 Oct 2018 08:05:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="BOLhU9/w"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbeJIWXR (ORCPT + 32 others); Tue, 9 Oct 2018 18:23:17 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:38211 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbeJIWXR (ORCPT ); Tue, 9 Oct 2018 18:23:17 -0400 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-10.nifty.com with ESMTP id w99F5fpm002181; Wed, 10 Oct 2018 00:05:42 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w99F5fpm002181 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1539097542; bh=cKq9pBsUaG08Aurz84EMNuwZ5UKcOcz3K/IVYI+bKjk=; h=From:To:Cc:Subject:Date:From; b=BOLhU9/w+47SvgYdtJhr2zVqKQKCT9YjIfFxz7sRA4nFqrV00kmL1iV/yYqYDoIyw t4FDaQcZchX4sAhAS3Z/7Va6HyDNmLE7IcgK9EmYZ9+kZH3w2tDTbrkjH+nBbT0WdU sJjsNExAycCDTUgH35c/5/00KowOVHVQ85T95thGEBvJ7ajhMRAT/kU8x689GyfAAM cyOGuVtM7FRNHZeq3cjOEI6AiLEtxsM+V/8XRn+FhxX5JWrN+XmVigRgFQLl5FjtFZ FYt/Dws3nQkjWOtsxfkDrII8Obd0muCIWCwWIYaN6XoRj0CoTOjGg+Klx3wFGo37Pg 23w4rH0TyPgWw== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: use 'else ifeq' for checksrc to improve readability Date: Wed, 10 Oct 2018 00:05:39 +0900 Message-Id: <1539097539-26985-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'ifeq ... else ifeq ... endif' notation is supported by GNU Make 3.81 or later, which is the requirement for building the kernel since commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81"). Use it to improve the readability. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/scripts/Makefile.build b/scripts/Makefile.build index f21b48d..7d884d8 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -73,14 +73,12 @@ __build: $(if $(KBUILD_BUILTIN),$(builtin-target) $(lib-target) $(extra-y)) \ @: # Linus' kernel sanity checking tool -ifneq ($(KBUILD_CHECKSRC),0) - ifeq ($(KBUILD_CHECKSRC),2) - quiet_cmd_force_checksrc = CHECK $< - cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; - else - quiet_cmd_checksrc = CHECK $< - cmd_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; - endif +ifeq ($(KBUILD_CHECKSRC),1) + quiet_cmd_checksrc = CHECK $< + cmd_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; +else ifeq ($(KBUILD_CHECKSRC),2) + quiet_cmd_force_checksrc = CHECK $< + cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< ; endif ifneq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)