From patchwork Tue Oct 2 07:26:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 147958 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp4827052lji; Tue, 2 Oct 2018 00:27:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV61W5CKdLSIM0ItsI2tdPWiCgVjU5AqCg/8TuZA94I+R0MRA6pNeix2Bap9ObuI0HfyyLXEE X-Received: by 2002:a17:902:622:: with SMTP id 31-v6mr15256415plg.43.1538465232087; Tue, 02 Oct 2018 00:27:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538465232; cv=none; d=google.com; s=arc-20160816; b=va43PedMUl5thnlb1XbC/tUcUyBJdKyTTruLQl9AQPzbBNgCuPORVeaHvmnJEKk320 vqf6ig3y5vYWFNyEF72K2DRvOPaM9QLeNqY2B0E2mcdww+YFgyzWQwsnxE/ePwgQSMYh sLmfxbw9pMAwMjSbLzH+ITc25FwIfRLm/++8ax8b45olwNPVTNWbotfGgqvkzFSel/+U 5ZacVeKw9TPH+k2CtfwNEk/sdM4Dt5tqSFDDgkY5aSv1xjFglSdlt1FVuQtx1jHRm57e z2aGCeFOdwPGdXsuSJKDGrZidwZQ7dZBrMdlrXocw29So6JyMJPOHYXyF+kmE9bNscgX CtpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=ZAZV7TSRGTTOn8i3VUsUuDTLiKlP22KY3CKFP4aWfqM=; b=uJGNOUr7GA2aLx5D4Vj2bC0afG+pKuuABhOIXrMhRL2WyMHJ3SLC4dlypc5bIwU3OX 404Lnsto+Xs0wsbRsMzIa9dllFSdw+hX3d5JJt+KQUwDruzI1Zjc9Yce1p9O/ezSqzkd upNKnBUPIFgNVw+885Lskkekuj1XfxzP3N3KCiUoPilH7tipUZyG9S50XHzBC1aAYd7P 3b7lvnJxlFyY4AGxwpuBcLhP0ilzzMO7WD0u+Q8l/0nruVwtu1t37t+Y/bWWGqsguh2H L2zgs2e5ugQoEAOkBd8ssC9dRNP9JU4WqenxPrjxa2T1s9wT/z5L4v78qZb9GpxOEgp8 b+ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NyVks4hp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y34-v6si2896489pgk.479.2018.10.02.00.27.11; Tue, 02 Oct 2018 00:27:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NyVks4hp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbeJBOJA (ORCPT + 32 others); Tue, 2 Oct 2018 10:09:00 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38501 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbeJBOIs (ORCPT ); Tue, 2 Oct 2018 10:08:48 -0400 Received: by mail-wm1-f67.google.com with SMTP id 193-v6so1082673wme.3 for ; Tue, 02 Oct 2018 00:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZAZV7TSRGTTOn8i3VUsUuDTLiKlP22KY3CKFP4aWfqM=; b=NyVks4hpZvec6NdAmePSWZoJpMdhY7iogqMQDB5GbmG0mCsW8lfAOI0te8QVi3w2kH 37bXm5D0BCQSh2s+RwnHte5n5eVfqwzLHi/klgLCNKneLuFDOlVGHbwvNy1sGT+pXiJW EXMpqhwT4A9g4F97ZO1hIFrrO3WzI07DCandc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZAZV7TSRGTTOn8i3VUsUuDTLiKlP22KY3CKFP4aWfqM=; b=uUTZNZrpO2Kavn/eaVSCxbOnnBcBahojdKrgy3iw2stTeel7f2YmP28pifYkWDrQLy MbWvRVU7tXpgF2s+jIiYStpYcUKOwyKs/0oCy4XX8SelcORVMycaLOoUy/J2iSoZZSNB HuE+9swwdCK3R2Az1R1EIorrgbD9MY15Iwg16h97F+gxf2BtmXbgspC8kcEJJhSauI7W DCYI9Un+XalEXRYM6Pfy3sAOWURVlyhC7/51XxFCSR2jDoehYzU8ap/t2spdThd0bw2u xJjxA+XFu5nEgdBe+nhb+nlcbsXFYzohij0IZMxo9Mvd4fW77QY3bbIZseLRwWAyetZV +sdA== X-Gm-Message-State: ABuFfogEkqCBT1SerpJxyocDrwl2v5KLlJ03QF0fF/FEJ5PznfiWi1wY lRcwsiYydrLaN3HXFb7BNyDoOA== X-Received: by 2002:a1c:c708:: with SMTP id x8-v6mr918489wmf.116.1538465217554; Tue, 02 Oct 2018 00:26:57 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:99b3:4272:8254:6430]) by smtp.gmail.com with ESMTPSA id t24-v6sm3550552wra.5.2018.10.02.00.26.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Oct 2018 00:26:56 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [RESEND PATCH 2/3] sched/fair: trigger asym_packing during idle load balance Date: Tue, 2 Oct 2018 09:26:38 +0200 Message-Id: <1538465199-20176-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1538465199-20176-1-git-send-email-vincent.guittot@linaro.org> References: <1538465199-20176-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0ed99ad2..00f2171 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8460,7 +8460,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but