From patchwork Tue Sep 18 08:45:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 146889 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp4760664ljw; Tue, 18 Sep 2018 01:46:36 -0700 (PDT) X-Google-Smtp-Source: ANB0VdayXnF9d7Wv2oGio857TZs+iHPh1ndOKYUqX1EYNb1jbircyKetK3NUkS/4Cx9+scouObzV X-Received: by 2002:a63:2d05:: with SMTP id t5-v6mr27003592pgt.403.1537260396426; Tue, 18 Sep 2018 01:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537260396; cv=none; d=google.com; s=arc-20160816; b=SoIFt99y+HTd4J213aZzau/l7TWWwaKbibUHrNZpYDFdL7sp2HVxKs494lMx5HxH+u zbQbZemOJ7IK+jOSNegdGxaz+Ic8fr7E3P8VHSjdfsYTJp7+e6Dm2zRO3/AGtBfSnsnE Q5ldmAQ21+4sPH0znkfxeESc028HHj+ZM7JNYzCrLZxm7ADibRieBGLkmdyE+YV3V+my AMqOI+gMXsuqZIEd4pcw7PvevB+R6LwTBIExT1siVk97SmM+ZbJPVvCrAE3RZwcBPbpP 7Vci43ioFuXiVUXQMTai0snIMwVOJ9MtB1TgoOfQ5HHawggEXxv3LbhQatqisMWJdgzG mWQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=tpqAk1tRE54kXw4Ec4Ttm2Zhd5ozu9gJ+O1B/hU+QsM=; b=zI8RqD5kF4MMCcJ2mOMEi1X9ek7wxXnQmP6W5ksyIUoqfqJpsq2A8g3XMoX1r683TV mGcAE66qlh2xW4lVrLVbHeZe+XCmQ5IWeRwqVKPJPUzLpMMH9SCQz3pYB3iY/6y4Ci+Z jThTUq8za8fJqdnoMxJo5H3xwojubVL9/TwNhK8VQfEJ7FeBvFcg9Go0JhW74KiSKxgV x9w2axLfLqKatNbcX1nofyB3ymrujGKZJvCkBH1SRJONb1HAEIZnDjFk29yX94qUMJH2 l+wpIe9XLgtdhjdIXPMERN/ZFKVW4Y5TSzpmNBnj83Dc8Ip8N6CPiUDzE07Zn4tRd3R3 ++7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=d1v74CtG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o137-v6si19939930pfg.362.2018.09.18.01.46.36; Tue, 18 Sep 2018 01:46:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=d1v74CtG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729549AbeIROR7 (ORCPT + 32 others); Tue, 18 Sep 2018 10:17:59 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:55700 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729238AbeIROR6 (ORCPT ); Tue, 18 Sep 2018 10:17:58 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id w8I8juLR029470; Tue, 18 Sep 2018 17:45:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w8I8juLR029470 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1537260358; bh=tpqAk1tRE54kXw4Ec4Ttm2Zhd5ozu9gJ+O1B/hU+QsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d1v74CtGFJeP8/UF4eD0/R2oSHnqUjcF4Pie6pqXlkd+Miklc21KED7QxDnLDbTfI P17FFsc/2b79Xah38ch6HKRfPlV69bOrl0x9g0a6CD4hvjjC+cKKIsZC3yffxMpLJz D1KU//qJXk8/X3mEDh8aasYKC9CEndZavCiU1HxgFbBKPFGh9/oBiPYIVVYPR1uIHL Ltm9kBsMwQON2KKOm5+qu0OgM4qgQY3gjwvsG7m9YsnLgXOZ0NdFAvQVJR20Uexd2n 7Nra9iWsCT97AhMyJJyJ9cfjUJzfJztVPJcKJ5NX4LjcfoqBrk8WFBV+HXFaBfd3e7 VwnfA/4sFZ75w== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] kbuild: remove user ID check in scripts/mkmakefile Date: Tue, 18 Sep 2018 17:45:52 +0900 Message-Id: <1537260354-30082-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1537260354-30082-1-git-send-email-yamada.masahiro@socionext.com> References: <1537260354-30082-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This line was added by commit fd5f0cd6b0ce ("kbuild: Do not overwrite makefile as anohter user"). Its commit description says the intention was to prevent $(objtree)/Makefile from being owned by root when e.g. running 'make install'. However, as commit 19514fc665ff ("arm, kbuild: make "make install" not depend on vmlinux") stated, installation targets must not modify the source tree in the first place. If they do, we are already screwed up. We must fix the root cause. Installation targets should just copy files verbatim, hence we never expect $(objtree)/Makefile is touched by root. The user ID check in scripts/mkmakefile is unneeded. Signed-off-by: Masahiro Yamada --- scripts/mkmakefile | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 diff --git a/scripts/mkmakefile b/scripts/mkmakefile index e2106444..2435428 100755 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -8,7 +8,6 @@ # $1 - Kernel src directory # $2 - Output directory -test ! -r $2/Makefile -o -O $2/Makefile || exit 0 # Only overwrite automatically generated Makefiles # (so we do not overwrite kernel Makefile) if test -e $2/Makefile && ! grep -q Automatically $2/Makefile