From patchwork Tue Aug 7 15:56:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 143591 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4668651ljj; Tue, 7 Aug 2018 08:56:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfvHkQfFJVdAmrCx4tyISY9zb7syEmhXvLMyAwABybhrWljCCIRuOpy2sCKjt5E/LMZ08vH X-Received: by 2002:a62:4808:: with SMTP id v8-v6mr22475803pfa.89.1533657401135; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533657401; cv=none; d=google.com; s=arc-20160816; b=HXd1LPel6aRSiy8RJEk9rYv6H8PLaD/En5Y/OC47mpoJ/HEF/rCx0hvYHA29cLcnOa F8/bMkFDq0vojkiQ0deypBlTiKIVYQoVNfUNG3FBOcygujuvlGdWxkWce5JMRHd+Q/X9 L++dQvFYPx2vw7H6yJu2DLhaXBoXqHpNbIUh0ROs9O/MAscqt623WdCUvqwZek+E5h2y +Fuo4naeu1mLji48q3s2yGrAcoft92wYXhp2hlnWoGcOXZXn6/rXJuw9/VCuXX/F7MgD DeHIO+eyUahKXOvqcTQiQyrN+dR08iKeYmSfHCMIroAdzZRpBftkaX9zCGjSJ64AqXto MVvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=fTCJJHBMNkUJJN3RgEd6oBgcwXlHnayaWgAjMiLpqTgC3tAS6Q32qR2TkMDDoTV4QI 74lqWz2/CFA++h03ox5fyFtPgONEqfR/pTVMZKQOYrqgcvaRaTJqG8WvmOmCAnatWIed R3uT96ZdyBFlwYbkhCHOHTHLnn6+TD/kszOVMuniuPjCEBBpsY3FcgPUKYCW+0nCH7DC jpwTcB40pm31MS7zaaxzlpF9uumr84u+dSJI86IwkhAqYyYyPEpF85+qGuqstOQ6OA8A RoYtv27slr7dy01thd1b3xbpB2IGr+OZT9QKdM6Q6nkt0L8t/VMcS8KAB2B8pVKrcBLQ tEpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G4Q2PFD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3-v6si1685020pga.298.2018.08.07.08.56.40; Tue, 07 Aug 2018 08:56:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G4Q2PFD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390067AbeHGSLe (ORCPT + 31 others); Tue, 7 Aug 2018 14:11:34 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37749 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbeHGSLd (ORCPT ); Tue, 7 Aug 2018 14:11:33 -0400 Received: by mail-wr1-f66.google.com with SMTP id u12-v6so16267505wrr.4 for ; Tue, 07 Aug 2018 08:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=G4Q2PFD8DmvwEUMVS0nuzVo+S2aU3kQZKcbUAMd6wzw7UkIj7GM9rpuDLe/AxwuEC4 vxj3iiC9ZEBKwjnzNvDwE6ZUo4guIdrAPfA93dcyGXf3MOTHrvNVIVC/xxzBjC009wK3 BJdVfUqt3Ibo3WItw0+8hi9dbcEUQJ4D2jp7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Oi6O5vuULRS3qk8TZ9FMdKH2yubJ0L/xr/jup60upw4=; b=D75ZQeHbZKPP/BCEtr4wPJbieySVh0rBXWiFQ9NWNZ1TYCJGc4Fn2u8onoLGYbwe+L Vpw/NdsGMk4KAA0wh+E4az7qw036/p8BSFpQqeb7Mv4NH7VYHxGxRxYNWMUDUBXXsvGg vUk0NHdMniqZ51flj3J0uOprONiIWMp5thAhpqsXe8J77Y735i1ZEXYOdaK7OkrUVaqF kSERCkyQdr7W1pA+CvvBOS9Hj0GqRUqGfCp5xPcN/NT3Dx6Vwwyy7/nBQlrUlFHOcFnG jFFvsHDBm58gwiZPBIe5Wq8AOuqyqWiYjGuhgRBRLtJXuctE0wtW+xTAvlWIPGl2/1c4 zZ2w== X-Gm-Message-State: AOUpUlFK4TBqLw/zDUOpHjspWqvxfBp+wpoLw2Qkht5WnZvPznd7HPTY XbwJAcYHMH1P9oWuZbwxWU8TFw== X-Received: by 2002:adf:bbd4:: with SMTP id z20-v6mr13463970wrg.183.1533657395823; Tue, 07 Aug 2018 08:56:35 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:41ad:95bb:4cb8:621f]) by smtp.gmail.com with ESMTPSA id y203-v6sm2903644wmd.1.2018.08.07.08.56.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Aug 2018 08:56:34 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH 2/3] sched/fair: trigger asym_packing during idle load balance Date: Tue, 7 Aug 2018 17:56:26 +0200 Message-Id: <1533657387-29039-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> References: <1533657387-29039-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c376cd0..5f1b6c6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8364,7 +8364,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but