From patchwork Wed Jul 25 16:38:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todor Tomov X-Patchwork-Id: 142902 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1031808ljj; Wed, 25 Jul 2018 09:42:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfEyAWC2sKU6VcSaclqd1dhTm9Elm6jAFNJ2+MEm1fg+Zp0dUNMALiUN6/A4eGs4EpytFfh X-Received: by 2002:a17:902:9687:: with SMTP id n7-v6mr21183232plp.33.1532536959510; Wed, 25 Jul 2018 09:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532536959; cv=none; d=google.com; s=arc-20160816; b=wHdPr4vtp2lb2S1SpArMAYw6zB9QC67KbxIBc6bCpTBcxkMUpBPoeY6Ph6kkLBXAjg mCxW0rUcvK9TeHylRHxtg2JzFytcS8H6SLMBDDyYiJPbsi5HaD7RMQozbUjHtyXGlZpl FoLO1tvu68Niodvm5ANb8JiH5c+37bi+/LOXMKlj/fOKaX2sZ1Umw62QlPNUXdURW5Oz Jw7WyHR6MPvOjNUDIiJCSKHyuebmaAExNLOk5d7eN1EiM9bhRbnEwrLSsD8QaPYw6Wlm cnwtIFzz0gq9CAklFqAYU4/eogKdPm3aTagnyVGSDrvIGxB8q0qEn4lD5tsqd/DDb+/t aRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=c2j0Ar+sGRnQhZ84qnrq+W6V1tYFnJXzqZAsdrhPFQc=; b=k7FHyClPbHDhTBGtIbC7MJIdB1OqxvWgY5HJFGqshDZGtWmRo9nQNruOZMxgqImUZR Bd2XNV2K5SgK43UQwKlFJEtz9K88Dmu4E0qumBGgnlIeGAnLTfLeXAay8kcy1xBzYbr6 hONwPEdHulC/Dmi2JzEisA/BzEYxQsAItjparEiNHACN6cZ7DpmvB1pKK4+dK6XRsYGQ 00RABcSDFs0QDBq1TT84EbFXc4NQdEWqNWpIO/aj7/1XHRo3woX5wmvnDbEAt7atW71Q gG27dWiFugoEAah41dfuxRIrLq/msu7u1gqYAbh4zbWoOJx0Y5yq+yUikcOeNBd53g0m WsXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15-v6si14331085pfj.329.2018.07.25.09.42.39; Wed, 25 Jul 2018 09:42:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731476AbeGYRzF (ORCPT + 31 others); Wed, 25 Jul 2018 13:55:05 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:35576 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbeGYRvX (ORCPT ); Wed, 25 Jul 2018 13:51:23 -0400 Received: from mms-0439.qualcomm.mm-sol.com (unknown [37.157.136.206]) by extserv.mm-sol.com (Postfix) with ESMTPSA id DA403CD58; Wed, 25 Jul 2018 19:38:53 +0300 (EEST) From: Todor Tomov To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, laurent.pinchart+renesas@ideasonboard.com, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Todor Tomov Subject: [PATCH v4 06/34] media: camss: Fix OF node usage Date: Wed, 25 Jul 2018 19:38:15 +0300 Message-Id: <1532536723-19062-7-git-send-email-todor.tomov@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1532536723-19062-1-git-send-email-todor.tomov@linaro.org> References: <1532536723-19062-1-git-send-email-todor.tomov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_graph_get_next_endpoint increases the refcount of the returned node and decreases the refcount of the passed node. Take this into account and use of_node_put properly. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 45285eb..abf6184 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -296,6 +296,7 @@ static int camss_of_parse_ports(struct device *dev, if (of_device_is_available(node)) notifier->num_subdevs++; + of_node_put(node); size = sizeof(*notifier->subdevs) * notifier->num_subdevs; notifier->subdevs = devm_kzalloc(dev, size, GFP_KERNEL); if (!notifier->subdevs) { @@ -326,16 +327,16 @@ static int camss_of_parse_ports(struct device *dev, } remote = of_graph_get_remote_port_parent(node); - of_node_put(node); - if (!remote) { dev_err(dev, "Cannot get remote parent\n"); + of_node_put(node); return -EINVAL; } csd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE; csd->asd.match.fwnode = of_fwnode_handle(remote); } + of_node_put(node); return notifier->num_subdevs; }