From patchwork Wed Jul 25 16:38:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todor Tomov X-Patchwork-Id: 142896 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1031202ljj; Wed, 25 Jul 2018 09:41:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeYO8vyNNg1FbjVUlkxhB02fLh/BKAK146teR7c6W23k/7kF+es3wywNhlxGDo6u/I13m4k X-Received: by 2002:a17:902:8486:: with SMTP id c6-v6mr21477617plo.283.1532536918776; Wed, 25 Jul 2018 09:41:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532536918; cv=none; d=google.com; s=arc-20160816; b=RTaZCJbX2AN67a5UFyiOjZgKFzK7ASOYAPgu9LneiOK95qUvbRgB5LwXgKcnQ4rB7j Tb4SsKKBeFh1H0RDqyDDSJJsFXsk2epIuUr4Ru3fI8tlARXE5+2brmlXoAoT3iGYLHi4 W/sJwNMXVP2yBEwZm0RfY+4Nfb+UtgO9Har3RmPYRG52sMiSKjr2UMyAh+4o2LQHmor7 cZ//Mi5j8oG3hR1kGONLpJiFIftir5E7f2vU4AhizE/CEgp13IVDcRHKNmGCkmXZWdiS sN0P3iZiVcrxwqdoHN48lnpd0dUsYoslTJ/nWrn05d6+YGDOkg/6oiqUiZc8L+Dq3e5y eXxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Nr9dJpx3chH7JY3AApnp5bnByld35KnqRxHxOVzXHxk=; b=V+SqxVvxfTE6aU3f+4XO94X4dlNarm0upJnNohOKXGjs/myYQIc2/TbAHu2hPMtK4D VcuaoqJrGZYpuZp2cA+TYgo2Cxax2o7MrGhaWpuJdSQAJs2ibRAk4yp5/8/HqC7tAJ/e ldk5m9H6xzuKYEg6rbquSD4qd62rFy5E2hYrPrSc5n94tiDEDbXkBHf71x1z/xwSWQlQ AFO7ZiuBc/0BZu/N6LoTZwRVREjTPZaWxzfLOUhPVNLT37TU2kwEBQr+x35CsWcFWBku 3cdQICtr2SuUSFrHzbr5iyJ9ZKiOx8KqnIr0Uksex1Ek0PxmjajsYokoRKkJt3F9CVjV iuQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10-v6si13893953pln.349.2018.07.25.09.41.58; Wed, 25 Jul 2018 09:41:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731340AbeGYRyY (ORCPT + 31 others); Wed, 25 Jul 2018 13:54:24 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:35606 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729819AbeGYRvZ (ORCPT ); Wed, 25 Jul 2018 13:51:25 -0400 Received: from mms-0439.qualcomm.mm-sol.com (unknown [37.157.136.206]) by extserv.mm-sol.com (Postfix) with ESMTPSA id 27120CD60; Wed, 25 Jul 2018 19:38:54 +0300 (EEST) From: Todor Tomov To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, laurent.pinchart+renesas@ideasonboard.com, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Todor Tomov Subject: [PATCH v4 14/34] media: camss: vfe: Do not disable CAMIF when clearing its status Date: Wed, 25 Jul 2018 19:38:23 +0300 Message-Id: <1532536723-19062-15-git-send-email-todor.tomov@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1532536723-19062-1-git-send-email-todor.tomov@linaro.org> References: <1532536723-19062-1-git-send-email-todor.tomov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use "no change" value when clearing CAMIF status and make sure this is done before configuring the new command. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 77167f1..15a1a01 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -156,6 +156,7 @@ #define VFE_0_CAMIF_CMD 0x2f4 #define VFE_0_CAMIF_CMD_DISABLE_FRAME_BOUNDARY 0 #define VFE_0_CAMIF_CMD_ENABLE_FRAME_BOUNDARY 1 +#define VFE_0_CAMIF_CMD_NO_CHANGE 3 #define VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS (1 << 2) #define VFE_0_CAMIF_CFG 0x2f8 #define VFE_0_CAMIF_CFG_VFE_OUTPUT_EN (1 << 6) @@ -1021,8 +1022,10 @@ static void vfe_set_camif_cfg(struct vfe_device *vfe, struct vfe_line *line) static void vfe_set_camif_cmd(struct vfe_device *vfe, u32 cmd) { - writel_relaxed(VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS, + writel_relaxed(VFE_0_CAMIF_CMD_CLEAR_CAMIF_STATUS | + VFE_0_CAMIF_CMD_NO_CHANGE, vfe->base + VFE_0_CAMIF_CMD); + wmb(); writel_relaxed(cmd, vfe->base + VFE_0_CAMIF_CMD); }