From patchwork Fri Jul 20 07:46:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 142445 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2650490ljj; Fri, 20 Jul 2018 00:49:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf27xeqbFrtSzq+inu+9c3uXlR7sl6tPxlVHx3BQJnSJJKI5QyfPyH3ilP4c7Az69DeW10O X-Received: by 2002:a65:6109:: with SMTP id z9-v6mr1016641pgu.243.1532072944977; Fri, 20 Jul 2018 00:49:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532072944; cv=none; d=google.com; s=arc-20160816; b=QiEsL59UFhNyjSNtaSblxT6ItgfwJ4BTNV2s9JaUlwSdPtKQ8vGe7TCAj6q/dNOIYb dCAjMJqgXSjzotBOu9/aYhQtuPH87Lc7w4eXeLGdFxckN+TJO9lZzKcL882yIA3kDUSw u6y3+u2NXfu9UvZzY9Z26bcRqW0lvBLRErbFO4Ujy50X/kGK8CWokF2g1YZy4k5w/raX +h7e6HOmzejXxtBTZTZU8JCTy6B7I2DFFubzxnWDXcM9lghUne9t+AUuYyNP6gcg5iIY vyHzxNC0/EXH0lZKTlaW9F8gDaqelyWDFLRP/LJbLb1yvY/pYrxG0KDm6o4RYrO5UHpT U1kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=96arycp4z8LOgD9Xj6LUTt+Z6oY7DhyU5UyNBMuQ0w0=; b=zHHtk/uRQDygGdImcgMWP6XkZsWEl6+aiMmhUwXvH0SJE+KYJY8F+nXLhR4L2GTScO feOjEF8Lj91I2SEExUF1zISXeYPqxU6glRK8eVC9if39db1daJkxlLDP+9Yyj0UBwkzq Z5tFJQpytdGLHfbQ0I0Bm6c/qdMrVwAXqtq6WWzmnz/JaguDp76+NChw2fRVGTDYJilG VC/4I2pWz+RasGFrUXUupnucJOmTUhCpzNEGcBuP/bxN37bV8bwxhXfyU7rmjYSYWRWj JvEMC3zGCj09ZNd/x2QdYBeQTCIplTt+x7i85FJ6lRS6b/Tit5s6Jx08JiOMRiZ7ne/W UyUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=1srvT4mZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a18-v6si1366583pfc.106.2018.07.20.00.49.04; Fri, 20 Jul 2018 00:49:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=1srvT4mZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727562AbeGTIe7 (ORCPT + 31 others); Fri, 20 Jul 2018 04:34:59 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:28450 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727222AbeGTIe6 (ORCPT ); Fri, 20 Jul 2018 04:34:58 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id w6K7kdix008048; Fri, 20 Jul 2018 16:46:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w6K7kdix008048 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1532072804; bh=96arycp4z8LOgD9Xj6LUTt+Z6oY7DhyU5UyNBMuQ0w0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1srvT4mZkHbAn2ue+MaX0Ocz4P4BnmHNtrG8Y8UkCWfQCdbLPP/j0JiA+wENfnsON BzVhGAJY98pcw2l9RBVpvNJD2lgQBSaBqsGC3OdlCtpjq0X+J/CeLvLrjV2+6HvhSa C38N9YBRD+cbKmFKtJsTh6ZuPbmx6Z7LLT4xo58717WOMf1PtZdB/vxTlehqe0Upya 3r42jGvgUONf3AayBLT8uBlrxRpxmLIj1Qh0X4qEja7AP3kcgSCzNeEyMHEyQ2icKw zHrNXuvscVwbNmv5Cy4XPkSZ37/jwbfrUKL5hZhfnqdkFxOJiZgXJv7NpY4MgtbCDI 2CvhGlQAlQrGQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Dirk Gouders , Ulf Magnusson , Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile Date: Fri, 20 Jul 2018 16:46:32 +0900 Message-Id: <1532072796-7947-8-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1532072796-7947-1-git-send-email-yamada.masahiro@socionext.com> References: <1532072796-7947-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external module building, the following error message is displayed: ERROR: Kernel configuration is invalid. include/generated/autoconf.h or include/config/auto.conf are missing. Run 'make oldconfig && make prepare' on kernel src to fix it. However, Make still continues building; /bin/false let the creation of 'include/config/auto.config' fail, but Make can ignore the error since it is included by the '-include' directive. I guess the reason of using '-include' directive was to suppress the warning when you build the kernel from a pristine source tree: Makefile:605: include/config/auto.conf: No such file or directory The previous commit made sure include/config/auto.conf exists after the 'make *config' stage. Now, we can use the 'include' directive without showing the warning. Signed-off-by: Masahiro Yamada --- Changes in v4: None Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/Makefile b/Makefile index 5c8e9a3..2fa9830 100644 --- a/Makefile +++ b/Makefile @@ -585,7 +585,7 @@ virt-y := virt/ endif # KBUILD_EXTMOD ifeq ($(dot-config),1) --include include/config/auto.conf +include include/config/auto.conf endif # The all: target is the default when no target is given on the