From patchwork Thu Jul 5 02:39:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 141093 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1409431ljj; Wed, 4 Jul 2018 19:41:50 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfzIRhcD0U1CY1F/MjEUCAu//RUv5cj7r1KNJNSnosd+nbF3oy/0ewIicO93BimMtGH6Oja X-Received: by 2002:a17:902:48c8:: with SMTP id u8-v6mr4293823plh.152.1530758510107; Wed, 04 Jul 2018 19:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530758510; cv=none; d=google.com; s=arc-20160816; b=H4mO+N2auRXfYbob+8LZEsMusdQS1mLhLCCLkbyIxxR9A6ipDFN3506MJwl1XfaVtt HDAeUl+k1MrR3rPrLMQfJaBh9R8say7AUKdNftfz4tOkgNulcsq4R5MBb8h71HhskdKW gSIhJlyujNn2jNhmOvaS0FDq1vUJw9y4HhuHNyh4+LXF1t9sMmLeY/LEb/BamlxvXAcT yPJNNM3moSiYfl32x/VB85CkiS19lnQlG7+k7f5aqkpuoC2Q4hot2IoNIkeyXqsrjHgx 47I3/A/PXOvQKBrvcgkomzeYS/OTMcr5MrsRB/7aEodMLLwXBdlw2maPQ3WTsfu7mMHN mPPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=PeVnUtgNC8gbPFeql5sex6hHkYn8Hq42VaeMvYoJ94Q=; b=kfLktBbx35g5N5qhL6BvVUSrBKCvR2prTi55f+54D4M9mYEM2FHQTCbJZZd6HtTDM5 /Sl7GjmoFCfza+xr/tquAaaYb98RFBdhnHPzknpsBW7Po5vLZIUB8Z4zVpb/g+r3mj2T PlRR9k2eIYAmU0Jl7h8xkEJ7UZnarXUJM6LWAH+9Y/bOV2goff6USN4BGozWf9+jCmM3 /HOqFn5cqnSwBVa7BcRa206l6YuBkv3TpSVdCbXmx9wnPXgYDm7HnKe3B5Fb9oU4VT/J JDxcWEN80hhl/VWiHPH9MUU0kZfukPYZA4Mw3lkXntsW0Fa1XQqIbjbjB+8PaNw1ukSw 83QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uxE+PwbT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12-v6si5123067pfk.156.2018.07.04.19.41.49; Wed, 04 Jul 2018 19:41:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uxE+PwbT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbeGEClq (ORCPT + 31 others); Wed, 4 Jul 2018 22:41:46 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:44119 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753372AbeGECln (ORCPT ); Wed, 4 Jul 2018 22:41:43 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id w652duZd028145; Thu, 5 Jul 2018 11:40:02 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w652duZd028145 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1530758402; bh=PeVnUtgNC8gbPFeql5sex6hHkYn8Hq42VaeMvYoJ94Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uxE+PwbTMNq/fcoT4cHNahcP2vjXwhW5fG1p5QfCWBdzwFuY9Wf4u3A822hAZmAuF Lh8eqCKCmH4vlmcQDDxW2H8xJsCTm7x4TcFlWR8KXTsH55cx0pB0fLx5sja0u1xdlF a0pJXzE7Z8EB50snqw2jx6kPdCoxYJhRAwtHSLGN9UVOSWYL8kBvRxXep6xiNnsbIY Ct0KRi9Qo2NuD0kvDYunNJxYJoxgsJL06eOXRk/PX9crBJ/rqyjK8gmtNRtBB2w63H 3rme4QOti3cuZd/PMfvzobCbf5mCST+0AiTLD/WNNYWIl4mzCTh4yXcaJSmlq16AZB leAOS+b1bHZ7Q== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Dirk Gouders , Ulf Magnusson , Linus Torvalds , Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v3 07/12] kbuild: use 'include' directive to load auto.conf from top Makefile Date: Thu, 5 Jul 2018 11:39:44 +0900 Message-Id: <1530758389-30862-8-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530758389-30862-1-git-send-email-yamada.masahiro@socionext.com> References: <1530758389-30862-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external module building, the following error message is displayed: ERROR: Kernel configuration is invalid. include/generated/autoconf.h or include/config/auto.conf are missing. Run 'make oldconfig && make prepare' on kernel src to fix it. However, Make still continues building; /bin/false let the creation of 'include/config/auto.config' fail, but Make can ignore the error since it is included by the '-include' directive. I guess the reason of using '-include' directive was to suppress the warning when you build the kernel from a pristine source tree: Makefile:605: include/config/auto.conf: No such file or directory The previous commit made sure include/config/auto.conf exists after the 'make *config' stage. Now, we can use the 'include' directive without showing the warning. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/Makefile b/Makefile index d15ac32..ef24068 100644 --- a/Makefile +++ b/Makefile @@ -584,7 +584,7 @@ virt-y := virt/ endif # KBUILD_EXTMOD ifeq ($(dot-config),1) --include include/config/auto.conf +include include/config/auto.conf endif # The all: target is the default when no target is given on the