From patchwork Thu May 17 06:16:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 136089 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1877432lji; Wed, 16 May 2018 23:19:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqqUtv4eBZNmGn26IbAXLp0kDfEdPsTkXDoq/6oB7BPP9AfPdgtAYzNgfovxru+ycdddARG X-Received: by 2002:a17:902:b184:: with SMTP id s4-v6mr3850281plr.359.1526537962908; Wed, 16 May 2018 23:19:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526537962; cv=none; d=google.com; s=arc-20160816; b=HW23opiodZVz6ViJv0CkNRUjoOgtofDcoITZNEleRMOjuiMhLcRxCBSaRW9ptvbf51 WGikvNZI1PIR/5Jw7d899SgGOHJw3xh8PI/FQZyDIQ2Wz6R5TbGpdPRYmYo3MdtZPFOg iRwbxVHVOsSbCdbSg14JdN1lKtk/bfROwNla9r+z2PcjyGzRyjUHKTIADey4d6VQhXae vY4Qe6PFEhdVUvUB97Tmn2Ib3WDIKRvvBOuFGQ9Eb1GrqFY1E4M4BTVfEu3xWppTXwBq 3qAVB8FFxU6WwB+q+3qiUuxtQpG5GWtpnnUaJZmsH0MIwOjrnFbVfmEPhUVIDmuVMY54 tolw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=d7ZznbAHzAPLPzbAa1AFz4lYEkTkrvR+7XrpYn4RaN0=; b=X2jWrFPmud6+me8umL4rWn5qSfPCLclzlQ6znlg1tUtQYg5v1gde/YUOnAVy1oY+n8 iieF9CYkM03bzw8LzpeXO7gdrHGWbZ7jJyIIi5sdbBn32sGGh/xhx21AZzau7zxgkR3O MX4brBSNs/hIIjpRBCgbR1p42oQU8GY9RgelAlccMdkfdO1b0YyKuuFE7AV/Yp/Bv59X BN3f0zl907xQBDFjoGxlCzRc6WyYq0QiICkzTXT7ba48wQBj80DJiakvpbYWYNfHVXiW QeT1WhqO2xkSNVQnKQ7ypuUnFeV5i9okLkYPXvrT/WETuNaUQitY7ogPpUJQsNGi9RQ9 K0qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=26Uk5R3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f28-v6si4952932plj.255.2018.05.16.23.19.22; Wed, 16 May 2018 23:19:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=26Uk5R3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752205AbeEQGTU (ORCPT + 29 others); Thu, 17 May 2018 02:19:20 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:24994 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbeEQGTQ (ORCPT ); Thu, 17 May 2018 02:19:16 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id w4H6HbUG002841; Thu, 17 May 2018 15:17:56 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w4H6HbUG002841 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1526537876; bh=d7ZznbAHzAPLPzbAa1AFz4lYEkTkrvR+7XrpYn4RaN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=26Uk5R3RU3i0LczZaoWgBjpC0lNAyl8pdXK+W/K76Mqq583ndnUnO5yMjEkf5lqbO U9wDNT1UOJRs7C2k2gQPCtUMQ9QgKapRue/W0L9e92sxxDVfCC6+BqeP+KFc3Jg43e Y+qNoyBiRSzfW71TqVLXvVhc1OcVaEIgVYzQ1NjSm/qPv66KeaNbMVSOK5p1MSaUvH r+6WjgAnlNXGY+uauiArJ2idyw60/wmG24RS8s3UtlEhiVpeGwme8zmQsDDiRCxiRi EQAPuw9oPaDMpt3hOFkZ1jIjLPokX3lqrRPftJn3kb7MtXuE12q1xdgp1RnOkxx1oH WLjN/yf/Q+cnw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Linus Torvalds , Sam Ravnborg , Ulf Magnusson , "Luis R . Rodriguez" , linux-kernel@vger.kernel.org, Nicholas Piggin , Kees Cook , Emese Revfy , x86@kernel.org, Masahiro Yamada Subject: [PATCH v4 18/31] kconfig: error out if a recursive variable references itself Date: Thu, 17 May 2018 15:16:57 +0900 Message-Id: <1526537830-22606-19-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526537830-22606-1-git-send-email-yamada.masahiro@socionext.com> References: <1526537830-22606-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using a recursively expanded variable, it is a common mistake to make circular reference. For example, Make terminates the following code: X = $(X) Y := $(X) Let's detect the circular expansion in Kconfig, too. On the other hand, a function that recurses itself is a commonly-used programming technique. So, Make does not check recursion in the reference with 'call'. For example, the following code continues running eternally: X = $(call X) Y := $(X) Kconfig allows circular expansion if one or more arguments are given, but terminates when the same function is recursively invoked 1000 times, assuming it is a programming mistake. Signed-off-by: Masahiro Yamada --- Changes in v4: - Newly added Changes in v3: None Changes in v2: None scripts/kconfig/preprocess.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.7.4 diff --git a/scripts/kconfig/preprocess.c b/scripts/kconfig/preprocess.c index c39e30e..246f879 100644 --- a/scripts/kconfig/preprocess.c +++ b/scripts/kconfig/preprocess.c @@ -276,6 +276,7 @@ struct variable { char *name; char *value; enum variable_flavor flavor; + int exp_count; struct list_head node; }; @@ -306,8 +307,19 @@ static char *variable_expand(const char *name, int argc, char *argv[], expanded_argv[i] = expand_string_with_args(argv[i], old_argc, old_argv); + if (argc == 0 && v->exp_count) + pperror("Recursive variable '%s' references itself (eventually)", + name); + + if (v->exp_count > 1000) + pperror("Too deep recursive expansion"); + + v->exp_count++; + res = expand_string_with_args(v->value, argc, expanded_argv); + v->exp_count--; + for (i = 0; i < argc; i++) free(expanded_argv[i]); @@ -337,6 +349,7 @@ void variable_add(const char *name, const char *value, v = xmalloc(sizeof(*v)); v->name = xstrdup(name); + v->exp_count = 0; list_add_tail(&v->node, &variable_list); }