From patchwork Mon Apr 16 14:47:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 133469 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp3653407ljb; Mon, 16 Apr 2018 07:49:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/ZtiYC1hW5hyfPCGz5VpVWau0++0fLzEfVD8+nCnmtpup2bfdVjkWINS0lEBsoyGroBKCq X-Received: by 10.99.9.66 with SMTP id 63mr11217531pgj.103.1523890169839; Mon, 16 Apr 2018 07:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523890169; cv=none; d=google.com; s=arc-20160816; b=VL0QBPN2hEsVCz+UUN51dK/sFpRZ6sqiJ4KU9/LBUr5vWTngiN7dcSlfRDpqtIVq0T 8sZu2DDCcTlShHY9jH5zCYSf751ofWuKsPHxgYVoar2r3vh8CZHcXAeDMW7+ZC3xXuYd VSIeJR+tGatCaASxRU5W2e7UN+nay7unKQ/KyUIXvK9D7omC59UY2YZ+D3U623W+Ix3b qm5/9nUFr0M1BOZ7XmwqWZbtazgMYepfDfxjZF9tsmETNUtUVi9FDf+5kYhpy4OxyYes RocOPKHZYOy1jBrjGcNZ/MFBb8VZH3Q8Dmc99wkrzWcF2Qs9zfQ9SrGCe4PY/szh0xGP D4Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=A1Gn6EVXs/augMnXta7rJ5tKBPekzAV8iaSCKb3cg08=; b=fh+aX91ODUhdwUGdXh9q7l8+ntTjXr68YHHXzKcB1bl3WQECjbKXXqkHA49NuDgu4X JefQpWgA9qMSppk+k08xIlvhdqya09jZYAehU2DzSjVIqDhE4bRTyBmf7ExoGjdGebvh ZSngD7o4nzTydJfGFIFjWP3z3hUcLg6qsol+xXbHRNexqz/q+6r0TQj8wKR5pBQtKcg2 I1v2/XS+jtSkSH7vuDYWVwRUEkqUizSvsy5IMyIs6gKFE+gAknFibWP+R0JpU4ckaUQv SYyG/sMFIBALFbsp0W6wCeR2c+B7eOCtASsHJgSsoetz7cgRSgLsrPtDG+TfdOa1dwWo Yq/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=MdU+HiMl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t73si11034425pfg.114.2018.04.16.07.49.29; Mon, 16 Apr 2018 07:49:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=MdU+HiMl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbeDPOtJ (ORCPT + 29 others); Mon, 16 Apr 2018 10:49:09 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:62390 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752866AbeDPOtF (ORCPT ); Mon, 16 Apr 2018 10:49:05 -0400 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-10.nifty.com with ESMTP id w3GElqtr017749; Mon, 16 Apr 2018 23:47:55 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w3GElqtr017749 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1523890076; bh=A1Gn6EVXs/augMnXta7rJ5tKBPekzAV8iaSCKb3cg08=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MdU+HiMlCj6q23aOrwjSN5m83qSRsbVxxa2eTPxmgafncUeyJtsC8vcLtXgN6ro8J GpRrMKZHuPMlngUwBoBkOuVeMwST5lnrUYtz4mltYq24297N6wxyvcHBLVm4mMV/Yn 6Wmn9K3XMcUz6KqXrxcRGM9u+Yvm/MQgvFhm/ulMNeiq53xmtppOZeHILMwZGbmbdD bPijsj76/PhmIrKzWGYTkFnrN5dd6PLZhtiTw5094FFh3zrUjFM9q/wDwvABs6DmGj m6/46Y3hlVFOJUbYNCe2+MG3I8d26iihrTl27wdpSiBvq4FN/eSjCK/xgUYd/OMOl1 saWDU9ah7XL3A== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: Ralf Baechle , James Hogan , linux-mips@linux-mips.org Cc: Paul Burton , Masahiro Yamada , Kees Cook , linux-kernel@vger.kernel.org Subject: [PATCH 3/7] MIPS: boot: fix build rule of vmlinux.its.S Date: Mon, 16 Apr 2018 23:47:43 +0900 Message-Id: <1523890067-13641-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523890067-13641-1-git-send-email-yamada.masahiro@socionext.com> References: <1523890067-13641-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Documentation/kbuild/makefile.txt says, it is a typical mistake to forget the FORCE prerequisite for the rule invoked by if_changed. Add the FORCE to the prerequisite, but it must be filtered-out from the files passed to the 'cat' command. Because this rule generates .vmlinux.its.S.cmd, vmlinux.its.S must be specified as targets so that the .cmd file is included. Signed-off-by: Masahiro Yamada --- arch/mips/boot/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/arch/mips/boot/Makefile b/arch/mips/boot/Makefile index 981bcf8..6c7054e 100644 --- a/arch/mips/boot/Makefile +++ b/arch/mips/boot/Makefile @@ -118,10 +118,12 @@ ifeq ($(ADDR_BITS),64) itb_addr_cells = 2 endif +targets += vmlinux.its.S + quiet_cmd_its_cat = CAT $@ - cmd_its_cat = cat $^ >$@ + cmd_its_cat = cat $(filter-out $(PHONY), $^) >$@ -$(obj)/vmlinux.its.S: $(addprefix $(srctree)/arch/mips/$(PLATFORM)/,$(ITS_INPUTS)) +$(obj)/vmlinux.its.S: $(addprefix $(srctree)/arch/mips/$(PLATFORM)/,$(ITS_INPUTS)) FORCE $(call if_changed,its_cat) quiet_cmd_cpp_its_S = ITS $@