From patchwork Fri Mar 23 16:05:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 132348 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp776860ljb; Fri, 23 Mar 2018 09:06:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELtkgPYaEAPmYeUu6VPc+breX+1/V1chPQIplTP/C840SUVjFqFlSQx6cF0qCudrJAD6c3ck X-Received: by 2002:a17:902:ab85:: with SMTP id f5-v6mr26041488plr.380.1521821175378; Fri, 23 Mar 2018 09:06:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521821175; cv=none; d=google.com; s=arc-20160816; b=d27j8jZ8aVRKd1M7BPIi08K33bBua3VNzcAHDTMHWqznNYs4LjaYwNF3R7GkRCYnHX QIEPahJbGGw7AILkAN8N52TawJwPK/ivpD6fcr5STIVuwQGiAhcgH1YbjSuxcCvjY5nD jKaT3aECUrc061o2rFZK19N0r3EkKrLzn9Fj3O2ASJwKFn4Y3GIrT4H5Kt/YOWGYPHKM qaXBJdHCwbTCBrhB4IpfXuEVtRA8xyumRU15Obaz1uM72ABcClQAZQ5ViuvELwQZk71j LOcVOZOW05DCNdLKfyrQjSOq5/O1wtxrsLVGhhNfrnprndh9i6crNvYFxu4aLn3xImZO 3K1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=ua9Qz88/v51c4vGKoDefNuU5/JwEI+5iRJ+aC+hd0ic=; b=ynHn4vcuE/IYtgCiAVFecsVMH0Kce5EhT8chWgjD0k4NhQ2WINULZ2DOOSdDw/0XYY YBYzsNoP2gKok0+cPjjQ8M/jxsr7DJIZeiDff9x897rzPheEc810lxq0jUbDCnOpMndw 5gdlLrG4GbDpBB8f3YpfE4E+wLeiraOeYa7Sq5cOkBvvM4J7FXwfzyAqXBbUh57iitLn QEmQ4tVz2BJunu1wOp2+QYfKrf9+BmS8rPB8gpjER1GG4fBRuxUufi3sOM7sXDb0xryh Uq1vsaqS1eI8IM3Rp+zl4g9Bg8gQIVDGyLCv36Y+xlxqaGsVH6qks6SqAAEnFHfc1fVb WHdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11-v6si9129030pli.599.2018.03.23.09.06.15; Fri, 23 Mar 2018 09:06:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752267AbeCWQGM (ORCPT + 28 others); Fri, 23 Mar 2018 12:06:12 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6687 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751811AbeCWQGK (ORCPT ); Fri, 23 Mar 2018 12:06:10 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C79BBE6513FAA; Sat, 24 Mar 2018 00:05:50 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.361.1; Sat, 24 Mar 2018 00:05:46 +0800 From: John Garry To: , CC: , , , John Garry Subject: [PATCH 7/8] scsi: hisi_sas: print device id for errors Date: Sat, 24 Mar 2018 00:05:14 +0800 Message-ID: <1521821115-120040-8-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521821115-120040-1-git-send-email-john.garry@huawei.com> References: <1521821115-120040-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When we find an erroneous slot completion, to help aid debugging add the device index to the current debug log. Signed-off-by: John Garry Reviewed-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 ++-- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c index bed6afb..a5abde8 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -2459,10 +2459,10 @@ static void slot_err_v2_hw(struct hisi_hba *hisi_hba, slot_err_v2_hw(hisi_hba, task, slot, 2); if (ts->stat != SAS_DATA_UNDERRUN) - dev_info(dev, "erroneous completion iptt=%d task=%p " + dev_info(dev, "erroneous completion iptt=%d task=%p dev id=%d " "CQ hdr: 0x%x 0x%x 0x%x 0x%x " "Error info: 0x%x 0x%x 0x%x 0x%x\n", - slot->idx, task, + slot->idx, task, sas_dev->device_id, complete_hdr->dw0, complete_hdr->dw1, complete_hdr->act, complete_hdr->dw3, error_info[0], error_info[1], diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index aa52d5e..760724a 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -1641,10 +1641,10 @@ static irqreturn_t fatal_axi_int_v3_hw(int irq_no, void *p) slot_err_v3_hw(hisi_hba, task, slot); if (ts->stat != SAS_DATA_UNDERRUN) - dev_info(dev, "erroneous completion iptt=%d task=%p " + dev_info(dev, "erroneous completion iptt=%d task=%p dev id=%d " "CQ hdr: 0x%x 0x%x 0x%x 0x%x " "Error info: 0x%x 0x%x 0x%x 0x%x\n", - slot->idx, task, + slot->idx, task, sas_dev->device_id, complete_hdr->dw0, complete_hdr->dw1, complete_hdr->act, complete_hdr->dw3, error_info[0], error_info[1],