From patchwork Fri Mar 16 07:37:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 131907 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp410673ljb; Fri, 16 Mar 2018 00:38:05 -0700 (PDT) X-Google-Smtp-Source: AG47ELugJZ2/jvgrp1CRYORZIRdkTOa7rX1buloMGoHEtdqQeI8Ex8E7icKxE55boctX9oJ0JUYb X-Received: by 10.101.86.138 with SMTP id v10mr677085pgs.353.1521185885275; Fri, 16 Mar 2018 00:38:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521185885; cv=none; d=google.com; s=arc-20160816; b=pFiz72YqqDyTYVcsTGhJBMWVu71kv2qW+0FTdnMfv2WqM2wI273uAVV5qRm3Ahv8+E fyzkdSvstSFPSidxMHqBZOZ9TqpeMILIaDsHFV3V9CqEQJh5jXkEP6peER8spPOsPcFV 5cEhIIIH1imi+GLWZxZlt+5/A2heVD+cUnLlBl45CkTYkEoDz3LYfD6co9eQCLp12r40 a+r1W5grPLRZxJS/ohzIVQkJhXpkbAYDQ947/zUVzioWiebtS2FfbFIj9w1w8bTe6rGF o9yMWRNiBHtekTxMbQ6gAXdWx+iF/a6GUSwUCUBWxRtOznjBJ10cEcSz/2yOOCo2Zpx6 1GNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=hhhDa6mfh8jXfnRUfhSOjXjk5xwYiE0cRBQ5+bl0C38=; b=e8jLNL/h6dSJ2qw6nIa+7O69l4y90rENSP6AGtb3nhGlxwcVaIuNscEjzu49KMO0up IU+roKgscoj6KsOE4Locc7TRg/iG1E+QhylGFn5STW5jHQ9xrIvxXxXScJ7f/SNezYSk jpM2ty9HH2TAuR8lyZEp2MI1rRR/BYazlebWoM7sgkb5kdBAs4+1aDVdogWLgjbPYTId NexC7Zpm5o3ZaGD0XLUGtH0nYdT24M/oAqpTQuwN1gEnuXWO2RKxraFUKJeUdAwxnRNH b+RO+UkWhLu+LVCZzSn66wmuTnOLjEA/tc9gOol5XbnYoPUtl1svzbS/wHw+AQ98TYsZ CHwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=GLdp3mTN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h70si572305pgc.656.2018.03.16.00.38.05; Fri, 16 Mar 2018 00:38:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=GLdp3mTN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbeCPHhu (ORCPT + 28 others); Fri, 16 Mar 2018 03:37:50 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:20645 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbeCPHhn (ORCPT ); Fri, 16 Mar 2018 03:37:43 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id w2G7bOa5029139; Fri, 16 Mar 2018 16:37:26 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w2G7bOa5029139 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1521185847; bh=hhhDa6mfh8jXfnRUfhSOjXjk5xwYiE0cRBQ5+bl0C38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GLdp3mTNLbYCirJhnE2uFiz/RUWVNnlgkgTJwl+qbEjWyqOaKs17JV05Dx5pnG7zv uBj+eoNgBtyBxwdrS5wgUznGnUd8BQ8cv5Oo7NLQTfsPnVqxZlawksnpo51A9W/67n rN0/ivo4YZDR6idkjuSnRIKvEPe3BaNnCZloMsyoX5MXGbgiT/IIhX4zpfML0gJgnM qGtvcHsj0eMmds/3+rP1+IpSyXNAeYsNyOkXTyXarcxmIBew2/LZt36W8ybgdpEXWg sFosmanVwrTsSQpf1hfd/CayeScMzFzPSdoE3nE/oihCT89E+hnxzn8xNCngTLaBNL JlUe/N02tZnOw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Michal Marek , Nicolas Pitre , linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH v4 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh Date: Fri, 16 Mar 2018 16:37:10 +0900 Message-Id: <1521185836-19120-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521185836-19120-1-git-send-email-yamada.masahiro@socionext.com> References: <1521185836-19120-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comment mentions it creates autoksyms.h in case it is missing, but the actual code touches it when it does exists. The build system creates it anyway because and need it. The code would not have worked as intended, and people have not noticed it. This is a proof that we can simply remove it. Signed-off-by: Masahiro Yamada Acked-by: Nicolas Pitre --- Changes in v4: None Changes in v3: None Changes in v2: - Remove the code instead of fixing it scripts/adjust_autoksyms.sh | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4 diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index a162258..e0dd0d5 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in . "./${KCONFIG_CONFIG}" esac -# In case it doesn't exist yet... -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi - # Generate a new ksym list file with symbols needed by the current # set of modules. cat > "$new_ksyms_file" << EOT