From patchwork Fri Mar 16 02:18:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 131890 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp179043ljb; Thu, 15 Mar 2018 19:19:59 -0700 (PDT) X-Google-Smtp-Source: AG47ELuDTJrRA1nt9H7mc7upVJnQQeFTegBQ0hIYrcLlFPMof6iBDTgkVNH7xOejQdYIu0F8wmX2 X-Received: by 2002:a17:902:96a:: with SMTP id 97-v6mr126225plm.183.1521166799299; Thu, 15 Mar 2018 19:19:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521166799; cv=none; d=google.com; s=arc-20160816; b=vw9L5sYgLEbmnz425W8lm1/okeHxYYazl4zkNZW83mTa4VJ0gKZoVkfnu4tHk+I7Y0 K0+v0tVLbVFND2i7yGQITzqGzAoPHqlLsIIYcnbslZ2DT3+iVw77F7s9t4dDmlSd97oY nSvLfQUiKKKIpvLQu0SNMLM4MqmYq16PTLpcp6NurCdW2McZK+eW4xRX/4080unIq3au SLuxp5ymI1/TCrHCkLwXUg+nFY7sEYCKULpSQAsbCi9Z052mjdHbvqLgGu0hZzHDWDKT fFQX1V6zCBmiDeFDhvQTRQL/orxrI9EuixWtwLuX/3A64sWuLgEC+UHGcHkxgN3M+Dbn UjOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=sJgJqRYxOaGQMoN1BJInx/LhYkj88bvy6//8VGGiKBA=; b=BmhF5/eOM2qfzxhgEzabemw50SWHuOoGUYlIHayxjbwN1DNvBySEWJsDSSi/eG3QUP I3+UR9+VRBahBsuiOo7KckKd/lP3jqjyV2TKhg7MPp9QvB8my+NeeRvbIdtfpDVyo5QI pH9Y8CU8LAvNe9/r78fxQ8deL8+cPQU0nL51+bRnzXGUtD6d+sWoR2r4PHR5na1Xtvsy uo9/vWc3TJAFCgeoHBGaCaQsm2NeZYLmnAToQLzh0VpS/wKFs87UXaicjj/IPuE6X4/i fLNPBNb/Gj8ffxPisC1OMXU0ZagHA4gva+/rXotMifi6+z+xkQPwdHjpn8Tp/DsTLmhz ljrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JmiJRYMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15si4267059pgv.676.2018.03.15.19.19.59; Thu, 15 Mar 2018 19:19:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JmiJRYMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932903AbeCPCT4 (ORCPT + 28 others); Thu, 15 Mar 2018 22:19:56 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:44540 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752857AbeCPCTM (ORCPT ); Thu, 15 Mar 2018 22:19:12 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id w2G2IoBN003525; Fri, 16 Mar 2018 11:18:52 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com w2G2IoBN003525 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1521166732; bh=sJgJqRYxOaGQMoN1BJInx/LhYkj88bvy6//8VGGiKBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmiJRYMmHeXz3rdQjaqddSN7445qPG5hlbk8Sv8wwt/s66n4/9kcif46tn/3rxZbt VkK27Fte+csyfRu7A8suh96cmBlB5nP33fHIIUdqMWC7HNtPSIS1rDLYXvANoavLUD RVrK+TXMj+k9ehqMN/y87AIcWLSAsK+xFhR8zF8oYTiFUEdYOZnuegUy9gsxhNk59s pSQZ56gghdrNznPnasT1nJSgz6+lNjbP6jI/hG5sKe36oBu0dYfgUfPr8WGyDHIQvr KT5kbSdyurFOxDRhAD7Yr3kcQDLYGLVIFncF5eUUXsB6Y7JkjP+EC3C4DuIDwS+OAC WdF+acqLWdilQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Nicolas Pitre , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh Date: Fri, 16 Mar 2018 11:18:39 +0900 Message-Id: <1521166725-24157-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521166725-24157-1-git-send-email-yamada.masahiro@socionext.com> References: <1521166725-24157-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comment mentions it creates autoksyms.h in case it is missing, but the actual code touches it when it does exists. The build system creates it anyway because and need it. The code would not have worked as intended, and people have not noticed it. This is a proof that we can simply remove it. Signed-off-by: Masahiro Yamada --- Changes in v2: - Remove the code instead of fixing it scripts/adjust_autoksyms.sh | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4 Acked-by: Nicolas Pitre diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index a162258..e0dd0d5 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in . "./${KCONFIG_CONFIG}" esac -# In case it doesn't exist yet... -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi - # Generate a new ksym list file with symbols needed by the current # set of modules. cat > "$new_ksyms_file" << EOT