From patchwork Fri Feb 23 16:23:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 129438 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp789455lja; Fri, 23 Feb 2018 08:24:36 -0800 (PST) X-Google-Smtp-Source: AH8x224uMf74aGigK94KhaNaWWJkO+lE+TsyMWUzRaCvrdSAH38YLYHrQxedUSKzuzvDeSB2jq+t X-Received: by 10.101.67.198 with SMTP id n6mr1879506pgp.150.1519403076296; Fri, 23 Feb 2018 08:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519403076; cv=none; d=google.com; s=arc-20160816; b=dcla0BroiNcbPa+yHhrJfrUAi0h1nH4UsBGxYEiYabteFV5Myhz8QAQnKZ4GCSmYS+ 0TYKk8WFGYBoHL1BiHzQJbU92gMDWZn5EPRApg1eF4ifjfzIxH8ZsrvlwrCJAS+jhcec yRopVty5dnru0dWEl+ClpTn3l4/FLLUMK6I8Y/j5u7mV81wNcyvDMaVVPfLS16FtU47C HoNKI/ONJOPq8o7mjjJbGEsDwAhjeQ4kd0oRCNTkCgM742D7xGCXRQkN2ZegeDvktf8X S1YouRvTx4VMUhlaLZIcHOX6PjKfdbu4NDljD7KMADTEgAkDZMe1r75mO0g/oZSC7axu ebQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Y0e438AbNZGV4jRNOTibkRRfu0RQOywdAEDSZWaPuas=; b=N2WEhW1LoXN8aF5+dUWogo5xfw0LcisnnChYxcKzOtkodToCZZH3v2k1zhXZbCZRnj bGtsADqlPCUfs3/SeXXH71hhfiX8a94jeyI+azqT9HMmg62KYaEh8Fk3kA5tEJdEgNCd eUGiZHlbUnKxaCxB2mybVY6fTf1vCw2BNJuDkGia8HjFWuOwOw20OfOihq0ebI9WTyJQ yjZIfO2GqWnnz+kG6dcitZly8a0gIjppllfkpwGxbYFK/BJ8/5Y99IkctBR+AGSOF445 FwWx9phrZOa2pbnCY3+Q7CAq669GYzxrcGZgW1gmGEOcXykM7rqHg9Z0+b9TN0ALwm8z w3JA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si1972027plm.409.2018.02.23.08.24.35; Fri, 23 Feb 2018 08:24:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbeBWQYb (ORCPT + 28 others); Fri, 23 Feb 2018 11:24:31 -0500 Received: from foss.arm.com ([217.140.101.70]:57320 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbeBWQYY (ORCPT ); Fri, 23 Feb 2018 11:24:24 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E48315BF; Fri, 23 Feb 2018 08:24:24 -0800 (PST) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DCF7B3F25C; Fri, 23 Feb 2018 08:24:22 -0800 (PST) From: Sudeep Holla To: ALKML , LKML , DTML Cc: Sudeep Holla , Alexey Klimov , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH v6 10/20] firmware: arm_scmi: probe and initialise all the supported protocols Date: Fri, 23 Feb 2018 16:23:40 +0000 Message-Id: <1519403030-21189-11-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519403030-21189-1-git-send-email-sudeep.holla@arm.com> References: <1519403030-21189-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that we have basic support for all the protocols in the specification, let's probe them individually and initialise them. Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/driver.c | 51 +++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index ba784b8ec170..970c3a8c6e96 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -477,6 +477,21 @@ void scmi_setup_protocol_implemented(const struct scmi_handle *handle, info->protocols_imp = prot_imp; } +static bool +scmi_is_protocol_implemented(const struct scmi_handle *handle, u8 prot_id) +{ + int i; + struct scmi_info *info = handle_to_scmi_info(handle); + + if (!info->protocols_imp) + return false; + + for (i = 0; i < MAX_PROTOCOLS_IMP; i++) + if (info->protocols_imp[i] == prot_id) + return true; + return false; +} + /** * scmi_handle_get() - Get the SCMI handle for a device * @@ -672,6 +687,23 @@ static inline int scmi_mbox_chan_setup(struct scmi_info *info) return 0; } +static inline void +scmi_create_protocol_device(struct device_node *np, struct scmi_info *info, + int prot_id) +{ + struct scmi_device *sdev; + + sdev = scmi_device_create(np, info->dev, prot_id); + if (!sdev) { + dev_err(info->dev, "failed to create %d protocol device\n", + prot_id); + return; + } + + /* setup handle now as the transport is ready */ + scmi_set_handle(sdev); +} + static int scmi_probe(struct platform_device *pdev) { int ret; @@ -679,7 +711,7 @@ static int scmi_probe(struct platform_device *pdev) const struct scmi_desc *desc; struct scmi_info *info; struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; + struct device_node *child, *np = dev->of_node; /* Only mailbox method supported, check for the presence of one */ if (scmi_mailbox_check(np)) { @@ -722,6 +754,23 @@ static int scmi_probe(struct platform_device *pdev) list_add_tail(&info->node, &scmi_list); mutex_unlock(&scmi_list_mutex); + for_each_available_child_of_node(np, child) { + u32 prot_id; + + if (of_property_read_u32(child, "reg", &prot_id)) + continue; + + prot_id &= MSG_PROTOCOL_ID_MASK; + + if (!scmi_is_protocol_implemented(handle, prot_id)) { + dev_err(dev, "SCMI protocol %d not implemented\n", + prot_id); + continue; + } + + scmi_create_protocol_device(child, info, prot_id); + } + return 0; }