From patchwork Tue Feb 13 20:32:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 128301 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp34094ljc; Tue, 13 Feb 2018 12:35:32 -0800 (PST) X-Google-Smtp-Source: AH8x227PCKjzdKRuZoaMeACs3C2ySr5Xbc0pJNqx9Mbd/q33LrubXgpckOlkahr6NTNOQXyUpJS0 X-Received: by 2002:a17:902:7485:: with SMTP id h5-v6mr2263394pll.236.1518554131902; Tue, 13 Feb 2018 12:35:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518554131; cv=none; d=google.com; s=arc-20160816; b=meAllWWcJbgEY0jE2wDkAYAw3PNijmwJvMDjlflY+N+GKYbCugS/6BpflcEp+tCMZG q+F49Mf26HspgC5nqeXJlWfDdlBQfSFnKuENAG+46wjXGOZ4lJ/Z/KvNP4p/bsZqr/ck ke3AXH+m7961DqzDZWS5AHTdvgjP+l1FS8prQVcqnuin0hZhRdhVmmRpwXJCBAseVPeW sjh7gnowmHDFQ70RNMk0OpEPiTQ2c1T/VGN+TyDl03GdDSKN7fYizAvMC6XrZqx2WJRG mYnta2K/r66y58KiHWUREOJJOrr0NEug9URZ73HLuvKI5Rz6Sd0n7Q13x83dzG/reQ3b nH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=EN03PbsrZiRRqe4tJq7u3W330XNNPxoiJqtHTysQnFs=; b=HapwvnGiJGckru1kUVNSRB/cJ+j7HWxyDPQPVBDXauXfLCS0CqffCKCN4zB3GRDS+W m7OK26WgnE7zMMdegqWHukhZLNRQOp4mzSDqq18iRJ8B7hr6mtSN6N+bGcLL/yYB78ZT ALHtf5A/MBxjocZ/GHzHDcdmpAXUSBjeMVvqCwIKqnXeGTFODTdlTFJGL7npD83enUN4 tqIUTRUHdNXb7RBQTaEFrrywczjFV5Q+zWSFzE05zSriCPBROsG0K1zo/GnzaO6908hx zTh5RNhAdiikQfn3A011zn+E99e4HUnCauY41LPvFBcILUT0vtHe4TAyEbsfhEkUG+86 P8EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dcOKRsEo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n129si108109pga.260.2018.02.13.12.35.31; Tue, 13 Feb 2018 12:35:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dcOKRsEo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965876AbeBMUf1 (ORCPT + 28 others); Tue, 13 Feb 2018 15:35:27 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:39649 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965634AbeBMUcw (ORCPT ); Tue, 13 Feb 2018 15:32:52 -0500 Received: by mail-pg0-f65.google.com with SMTP id w17so670778pgv.6 for ; Tue, 13 Feb 2018 12:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EN03PbsrZiRRqe4tJq7u3W330XNNPxoiJqtHTysQnFs=; b=dcOKRsEoc1JKX6Br+4wnJstQv600hGAlsAcCP2/+h0WJurO14ocItmm21QqUPsSd9D tUteljV0oeogOyCJDl3e2eD3PL/2T6jpxQav4TviqavnrbInaTyP8BZ9OIwnKBOH0jQr Ec03h9IxEhLwYf8NikCJppXuQr1VoFByI0ePE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EN03PbsrZiRRqe4tJq7u3W330XNNPxoiJqtHTysQnFs=; b=dmNfw8grkirEiyTvBWG8Wzf1RX20H+lM1GykNrIVy6pDu1G9GsB0pEYjmJ9T3b2yWE 85Wr/D2XmVMbarngt4AuyTAtXzZ9awQDg2O2G5OyQ2e+ewonmg1tNNEROkU6BEt4ycvy Ai7Zt6bwQneXLnSvP+Rfb1RjP7nS/ekUw8pclDJlW3YXmiwV0aBhIh74XYlwshEeydTv RZQgKLMm+ee93fjm4EUeDCdBlgT9cWLIwCayO327T4ZQHrhjNGbtn7upXamqZulYpS3J emDS5x/rjvVoKDxCr4BUCSkS+GYh6hMwDLNrOoyXGL/0EfX6s8HZP+r0kSLG/pa8Alrj iIdg== X-Gm-Message-State: APf1xPDmugiP1c0N/Kz0XgopJE0D/jRy7B7ULYbOWrGvxNPspXJTdPlO hvdwx/keDy/RRp7CKxyPhWKZzQ== X-Received: by 10.101.68.82 with SMTP id e18mr1909353pgq.329.1518553971987; Tue, 13 Feb 2018 12:32:51 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id o135sm35540873pfg.45.2018.02.13.12.32.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Feb 2018 12:32:51 -0800 (PST) From: Mathieu Poirier To: peterz@infradead.org Cc: lizefan@huawei.com, mingo@redhat.com, rostedt@goodmis.org, claudio@evidence.eu.com, bristot@redhat.com, tommaso.cucinotta@santannapisa.it, juri.lelli@redhat.com, luca.abeni@santannapisa.it, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 01/10] sched/topology: Add check to backup comment about hotplug lock Date: Tue, 13 Feb 2018 13:32:38 -0700 Message-Id: <1518553967-20656-2-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1518553967-20656-1-git-send-email-mathieu.poirier@linaro.org> References: <1518553967-20656-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comment above function partition_sched_domains() clearly state that the cpu_hotplug_lock should be held but doesn't mandate one to abide to it. Adding an explicit check backs that comment and make it impossible for anyone to miss the requirement. Suggested-by: Juri Lelli Signed-off-by: Mathieu Poirier --- kernel/sched/topology.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 8010c2974d30..7c744c7425ec 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1863,6 +1863,7 @@ void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], int i, j, n; int new_topology; + lockdep_assert_cpus_held(); mutex_lock(&sched_domains_mutex); /* Always unregister in case we don't destroy any domains: */