From patchwork Fri Jan 12 08:03:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 124259 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1755674qgn; Thu, 11 Jan 2018 23:57:26 -0800 (PST) X-Google-Smtp-Source: ACJfBoudODpA0rbR1sHhqCLdDIeWwPLicedScvFRkC4cDggn8tjFuNO6e1mjdKiTsgddFJMRSJyc X-Received: by 10.98.245.69 with SMTP id n66mr10906847pfh.137.1515743846677; Thu, 11 Jan 2018 23:57:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515743846; cv=none; d=google.com; s=arc-20160816; b=j+UywgEidsE0REmNwNxJd/iCZvuizevkja1OAesyDfLT3RHv1xpzsgEDH4lyiSy127 2IkRtaH2CfrUwAL0ahH7gLyJd+F9u3HNbPI8ju0NCT7bwFeuRBUCDCyFaZNovQl2QZT8 2ts3PWzL9yQ++yLEGeR6NzTVkcm7vWeFEpIGnfkGoPsSd8IzuN/wmyrm8SFk7k8FM60g GPQ5KfW7raB30UWfic9O5DkU5enBNldBKPtQapSF8q5EckVTl1g/9IMsg2iY3XCSFQk5 hOleWbO4qY4fMuf4FHR1vUf1bp0cXcAMD5cnz+JxgcvyQoL/y0WFhPhiAVcCp/dJQGD0 kpNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=5hVHaM4NwrxBKNEEiVqfcBnHMf3YVBeE38n3NkiFJzg=; b=FLWKhLJbEaQQpNhGt+zxEGOxmtwuRDPGIaX999EivUge05f3A7dfOGOZz+0cYc4ijv +bjjyzu3gu7Yiumx+u0p1jTeRyXESEOYnjMdrhsICh+YeXuFF2pA377QQXCUoTAT6rcF qrEiqpnpqOUzSgC9KSFWj+KmVqNnIX16p+gt108qdZgGCFF+B3da5f7QpZMzEwuU3ZzN 6058mim6+JWD53BtGA6ft3eAQZ2YK/7/Hbes2v4RMBxBy4xAofjDG7q3NCi+lZ5B/AW+ TtrpeTtLKwm6iApyFOqC5hNfiDOCAb7OIaP9dYhMM1XccAe+a8Ef5sTf+GT42op0Hh+D YQeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u91si15396410plb.50.2018.01.11.23.57.26; Thu, 11 Jan 2018 23:57:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbeALH5Z (ORCPT + 28 others); Fri, 12 Jan 2018 02:57:25 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4186 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754576AbeALH5Y (ORCPT ); Fri, 12 Jan 2018 02:57:24 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 2582D50BC4EAC; Fri, 12 Jan 2018 15:57:10 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.361.1; Fri, 12 Jan 2018 15:57:06 +0800 From: Xiongfeng Wang To: , , , CC: , Subject: [PATCH] drm/nouveau/core/client: use strlcpy() instead of strncpy() Date: Fri, 12 Jan 2018 16:03:29 +0800 Message-ID: <1515744209-136099-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/gpu/drm/nouveau/nvif/client.c: In function 'nvif_client_init': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 32 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the dest string is nul-terminated. Signed-off-by: Xiongfeng Wang --- drivers/gpu/drm/nouveau/nvif/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 diff --git a/drivers/gpu/drm/nouveau/nvif/client.c b/drivers/gpu/drm/nouveau/nvif/client.c index 12db549..f294d99 100644 --- a/drivers/gpu/drm/nouveau/nvif/client.c +++ b/drivers/gpu/drm/nouveau/nvif/client.c @@ -69,7 +69,7 @@ } nop = {}; int ret; - strncpy(args.name, name, sizeof(args.name)); + strlcpy(args.name, name, sizeof(args.name)); ret = nvif_object_init(parent != client ? &parent->object : NULL, 0, NVIF_CLASS_CLIENT, &args, sizeof(args), &client->object);