From patchwork Fri Jan 12 07:56:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 124257 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1750493qgn; Thu, 11 Jan 2018 23:50:11 -0800 (PST) X-Google-Smtp-Source: ACJfBot78gpBmf9inEankUWpTkfXGIEQYjV6v8oPuPYjnJpbqoXQ05iQB9EwyA0m/EjNevxYE31j X-Received: by 10.101.69.141 with SMTP id o13mr3087327pgq.204.1515743411665; Thu, 11 Jan 2018 23:50:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515743411; cv=none; d=google.com; s=arc-20160816; b=dYfCwCkCAm+JqdhHROAyq1HD4D4JBVZ/lMfI2tCB5dHZ8JnHDXL1oSdS31FGhJYWYw 0OArKIfvHgi+gnidbkrKlFuNRuHPLlIB9DQldhyg+LbVkNlulxvqoJbpIaFKJFvlCF8j gMojjU0dZbyJziWsCeY0RJnHdXYRXKvVmRJWoRkfx9J9EfDViVtqX2Qez2QAg7i9KpFi w7T1EFrNHWQMZNlOkCAJuWpxI0/d1acmofBgVMM/UysNM2ebH2YB9Is5EzTqEqs7q8Ar Pgy243oxqQcfNOYGNiSPQFVX+4NAwS8iLoaGRb0RUdCY/bSJAa+kXRO9aobc/I3R9kyM 3Fxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=eIkePDeQHEV0xQA9w4+KwL0858L/3zLSXSC2qAHdYxg=; b=FNVerEmfd1tVdO9zHrqtkH9eAg/rIry67V7VQTo8nKKslfyZhbWd9t/FH1AqbWLrTu xn8FvvWhzaoT1dutVXdVkdJtysrD3Pkxw+A0xP4IEh/HGD6MRkU1oaO1Jdrhnpz43QV6 H1sOxEehM3nMZlUa0RN6liJa0X7naSFVHqE3jak/hY12fLzYoK5AAgJxwGOFuJ/lvp+l Vg9P068/8ZZwLpP6971D7EytXzaj4eLKyU5M84jAVjo/MTvrXW44x/qT8LZiIASf9vp0 wow+tCxzuxiHHKBJUBLpS4UgWCH3vUsSS0sUpfmqVaelmnBtLdzWBUZ/4huOYdwvWJfJ eemQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si4274167plz.649.2018.01.11.23.50.11; Thu, 11 Jan 2018 23:50:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583AbeALHuI (ORCPT + 28 others); Fri, 12 Jan 2018 02:50:08 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4172 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754285AbeALHuH (ORCPT ); Fri, 12 Jan 2018 02:50:07 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5D2992C363F94; Fri, 12 Jan 2018 15:49:51 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.361.1; Fri, 12 Jan 2018 15:49:42 +0800 From: Xiongfeng Wang To: , , , CC: Subject: [PATCH] IB/cma: use strlcpy() instead of strncpy() Date: Fri, 12 Jan 2018 15:56:05 +0800 Message-ID: <1515743765-116090-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the string is nul-terminated. Signed-off-by: Xiongfeng Wang --- drivers/infiniband/core/cma_configfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 Reviewed-by: Leon Romanovsky diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c index 31dfee0..eee38b4 100644 --- a/drivers/infiniband/core/cma_configfs.c +++ b/drivers/infiniband/core/cma_configfs.c @@ -295,7 +295,7 @@ static struct config_group *make_cma_dev(struct config_group *group, goto fail; } - strncpy(cma_dev_group->name, name, sizeof(cma_dev_group->name)); + strlcpy(cma_dev_group->name, name, sizeof(cma_dev_group->name)); config_group_init_type_name(&cma_dev_group->ports_group, "ports", &cma_ports_group_type);