From patchwork Thu Jan 11 13:39:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 124206 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp694241qgn; Thu, 11 Jan 2018 05:40:31 -0800 (PST) X-Google-Smtp-Source: ACJfBosluCQSsCXMYY72FK6QkT+u6YYZY6RxDvqukMJ7sTycm3IcnjouyAtoPDv965oxJV7ngnxU X-Received: by 10.159.242.136 with SMTP id u8mr16580656plr.291.1515678031569; Thu, 11 Jan 2018 05:40:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515678031; cv=none; d=google.com; s=arc-20160816; b=GWjOfC0sq0LQALbruWVslVqPKHfu4pI5jwS3O6mmF2mhnlG9amAnv+diAgj+BlNR39 wjpRA7y5Mg3d3vQIS4J0+dl9GrdeH9hyyHkGbDTI60rvMi/qjrHTjeqqFGxvBvtbq/ln mFHMhoiQHVXU9wI01dNYJYZixiPLVDPF5/uFDLO4QjCwyhiwvUJnvYM6JOyanonj5CI/ QmdF4PXv22GmQx1eYGBB2nP2wvoveAu42msqpTLgKch+yJ+yII0wDtdeDE15AXbd582L FM5ftzYRbXenuCO98X99LDAz0iVPHtFnBACcZv1KpPS5tdfPE7onIc/N3kgzk/y7fdzz aEOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=xmbxBYJ2/yjaGGGDXV7NvXHUmcEH04QM4bolXFZinFw=; b=LWtRP22dmmi2arqeksATTHH55QbZBjweIAYwhBAYMJiXoEE3ptobmT823mj0JHvGPZ zGWv+q/+IoU5LIlrOxu2rAxhtZrnJ+GtJRD1iV84mQc3VSNeQautstVYHSwvEk+fcMoD RrCN1XvWdLT/aJf9SRsJ9xIcRGhTSJVVivkTxnvgn7ZS0GgixKmgmiU2XU0bgiwjB27T GHV2Lm+g9/wLL017B8vMg32SpfijiisQi8bcwDjtDY3B15kx/wpLspEb7ZHVQxmze2hk LFTyE449EP2oha7/VUWarOZa8YtIYbRlC+q/sVBOudz0tVz5mZD8R0vx1qYU479ZBLIV ZQEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=zqor7JbA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r16si12048476pgq.616.2018.01.11.05.40.31; Thu, 11 Jan 2018 05:40:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=zqor7JbA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934223AbeAKNj7 (ORCPT + 28 others); Thu, 11 Jan 2018 08:39:59 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:21222 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbeAKNj4 (ORCPT ); Thu, 11 Jan 2018 08:39:56 -0500 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-08.nifty.com with ESMTP id w0BDdnaQ002436; Thu, 11 Jan 2018 22:39:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w0BDdnaQ002436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1515677990; bh=xmbxBYJ2/yjaGGGDXV7NvXHUmcEH04QM4bolXFZinFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zqor7JbAM559qofK8LZmarBYgSaJTkXBud5l8gSqJdqsN5fnAFGOXu+WRbXCMuMY4 F5hNPj0ZSVKHftN6Mf6jlzPUf8tm1G5lj/Nst2ctyYHzNF37mSSGeOhmfWxijR5ITd /scP4MUiK6OMu8i8kcpznpBHMBILkwy8B9RKJPKKrqzbITwSPz9Ctgor9P7I0RQe8o EME6Np10x47kNplgfoP+Wkv890Axf3r9kvTOTZsgLhA+FtXLYiX0khZdZvwyMy3Cb2 N8FAT71or2g2jCrDz9OjSXKBin79MTf0kuXylHHoJm+NXIIV7WdIlPixF1S0J7YuIu MsEbS50hsIkeQ== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] kconfig: make xfgets() really static Date: Thu, 11 Jan 2018 22:39:40 +0900 Message-Id: <1515677981-21952-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515677981-21952-1-git-send-email-yamada.masahiro@socionext.com> References: <1515677981-21952-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports: warning: symbol 'xfgets' was not declared. Should it be static? It is declared as static, but it is missing in the definition part. Move the definition up and remove the forward declaration. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) -- 2.7.4 diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 31c09c6..01ed336 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -20,7 +20,6 @@ static void conf(struct menu *menu); static void check_conf(struct menu *menu); -static void xfgets(char *str, int size, FILE *in); enum input_mode { oldaskconfig, @@ -83,6 +82,13 @@ static void check_stdin(void) } } +/* Helper function to facilitate fgets() by Jean Sacren. */ +static void xfgets(char *str, int size, FILE *in) +{ + if (!fgets(str, size, in)) + fprintf(stderr, "\nError in reading or end of file.\n"); +} + static int conf_askvalue(struct symbol *sym, const char *def) { enum symbol_type type = sym_get_type(sym); @@ -705,12 +711,3 @@ int main(int ac, char **av) } return 0; } - -/* - * Helper function to facilitate fgets() by Jean Sacren. - */ -void xfgets(char *str, int size, FILE *in) -{ - if (fgets(str, size, in) == NULL) - fprintf(stderr, "\nError in reading or end of file.\n"); -}