From patchwork Tue Jan 9 11:58:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123894 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3924762qgn; Tue, 9 Jan 2018 03:53:12 -0800 (PST) X-Google-Smtp-Source: ACJfBose6+yYeDCfBrjJxLAPSxoFLNrRSnxfGnAUHExKswT6e+i3wGzK0n+v4aovcVQwGcZmvR4f X-Received: by 10.98.26.151 with SMTP id a145mr13584875pfa.206.1515498792093; Tue, 09 Jan 2018 03:53:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515498792; cv=none; d=google.com; s=arc-20160816; b=yHLtxDIUeFs6Psd3cacRhIVgtbvGSfoOoTbTdqi2x+VGph1CDUmIkLuWPEWJ5grd4P D2z2x8CpWxalaAAWaOsvilvKNfx8fp08CeTjYRyZm5Ic24F03gGuYY5109ZO6fd9Xw9H khZoAzUp0aSeYUEt2wej7f2iR7wLiXREoPgPPUWk+DYmOOZjRYQ2Ze3i8/ZwfB2L+1NL f0pKz8ZH21sRCvY/tnPuCF9Vx2QnmAABoJe68anmOQMX7H07VCrN4DGrs9lDCRSEhzm1 2oaJGTsS2a5sk/NRuMbDZUK9Z6JXITsdLbgoCw2La7iOax90jTuMFlwcIsgvllAOXBfp emmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=FekMhWu4073MV3kNJN38bIVB/CiN3ZLCGhpJU7l88Zk=; b=oGRW5LTXzZY3vqlWIwTE0+g2aBukD1IApayEo3AOEcnpYTKQSNsaAew88BNUsEK5T/ 6bh6DMuo6R6oc+C0nByZ/1hvduwxXvd4bYLM5sLZaTbjQknXTMG63rskaZrQKSBOf62q EAJbTXs88r41DetWNV54bYHq56/3Kmh8q/w/N34J0JL9u3s+BCqDtVvK74ys3YoverS9 DhPas3gFGwrkMi6YC76EtBxYjnvH6kohHYTMs1TWzsF5UhHN1uZWgvB7bJf5b793WE29 LU9BzusaKJXZ17a9oJEMXfX5tlm3dyIOavfw9kke9bxjlrzmVdy7EjbdJ6yWP2JP00Oz sZhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si9993255pfk.249.2018.01.09.03.53.11; Tue, 09 Jan 2018 03:53:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754910AbeAILxJ (ORCPT + 28 others); Tue, 9 Jan 2018 06:53:09 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3707 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751228AbeAILxI (ORCPT ); Tue, 9 Jan 2018 06:53:08 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 49B1C62AD47CA; Tue, 9 Jan 2018 19:52:53 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.361.1; Tue, 9 Jan 2018 19:52:46 +0800 From: Xiongfeng Wang To: CC: , , Subject: [PATCH] caif_usb: use strlcpy() instead of strncpy() Date: Tue, 9 Jan 2018 19:58:18 +0800 Message-ID: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports net/caif/caif_usb.c: In function 'cfusbl_device_notify': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation] The compiler require that the input param 'len' of strncpy() should be greater than the length of the src string, so that '\0' is copied as well. We can just use strlcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- net/caif/caif_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 1.8.3.1 diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index 5cd44f0..1a082a9 100644 --- a/net/caif/caif_usb.c +++ b/net/caif/caif_usb.c @@ -176,9 +176,7 @@ static int cfusbl_device_notify(struct notifier_block *me, unsigned long what, dev_add_pack(&caif_usb_type); pack_added = true; - strncpy(layer->name, dev->name, - sizeof(layer->name) - 1); - layer->name[sizeof(layer->name) - 1] = 0; + strlcpy(layer->name, dev->name, sizeof(layer->name)); return 0; }