From patchwork Mon Jan 8 12:40:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123699 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2668891qgn; Mon, 8 Jan 2018 04:36:01 -0800 (PST) X-Google-Smtp-Source: ACJfBotDfuoSzyFEOOL72NmodSgNjLaIoX9f8kHSD12eJ0SrFAtqA5Tiy3w5ZKMi3tbS3xHD7ss3 X-Received: by 10.159.214.143 with SMTP id n15mr11963874plp.49.1515414961211; Mon, 08 Jan 2018 04:36:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515414961; cv=none; d=google.com; s=arc-20160816; b=SLKrO++daX1EwvPekr7COMMI+d9cvEo5VJjELLGzlVEa/R5RK9p/RZ1Col3000ClPX BaqcsQdKOL58hOKR/cEvVy+s0DducVQOCNlcgwoPuT6w6GpgMNnbhXu++vZg+0ri6Em4 gGhx3Cs6QbYUdCv/r1Ax4RtE98QbfaNckv/EommFFiU6mAfs9juz0+GpHn8vfi+zZI0z 1zmtoG/27ONaoqqikedVoqqulggUjZ43SMukYbGUGRH/wwe7bIKK3/0GOfSP54NL5dnW VpVFfR0uEXsi/poYBo8xo5lD/wsJrRnXSG/D5/A7z99wZCWp7mX/fLD2vLbzpR9DbmjC 6H2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=hKr6qt3CA8xbSFdOGKOD5uJD9EHmlIu/rzxQmBhFThA=; b=QMtJQLV3q9oHjUefHIQCC+Cygw1+8BGJsEzZJ93ZYYtPkq6lJPNLuIPycSOIZch2kz EtutKGJ4nXGZsQj+mNiaM/C//qq9HW3Xb26wULa0qCwSjd0XpBpfJjV/tr2gVbZs7ICu SaejYaD0XhdtxqTSyfzd3YqM7XDKrPjRR3Ck/U/bZfgG7rqa0q27OEKek2aq6eIu/FJx gtyAsSF8sv/j3PFYsXxrWueIj//e7QiMshT9L6LZbUkDvRYa6iU5t8kNARr7jGFzjWQY zJN0/hqAglL6WtpOPfOQT34DVjGciGlMLsxOitbWwQq7H2MjQ7EU1YEJ5cwiSSoA0wF5 S1cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si7423505pgv.215.2018.01.08.04.36.00; Mon, 08 Jan 2018 04:36:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757325AbeAHMf7 (ORCPT + 28 others); Mon, 8 Jan 2018 07:35:59 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3700 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757295AbeAHMfr (ORCPT ); Mon, 8 Jan 2018 07:35:47 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0B6EFBA464B2E; Mon, 8 Jan 2018 20:35:34 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 20:35:24 +0800 From: Xiongfeng Wang To: CC: , , , Subject: [PATCH] media: media-device: use strlcpy() instead of strncpy() Date: Mon, 8 Jan 2018 20:40:59 +0800 Message-ID: <1515415259-195067-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/media/media-device.c: In function 'media_device_get_topology': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make sure the dest string is nul-terminated. Signed-off-by: Xiongfeng Wang --- drivers/media/media-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 Acked-by: Sakari Ailus diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index e79f72b..f442444 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev, memset(&kentity, 0, sizeof(kentity)); kentity.id = entity->graph_obj.id; kentity.function = entity->function; - strncpy(kentity.name, entity->name, + strlcpy(kentity.name, entity->name, sizeof(kentity.name)); if (copy_to_user(uentity, &kentity, sizeof(kentity)))