From patchwork Mon Jan 8 12:08:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123694 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2632999qgn; Mon, 8 Jan 2018 04:02:57 -0800 (PST) X-Google-Smtp-Source: ACJfBovJS+VIZooSGeTfxesDRiDB+p4RCJVC7kwqzSn2CO6MEQx5xIRxDjcBuiay3mF08drp2rGK X-Received: by 10.84.133.131 with SMTP id f3mr11848141plf.280.1515412977197; Mon, 08 Jan 2018 04:02:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515412977; cv=none; d=google.com; s=arc-20160816; b=oev1byT6vOA1P/xcWaLexWiSA69q0ZWmO8XrkDXNxyI9D/kHUazm8IVtHWC0VxCgu0 KrWdToqkBK6Uo86NrJLLtT76VrfMqZIR/k7K4gFAAtzXLvWESqfEpHYAwi6cGNwSIjq6 vVYf0bjS0hMTGgjwGqmXs/rSf5p2BKa2bO2PGHC2DNMusid9qBjYceAlYfmDssN4+jNm YS19JhUtIlV1M/o4lLgedMUHkj/A2FXExM54s2+ja6TdAv2ZE00Z+cTPvm8DKRn/kboB eDrazsQZuGeVi6UeUlpuRVo4NvWWVcDSk7vwt/aGaM2itQVib601wlXrJ7xtFMwVBG2t oH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=nz8+V3kFJxxBDc8uGacsK0r7OkzwU2zdqTcmOesNpQo=; b=ROlkW8PgzdRR6KxgAueeiZiBz/S+yXb5hiBrleGC2lsV9TafY/e64ENMD9cFzg9R6X YapM+rXINNRfjsIEWoBnKpaphZumPsWO7zV0LpFC7O0qiSWdGLNX8XqthEKRmPCWt4Qv TAxvZvzbqoLb5WWH081IwHQDe1mQvmCQF0Hr8YbDpEPesZeASJ+DcOEFH2D4774ixk1S SVFmQ3KHiP0XBhSkLP9XTYEUi9uevmCh2/Aw6Pzzli7ZJXB0bh3EQqj+W27o+aQ+aVp/ kiWZbYzh0HT7y4+F/jQp0RwcOhF9gDUnUQAWZvMK0g+VjCTM6mUamkfrwdg7sMxb9IX2 VStg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a90si8477457plc.137.2018.01.08.04.02.56; Mon, 08 Jan 2018 04:02:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756372AbeAHMCz (ORCPT + 28 others); Mon, 8 Jan 2018 07:02:55 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3754 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755954AbeAHMCx (ORCPT ); Mon, 8 Jan 2018 07:02:53 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 904E41A25890E for ; Mon, 8 Jan 2018 20:02:39 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 20:02:32 +0800 From: Xiongfeng Wang To: CC: , , Subject: [PATCH] auxdisplay: use correct string length Date: Mon, 8 Jan 2018 20:08:05 +0800 Message-ID: <1515413285-40933-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/auxdisplay/panel.c: In function 'panel_attach': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 12 equals destination size [-Wstringop-truncation] We need one less byte or call strlcpy() to make it a nul-terminated string. Signed-off-by: Xiongfeng Wang --- drivers/auxdisplay/panel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.8.3.1 diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index ea7869c..f8344e4 100644 --- a/drivers/auxdisplay/panel.c +++ b/drivers/auxdisplay/panel.c @@ -1506,10 +1506,10 @@ static struct logical_input *panel_bind_key(const char *name, const char *press, key->rise_time = 1; key->fall_time = 1; - strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str)); - strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str)); + strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str) - 1); + strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str) - 1); strncpy(key->u.kbd.release_str, release, - sizeof(key->u.kbd.release_str)); + sizeof(key->u.kbd.release_str - 1)); list_add(&key->list, &logical_inputs); return key; }