From patchwork Wed Nov 29 15:20:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 120025 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp4498266edl; Wed, 29 Nov 2017 07:20:47 -0800 (PST) X-Google-Smtp-Source: AGs4zMbbjPFbAOsbWxBYxCdIyo1c7aHEczb/RK4tNQZ0cwmXNlB7jHKdh25pNHsxHIDRv8TDSaIp X-Received: by 10.99.39.5 with SMTP id n5mr3211559pgn.48.1511968847230; Wed, 29 Nov 2017 07:20:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511968847; cv=none; d=google.com; s=arc-20160816; b=W/ogH9DZu0nvbFfKRTxNGyILcNUJ1WSLZKgrUWAlQJdFAbKZI5tiGippKA5ajRUn/l N5sXr1XuaRqQghDoj40qIygN5m3/3EzkOdGvcxUBbD0tMnqiK6A+fT0RYn0fJzML2C1f jOfxna+S+YfRa1ceb5acyFqjlLwGxXyXx9LiSX88VuyF69loL/2jEk0frDDHKMw2ZJFg A+qPkiYBHLzqI/YQ3IQIRQRU/zIILzmT/2SAZpSGER9+9+VAeFkvzvjKfx0iD3j+dYUF mZPTJF6Z7lTtP2MZQI15eCtui9/kpsP5L3M5MpAHX6+UxLNfBDbkYOOoRoV4ucDK7b4A WkIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=gz8AIf8B25PGWifycXCy+izgFD4pgHLrQRU34854JOg=; b=NTin5yVoIGPJ1WVvIu9KBqu37bG/gQQApIvhVtQ+bL+LWdf3LA+hPlPmJ3Yl081Ia8 6lhG2s49KYWxHQEwhQbI81mijjdsvvxaLl+kLttcVklggzoR5ubEALirvDLIAGCMHOke cdAyjrvuAzby20hcPbk7nHnBUnhTzyRa67MLDqJ71ghqEkZSFqon2TTED/cVUmRJKUK6 f9QKVm9U0d8DcjTi1stz4DndpBXThpipr5y0n11HRmuNWwYoDJRmJTnSGqKlqRQyHM/b 4ZEiXOP29KKTWi8BT51qcJRqHGQODhr/eF/tZwJO+Fx8SxWP0fV1phFoYxBAzME2Fr1t dcXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f28si1399155pgn.758.2017.11.29.07.20.46; Wed, 29 Nov 2017 07:20:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932893AbdK2PUF (ORCPT + 28 others); Wed, 29 Nov 2017 10:20:05 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:40184 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755461AbdK2PUE (ORCPT ); Wed, 29 Nov 2017 10:20:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA9C01596; Wed, 29 Nov 2017 07:20:03 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BB8113F236; Wed, 29 Nov 2017 07:20:03 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 9573B1AE50A2; Wed, 29 Nov 2017 15:20:06 +0000 (GMT) From: Will Deacon To: linux-kernel@vger.kernel.org Cc: corbet@lwn.net, mawilcox@microsoft.com, Will Deacon Subject: [PATCH 1/3] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Date: Wed, 29 Nov 2017 15:20:03 +0000 Message-Id: <1511968805-20651-1-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 diff --git a/scripts/kernel-doc b/scripts/kernel-doc index bd29a92b4b48..df0f045a9a89 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -3248,4 +3248,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);