From patchwork Fri Nov 24 16:24:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 119606 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2443280qgn; Fri, 24 Nov 2017 08:27:05 -0800 (PST) X-Google-Smtp-Source: AGs4zMa7M9ZUVRMU6qyuxbQ9o9h+WS6uFMBN6xCgrbQWdTFnmUc6UuRgCM5zpgYwixAGTZJ0dlKG X-Received: by 10.99.111.67 with SMTP id k64mr28384306pgc.234.1511540825648; Fri, 24 Nov 2017 08:27:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511540825; cv=none; d=google.com; s=arc-20160816; b=ElVeGDyImnAlxWua6/teVgqr7FMzhmaeQSmcSZWN+54VMKz6AAHxQdDOGnYEmbV+mf O2w/qyGfeRWlGEkXdXCAi1oUtKswquFUJBzP7aTa8FjaP5IFL3jRv1/rw0bBCzPE7vql j3wSNfkV37Knm6OR5xByF8307UIMz6i0XG1dtKj9nmQSqmbQ630Z30sbKKk1sJCLnZO5 ZAUPtV8uqhwoRuTGwcA1M6qEDQI1Yu42xv2zN5W2imxii4CLGvdrCEYpTRUD7hC1vnkJ g0SrvoDIQ43i8Wc5j4SYaLukqTTfpGDoEm5C+sAXvajoZOVXjTFx8Ayw9nHGF6sk67Y8 wbWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Z9AmOyayl4c1S87/wp/oI9oZDCFOvZwprDL24YdjVf4=; b=Os0iYnNE7P0tL2GfZiT/qiJDLMqvh19p4zfnpqOnmURjK7vqv5whOyX7RROVdkMp3c 9WvE34VSXv9Ca6RVUzbIqpBX/HOpI1D1aH32Ek1h4K8fykKl0xFL5hl7DJ8O734gOM4Y JYSmMnjtAl0cq4w0Idd2EGzanebqqYTkSO/wbamt4ce0T3nacnS3Lah73l9R544N/E97 RKHQ4yGWL7fABo1MiaAiqqBXn6Q26hthiyxAKeD32SFolTtzJvr3ycp5aYTfcdy6o2GM sR3Th6vCR5cFbyVzOpXvKr0VQRwb2vKn0eDB+yUGpV1LPTnE6N2FqxJGFeX4nP4G0WsZ pqPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=jI8ytPDf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si18314354pgp.418.2017.11.24.08.27.05; Fri, 24 Nov 2017 08:27:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=jI8ytPDf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753747AbdKXQ1D (ORCPT + 28 others); Fri, 24 Nov 2017 11:27:03 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:61697 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753806AbdKXQ0K (ORCPT ); Fri, 24 Nov 2017 11:26:10 -0500 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-11.nifty.com with ESMTP id vAOGP9W4007100; Sat, 25 Nov 2017 01:25:24 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com vAOGP9W4007100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1511540725; bh=Z9AmOyayl4c1S87/wp/oI9oZDCFOvZwprDL24YdjVf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jI8ytPDfb/8AfbJyoJKWhAw9jkVsg+hl937MMf4hqiheFApjsfgGr+LdcjmxprEdD 89eAQKggbFXPwHbQ+6+ibCZbU2jvou64AV9NKORRhhi/2ddw5iIcC+nJL+v9GHxxpn BuGP2d5bxGk4UiQCEnZpOpmxD7FyfGeG5rQvkUN1FTcjro/KqyoTf9y/uxCc6JLZI9 bThYOHiepNfeWwWjtY6728E9q+abPNSA6tl3gCL1IssReHt8J5N1FDiG3hJNAWaJLH 5qBNaly8wcyGe8RnoXz+TotYZARilAF8vy68Vhpd619g1B4Vdh5SkG3aQ8de8D47Aj FqC+Zd2EZSENQ== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-mmc@vger.kernel.org, Wolfram Sang Cc: Simon Horman , Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH v2 18/22] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe() Date: Sat, 25 Nov 2017 01:24:53 +0900 Message-Id: <1511540697-27387-19-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511540697-27387-1-git-send-email-yamada.masahiro@socionext.com> References: <1511540697-27387-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org TMIO_MASK_CMD is properly enabled in tmio_mmc_start_command(). We have no reason to set it up in tmio_mmc_host_probe(). (If we really wanted to set it in the probe, we would have to do likewise when resuming.) Even worse, the following code is extremely confusing: _host->sdcard_irq_mask &= ~irq_mask; The logic is opposite between "->sdcard_irq_mask" and "irq_mask". The intention is not clear at a glance. Signed-off-by: Masahiro Yamada --- Changes in v2: - Newly added drivers/mmc/host/tmio_mmc_core.c | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4 diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 345e379..f5b11b8 100644 --- a/drivers/mmc/host/tmio_mmc_core.c +++ b/drivers/mmc/host/tmio_mmc_core.c @@ -1194,7 +1194,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, struct mmc_host *mmc = _host->mmc; struct resource *res_ctl; int ret; - u32 irq_mask = TMIO_MASK_CMD; tmio_mmc_of_parse(pdev, pdata); @@ -1289,8 +1288,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, _host->sdcard_irq_mask = sd_ctrl_read16_and_16_as_32(_host, CTL_IRQ_MASK); tmio_mmc_disable_mmc_irqs(_host, TMIO_MASK_ALL); - _host->sdcard_irq_mask &= ~irq_mask; - if (_host->native_hotplug) tmio_mmc_enable_mmc_irqs(_host, TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT);