From patchwork Thu Nov 9 09:16:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 118410 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp6344340qgn; Thu, 9 Nov 2017 01:15:12 -0800 (PST) X-Google-Smtp-Source: ABhQp+REu9cnkm41Tok4D+u9egTFSrBUX1ItZb6JAnvNxtUIdhBoPP5oyWX/eo0TS2jfinegO7s7 X-Received: by 10.99.178.15 with SMTP id x15mr3260752pge.243.1510218912442; Thu, 09 Nov 2017 01:15:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510218912; cv=none; d=google.com; s=arc-20160816; b=BCWWf2okGdDxpnpfzffJRXX/ZnjwON6OR+YZJtsCSfwXs0N7xAkaCLoXerORowVhEx Nh0MAQeM/aZtMTaWFLPWrIworC+5Pe7zenc1cKaE10Wmywon61S+OXPlGztfRx8WXmEG OWpffmT0Tr0kWReKCJK9eWPZMSFYdCf/HL2D/hL66V2quJyTy1gtwbiBgWMoD29/r+zi AcYzhU6j/Zbd4ZD3FlTGwdFwzaCzLcT49yF0Pmq0KD0eCxPVQlGCfj7L73UDu6U1aK5g T3lel9TjG5LplX8M0d1e/OIYFT26s1X4PDmGMzPWi92YsNdt6mWuiFno0UiWNDz4DZYV /Q6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=784FYCPwJeNBDCxwf55rekRs5Wy8mND1KEuUFUIcxNE=; b=vO50qtROjNotlr8X8k+b5L7OXmVqLFZm3HlcufL2Pb+ScJ6U6jKCJkvHaao4np2GDT IZmerC/cX7WTAbjIOLpKaRu8zS++3lNKbfE+UjIT3Y3TjbUoHZEoT7+79NYgtB+sq49p smUNxzC+co1ag13ujK4yJwUVksSgmuorNj2j/+nJx3M7RFTBgRiKDBtcccY3BHnGkJJH WOm9bxp1nvAaJ3uh+Jg2rhFZZ74MQa/PxXNuoty5HNkl2oUgstG025r8abkVLEr0aRLY XiT9MW3OhMroFFsNCHkC7ktRTs/alMnIAOlKDQREGva3gGbHIj6bNDCbmnXcCIR9wwUc GqMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p189si4410212pfp.296.2017.11.09.01.15.11; Thu, 09 Nov 2017 01:15:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbdKIJL3 (ORCPT + 25 others); Thu, 9 Nov 2017 04:11:29 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43618 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbdKIJLT (ORCPT ); Thu, 9 Nov 2017 04:11:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6809E1435; Thu, 9 Nov 2017 01:11:19 -0800 (PST) Received: from sugar.kfn.arm.com (unknown [10.45.48.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D07513F246; Thu, 9 Nov 2017 01:11:13 -0800 (PST) From: Gilad Ben-Yossef To: Greg Kroah-Hartman Cc: Ofir Drang , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/10] staging: ccree: simplify buf mgr using local vars Date: Thu, 9 Nov 2017 09:16:12 +0000 Message-Id: <1510218980-3549-5-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510218980-3549-1-git-send-email-gilad@benyossef.com> References: <1510218980-3549-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make the code more readable by using a local variables for commonly use expressions in the buffer manager part of the driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index 2d971f2..b3ca249 100644 --- a/drivers/staging/ccree/ssi_buffer_mgr.c +++ b/drivers/staging/ccree/ssi_buffer_mgr.c @@ -225,16 +225,18 @@ static int cc_generate_mlli( mlli_p = (u32 *)mlli_params->mlli_virt_addr; /* go over all SG's and link it to one MLLI table */ for (i = 0; i < sg_data->num_of_buffers; i++) { + union buffer_array_entry *entry = &sg_data->entry[i]; + u32 tot_len = sg_data->total_data_len[i]; + u32 offset = sg_data->offset[i]; + if (sg_data->type[i] == DMA_SGL_TYPE) - rc = cc_render_sg_to_mlli(dev, sg_data->entry[i].sgl, - sg_data->total_data_len[i], - sg_data->offset[i], - &total_nents, &mlli_p); + rc = cc_render_sg_to_mlli(dev, entry->sgl, tot_len, + offset, &total_nents, + &mlli_p); else /*DMA_BUFF_TYPE*/ - rc = cc_render_buff_to_mlli(dev, - sg_data->entry[i].buffer_dma, - sg_data->total_data_len[i], - &total_nents, &mlli_p); + rc = cc_render_buff_to_mlli(dev, entry->buffer_dma, + tot_len, &total_nents, + &mlli_p); if (rc != 0) return rc;