From patchwork Tue Nov 7 09:40:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 118130 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp3757265qgn; Tue, 7 Nov 2017 01:40:46 -0800 (PST) X-Google-Smtp-Source: ABhQp+R3oT/QEzr4+tgKOzD0YqjGNdpp+OxpLgNWRC7mS5DEHPmv98oOWjf0op3k0bIsNUx9Kxz2 X-Received: by 10.159.247.12 with SMTP id d12mr16978551pls.265.1510047646357; Tue, 07 Nov 2017 01:40:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510047646; cv=none; d=google.com; s=arc-20160816; b=pqwDYOk3QS3WQWXTidIPIoT4AlSrJrdOzDEvIzyS377/aSspHPTKx88Jd6SXaD3lFR gAi5MhBIyHCvjJvtdGP2jGpIoWxRSyO1PfhJyUJp5Qh4nF086DgJ4AeF9+vQjDRrzD3x QhSK+84uq8KnhU0OcgflDMzVIGO4rju40lPAVUHHI++/DCsV9JpZeNalz7IMpscGevpt 5qmoR9/7CO/YtoCFdxdxVxPHZbu75cEzO97d/p93z7Zx1m7Jr/dP4+i+qwh7LxG6FRcH qRCA8MHUAMyS/CUs3V5p8/+DEIKASNu6JD24NJAVCvnNH+Bms/dL5Od2Exa4tXPth/TO Vu7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=784FYCPwJeNBDCxwf55rekRs5Wy8mND1KEuUFUIcxNE=; b=Buh69GX+vIgb3iMshawXNQfjuQ7kXkdHy62p5euxv0ds3W3ygZks8yAFfxl6IPuGSx igVTy5Rr3ysORpPT18gkvI5aBJCNfbUjUjbvJDXZC11Q0B+jw1tiTMPaLrrwq2k53ZjZ 5DIAVgTvW9qgIkJYvNRKL3vFCJB5RNRdbE2kOVC+gzWnP/HS+3+8E6ZqeLIIaX3WWxQK AHpoSIu6tyyb3Zih+b9M1AKX0IrZSrMWy9ZZoPH89KZ0oBM+PtRB2ckK01h1B1OX2FMG f7ce1hRKw0XNfwhzY+QEojtYjWB1WgO3T05DmhK2vRqPV5qvkcwuxmIRkaA/gLJRySy4 ylYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 137si718234pgd.277.2017.11.07.01.40.46; Tue, 07 Nov 2017 01:40:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756745AbdKGJkl (ORCPT + 26 others); Tue, 7 Nov 2017 04:40:41 -0500 Received: from foss.arm.com ([217.140.101.70]:46376 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717AbdKGJkg (ORCPT ); Tue, 7 Nov 2017 04:40:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B235D1435; Tue, 7 Nov 2017 01:40:35 -0800 (PST) Received: from sugar.kfn.arm.com (unknown [10.45.48.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D21D3F220; Tue, 7 Nov 2017 01:40:33 -0800 (PST) From: Gilad Ben-Yossef To: Greg Kroah-Hartman Cc: Ofir Drang , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] staging: ccree: simplify buf mgr using local vars Date: Tue, 7 Nov 2017 09:40:00 +0000 Message-Id: <1510047606-5589-5-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510047606-5589-1-git-send-email-gilad@benyossef.com> References: <1510047606-5589-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make the code more readable by using a local variables for commonly use expressions in the buffer manager part of the driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index 2d971f2..b3ca249 100644 --- a/drivers/staging/ccree/ssi_buffer_mgr.c +++ b/drivers/staging/ccree/ssi_buffer_mgr.c @@ -225,16 +225,18 @@ static int cc_generate_mlli( mlli_p = (u32 *)mlli_params->mlli_virt_addr; /* go over all SG's and link it to one MLLI table */ for (i = 0; i < sg_data->num_of_buffers; i++) { + union buffer_array_entry *entry = &sg_data->entry[i]; + u32 tot_len = sg_data->total_data_len[i]; + u32 offset = sg_data->offset[i]; + if (sg_data->type[i] == DMA_SGL_TYPE) - rc = cc_render_sg_to_mlli(dev, sg_data->entry[i].sgl, - sg_data->total_data_len[i], - sg_data->offset[i], - &total_nents, &mlli_p); + rc = cc_render_sg_to_mlli(dev, entry->sgl, tot_len, + offset, &total_nents, + &mlli_p); else /*DMA_BUFF_TYPE*/ - rc = cc_render_buff_to_mlli(dev, - sg_data->entry[i].buffer_dma, - sg_data->total_data_len[i], - &total_nents, &mlli_p); + rc = cc_render_buff_to_mlli(dev, entry->buffer_dma, + tot_len, &total_nents, + &mlli_p); if (rc != 0) return rc;