From patchwork Tue Nov 7 08:09:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 118120 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp3686114qgn; Tue, 7 Nov 2017 00:11:28 -0800 (PST) X-Google-Smtp-Source: ABhQp+Rn2Ah+xXFiDrtB5tsuE0IuU1eIGRCLM1Sn28FaeYgiZ2jvWKrML7XkFh1GFCKVmV6ZHheI X-Received: by 10.159.218.137 with SMTP id w9mr17542788plp.139.1510042288100; Tue, 07 Nov 2017 00:11:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510042288; cv=none; d=google.com; s=arc-20160816; b=DR4p3ZG8m8YBDSBnj7SSQQbihVTTS0VUtmqQ5prFllNvbdH9p2OYyTAzmPzuezLFgB R9YglOL0ihoOA5hdQFxkFXlVKZ5DUhiCWAcjce4NJc9InQCn1dr89GoUbhhZbOb1Zqe8 Sc8qKkvEYd1nTOLtFXbVWA3zkQg0DOc2N/J7khlbF9UuH0uswK3F7tFLbUcOoyuYsRco /v/FSAu/DEbrimrhdJPkoRwQxLISHhCs8f23/SFG4OoNfdvX+zE0IXWeUafBJObEKzA5 7ZxtAeiLGgAoa7fGsvVlRsq+vIHYFKZCJTJrIn02CuHqzjd+xg6R04rdUMfaaECL6YiI ilyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=TOu8YvCmwMNxJg5/p52cQaqb3M4eDFL2Kjs5nozs9qc=; b=Y4cRz5leCh4X1IgTJwfvoeA0NRRWhf+GDsX868olbIQxTamgK9lFUfCZk/yItV4UIu Ela8Ia9GgbTvNp52sigqQTwb7mduHP+HwASpve7Olc0wDN7hkY9U24frlsCL37MD+NHp V7ANlCkOLWDsaC/0x4EmfvTcz2uFEKtUCcv8aaYsqR7Hv+m27lNAYcaxoVT5dJAWW+VK x8KLWJDYblaleonktMXI+BM/EeLJpLvA+3hwUH4o5qUHlIoABo1CbawNgfA3phybRzXf i74epb7LLPy+YVjE8bMpMMgiN6uTf42fhyJVEM2BjUdCjSfyfDCtNz0F0D7S25jrO4d4 Ivnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rULzlUvf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n73si639753pfb.254.2017.11.07.00.11.27; Tue, 07 Nov 2017 00:11:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rULzlUvf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932670AbdKGILM (ORCPT + 26 others); Tue, 7 Nov 2017 03:11:12 -0500 Received: from conuserg-09.nifty.com ([210.131.2.76]:24938 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932539AbdKGIKz (ORCPT ); Tue, 7 Nov 2017 03:10:55 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id vA789u4J027191; Tue, 7 Nov 2017 17:09:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com vA789u4J027191 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1510042198; bh=TOu8YvCmwMNxJg5/p52cQaqb3M4eDFL2Kjs5nozs9qc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rULzlUvfY/k/R7p5CIyp6paOwEqOLD2NaekhTkOZAOSt5u4WvnbVJ+J6WebcHJkDp kbTmBsy8kdo30IZFvpLcK7SjioL7MCSoTpBshh9k2rjg36Um4x/40eBcWS1JQFZ5z/ DblAYJm/9eGmxSwYYxxHX4OiSHbgUE6PwRN5F1NlBSrMx6h1fBl8I1ZaqW6/+xq5aD frF9U1JcGfbozYPgzyFkIL/6qhL8PGoekkwYbP+pZ0uXffFtRgiZaZ3yEuS7SMc96I 1l+v84NN0cE8VjQ7/Sdm8tAre/E9Kkd7C5gdwjUxqsE095wAgngC1e49f6OBbNGl00 w+tvvCzFEX3wQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Wolfram Sang , linux-mmc@vger.kernel.org Cc: Simon Horman , Yoshihiro Shimoda , Masahiro Yamada , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label Date: Tue, 7 Nov 2017 17:09:27 +0900 Message-Id: <1510042172-27220-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> References: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "goto eprobe" does nothing useful. Return directly. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/renesas_sdhi_core.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index fcf7235..4b7a4e2 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -495,9 +495,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, priv->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(priv->clk)) { - ret = PTR_ERR(priv->clk); - dev_err(&pdev->dev, "cannot get clock: %d\n", ret); - goto eprobe; + dev_err(&pdev->dev, "cannot get clock\n"); + return PTR_ERR(priv->clk); } /* @@ -524,10 +523,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, } host = tmio_mmc_host_alloc(pdev); - if (!host) { - ret = -ENOMEM; - goto eprobe; - } + if (!host) + return -ENOMEM; if (of_data) { mmc_data->flags |= of_data->tmio_flags; @@ -652,7 +649,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, tmio_mmc_host_remove(host); efree: tmio_mmc_host_free(host); -eprobe: + return ret; } EXPORT_SYMBOL_GPL(renesas_sdhi_probe);