From patchwork Thu Oct 12 20:16:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 115675 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2333027qgn; Thu, 12 Oct 2017 13:17:03 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDQTftNdW7aXsGUSsj/0N8Dg/nSljvhYFrPJYkM2qaLmeRTOqsHx57nY0Pz4E2ByoGXVapo X-Received: by 10.99.4.75 with SMTP id 72mr1079028pge.400.1507839423482; Thu, 12 Oct 2017 13:17:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507839423; cv=none; d=google.com; s=arc-20160816; b=nqoJ5cF/knNUqhaywjHy+VnYHXG2KWfKPWuP/oI/C/pUMnwqECI5HYXCaSObhpxCJ6 gW/Ykqhl/ES0CG7MnUJEoyEBqaR7nDPp5Jijgkifsm8sopRTQk0kTJXI/Mot6VlbNfdS dXtMDgQwCMPgYy8mcnfgjERPpSUOsy6B1mZLSYnQukCC06tHJsSGgiWCkJYGjoz1poJP 6n9Ag022KNyCQJQHnQP6xwmVLSOvcckd3LUlug4cwSs/M6cmwQ3pY547hb/6uvyw4jHx zG/0QNCx+v6sfasqvs91XtL+GPq6uEBkDyrOZ7xCEQZbPti6G3ZjkNxJXjEYE3Ma/6Wt emog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:organization:message-id:date :subject:cc:to:from:dmarc-filter:arc-authentication-results; bh=3Fdjxrjxc12XMewPV7R8E/6xua9U37zQklyet50JUPg=; b=cm3jbgQd+us9POZRy2layHzNLFzi3DmdcvAboSCidx3V/Kta2F8tUDrBLWNnd+5gTS IwhRUb8vPBIheFZQ/nwcFHDsI8aat3tFOjXpPGOfXVYdz9Ns73cTMSMg6lCcR5CwXY2k q4kc5vOPt9YvSDdSIOlEUo66kB9AGgPe2wQmiHJKt3V1OygQ/sId/cUmtHKTFW6SVdY8 v/qBg98ZkGNvV5p0Zu58ZTMrXPHLgQWdjgDOngBs3LpfTkNs06fG4f0o8d5HMqXx8CQo SL0SxAhGg0u83xtFA6bbXTX4pQzNsknle65WxM4un8XlBmrYAjRFV50WwLt9PYTYNgsn 4stg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si12297931plt.739.2017.10.12.13.17.03; Thu, 12 Oct 2017 13:17:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757030AbdJLURB (ORCPT + 27 others); Thu, 12 Oct 2017 16:17:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54840 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755248AbdJLUQ6 (ORCPT ); Thu, 12 Oct 2017 16:16:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99CA1C059B63; Thu, 12 Oct 2017 20:16:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99CA1C059B63 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Received: from warthog.procyon.org.uk.com (ovpn-120-81.rdu2.redhat.com [10.10.120.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 514AE17ADC; Thu, 12 Oct 2017 20:16:56 +0000 (UTC) From: David Howells To: ebiggers@google.com Cc: keyrings@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH 08/15] security/keys: BIG_KEY requires CONFIG_CRYPTO Date: Thu, 12 Oct 2017 21:16:55 +0100 Message-Id: <150783941546.10956.15884531475572047421.stgit@warthog.procyon.org.uk> Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 In-Reply-To: <150783935268.10956.14343227057986655899.stgit@warthog.procyon.org.uk> References: <150783935268.10956.14343227057986655899.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 12 Oct 2017 20:16:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The recent rework introduced a possible randconfig build failure when CONFIG_CRYPTO configured to only allow modules: security/keys/big_key.o: In function `big_key_crypt': big_key.c:(.text+0x29f): undefined reference to `crypto_aead_setkey' security/keys/big_key.o: In function `big_key_init': big_key.c:(.init.text+0x1a): undefined reference to `crypto_alloc_aead' big_key.c:(.init.text+0x45): undefined reference to `crypto_aead_setauthsize' big_key.c:(.init.text+0x77): undefined reference to `crypto_destroy_tfm' crypto/gcm.o: In function `gcm_hash_crypt_remain_continue': gcm.c:(.text+0x167): undefined reference to `crypto_ahash_finup' crypto/gcm.o: In function `crypto_gcm_exit_tfm': gcm.c:(.text+0x847): undefined reference to `crypto_destroy_tfm' When we 'select CRYPTO' like the other users, we always get a configuration that builds. Fixes: 428490e38b2e ("security/keys: rewrite all of big_key crypto") Signed-off-by: Arnd Bergmann Signed-off-by: David Howells --- security/keys/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/security/keys/Kconfig b/security/keys/Kconfig index 91eafada3164..6462e6654ccf 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -45,6 +45,7 @@ config BIG_KEYS bool "Large payload keys" depends on KEYS depends on TMPFS + select CRYPTO select CRYPTO_AES select CRYPTO_GCM help