From patchwork Tue Oct 10 18:02:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 115438 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp4042311qgn; Tue, 10 Oct 2017 11:08:15 -0700 (PDT) X-Received: by 10.101.73.193 with SMTP id t1mr13055605pgs.97.1507658895505; Tue, 10 Oct 2017 11:08:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507658895; cv=none; d=google.com; s=arc-20160816; b=o/5R8+3sJLfBHNhmmweR27f3OCoNTkQS7ncJ2Ek+izFVqtT1WWunWedyD1JyOfHaBC kMjjz831sPnXjn0gkuRfQfQ5e5o8pUN/+SYurMhVOQaLjadUEIZ8XefaRrzvhPSffF2c noQ5Pta0BT9QgGmiWMg48H2xpTEEfC90KdbC8VmiFdtb8Q9T6hgc3ZYnbHr1Jiyz+Irv 0rXaIlYL13yjriagN8oNlTJ2VHGtQESKC5PFBZhJC6uZEIkmMY6tjmfIUx0sMroNpwBS Uvzv2AmWKPAVYOhxpVNfs1kYcszuGQ4YDTUZFeId3xUE9JsnLjnol9XAc2wgU/FvIHmU /+FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=l9O69Zgu7L3MlYgYnT3L0ZtiItPcwtBEfH+iilZLcWQ=; b=HNJ6rcfBRI1lFMSo2/+AFzMRPNBuQPy/vABvcclN4MIUg9clsAnD+P1rBOrxZMw6ui 22fFSPLlYdurtJdj5gNyIMo2utt6E6piL9cUPY/mmAuFalGdAEwaAUS4NsBCybB16umT x7FRFKi6rWTeNkctmnNifBEk24ZKtuN1ljapzWulZf5oTkm2P1Rzr31twSfXMOvhrtcg MHAg2Ds414DfHhcvAKnAgozqgT4yjmvK5d2YT31vTBQwNyKB2pej4rvNxzrRS2YXMx3m 7eL42cfFlIW/G/qelfdwpbDhmdmIwTjEmjqrASyZQb0ZFCONzeiMrUOXpm/a1IPKVyU/ th9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QvEM4cT0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15si5844989pll.96.2017.10.10.11.08.15; Tue, 10 Oct 2017 11:08:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QvEM4cT0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932777AbdJJSIN (ORCPT + 26 others); Tue, 10 Oct 2017 14:08:13 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:53012 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584AbdJJSFM (ORCPT ); Tue, 10 Oct 2017 14:05:12 -0400 Received: by mail-wm0-f48.google.com with SMTP id k4so7703195wmc.1 for ; Tue, 10 Oct 2017 11:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l9O69Zgu7L3MlYgYnT3L0ZtiItPcwtBEfH+iilZLcWQ=; b=QvEM4cT0biW1LkhTCJwaVrHBtQmqp6friRW/vTTO12yDCzqJJoT4/kxRjjwQIqYRFF v8Cxz4vw5EAP9H5gs+eDTUKDHE1jzi9mz8ktfCl7Qj7BBo5Z/dFovr/SiRY+O0vaiikZ 6CBtSN08L72ewBJQfOoaXBWi/7iTw6UpFd+vU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l9O69Zgu7L3MlYgYnT3L0ZtiItPcwtBEfH+iilZLcWQ=; b=Ki2/bXvYLrQNA81vJ7WLrjcwZ3Wlme5/vnyaJtyeJI5YSjrZe4EQw+HFbQPemv3zzH dxAduBokX9lRmw377XFJr2xkNJw5EOmb0N/wqHWWpIIoyJF8e1r0a5z1ker5O2YLlRv7 CZ/YP80bLX2QGAwPM5MmmJTeQcTY/0G3vptTNVxrlUepsxtKEeETNG+NbEZogdWAcpuC EGhRqYMbZ1rIyLNFeEfIDnebq0Z6PpAQzREVQKm3nPIwnizaULbOyyQWG/WTYSMbppcR hhBTM/iv/LycYL28RFBmLb0/zdLZJDLLppZahvBnS4PEmimdLk5TrnpuB9KqG0eAp6s8 Sx1w== X-Gm-Message-State: AMCzsaWBGs3h8XaQlYbKAP8/pJF0AODvA0tEfNw3lDexzG/AWRCfPCXp wVktMNWFcaiUHgRwPS0aL0X0YQ== X-Google-Smtp-Source: AOwi7QDnXUIJha6E7ReMM1hc3tZs9d8//iVo25GJQD0vhCXOLrInN1ySAoklg3EQ9AHgjgbdmqt/wA== X-Received: by 10.28.68.135 with SMTP id r129mr10833861wma.28.1507658711092; Tue, 10 Oct 2017 11:05:11 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:4f9:3ae1:43d2:31ae]) by smtp.gmail.com with ESMTPSA id l73sm12513428wmd.47.2017.10.10.11.05.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Oct 2017 11:05:10 -0700 (PDT) From: Daniel Lezcano To: edubezval@gmail.com, rui.zhang@intel.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kevin.wangtao@linaro.org, Keerthy , John Stultz , Leo Yan Subject: [PATCH 15/25] thermal/drivers/step_wise: Fix temperature regulation misbehavior Date: Tue, 10 Oct 2017 20:02:40 +0200 Message-Id: <1507658570-32675-15-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507658570-32675-1-git-send-email-daniel.lezcano@linaro.org> References: <79a5f10c-0fb7-3e4f-caac-c1625904b137@linaro.org> <1507658570-32675-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a particular situation when the cooling device is cpufreq and the heat dissipation is not efficient enough where the temperature increases little by little until reaching the critical threshold and leading to a SoC reset. The behavior is reproducible on a hikey6220 with bad heat dissipation (eg. stacked with other boards). Running a simple C program doing while(1); for each CPU of the SoC makes the temperature to reach the passive regulation trip point and ends up to the maximum allowed temperature followed by a reset. This issue has been also reported by running the libhugetlbfs test suite. What is observed is a ping pong between two cpu frequencies, 1.2GHz and 900MHz while the temperature continues to grow. It appears the step wise governor calls get_target_state() the first time with the throttle set to true and the trend to 'raising'. The code selects logically the next state, so the cpu frequency decreases from 1.2GHz to 900MHz, so far so good. The temperature decreases immediately but still stays greater than the trip point, then get_target_state() is called again, this time with the throttle set to true *and* the trend to 'dropping'. From there the algorithm assumes we have to step down the state and the cpu frequency jumps back to 1.2GHz. But the temperature is still higher than the trip point, so get_target_state() is called with throttle=1 and trend='raising' again, we jump to 900MHz, then get_target_state() is called with throttle=1 and trend='dropping', we jump to 1.2GHz, etc ... but the temperature does not stabilizes and continues to increase. [ 237.922654] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=1,throttle=1 [ 237.922678] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=1,throttle=1 [ 237.922690] thermal cooling_device0: cur_state=0 [ 237.922701] thermal cooling_device0: old_target=0, target=1 [ 238.026656] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=2,throttle=1 [ 238.026680] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=2,throttle=1 [ 238.026694] thermal cooling_device0: cur_state=1 [ 238.026707] thermal cooling_device0: old_target=1, target=0 [ 238.134647] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=1,throttle=1 [ 238.134667] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=1,throttle=1 [ 238.134679] thermal cooling_device0: cur_state=0 [ 238.134690] thermal cooling_device0: old_target=0, target=1 In this situation the temperature continues to increase while the trend is oscillating between 'dropping' and 'raising'. We need to keep the current state untouched if the throttle is set, so the temperature can decrease or a higher state could be selected, thus preventing this oscillation. Keeping the next_target untouched when 'throttle' is true at 'dropping' time fixes the issue. The following traces show the governor does not change the next state if trend==2 (dropping) and throttle==1. [ 2306.127987] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=1,throttle=1 [ 2306.128009] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=1,throttle=1 [ 2306.128021] thermal cooling_device0: cur_state=0 [ 2306.128031] thermal cooling_device0: old_target=0, target=1 [ 2306.231991] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=2,throttle=1 [ 2306.232016] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=2,throttle=1 [ 2306.232030] thermal cooling_device0: cur_state=1 [ 2306.232042] thermal cooling_device0: old_target=1, target=1 [ 2306.335982] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=0,throttle=1 [ 2306.336006] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=0,throttle=1 [ 2306.336021] thermal cooling_device0: cur_state=1 [ 2306.336034] thermal cooling_device0: old_target=1, target=1 [ 2306.439984] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=2,throttle=1 [ 2306.440008] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=2,throttle=0 [ 2306.440022] thermal cooling_device0: cur_state=1 [ 2306.440034] thermal cooling_device0: old_target=1, target=0 [ ... ] After a while, if the temperature continues to increase, the next state becomes 2 which is 720MHz on the hikey. That results in the temperature stabilizing around the trip point. [ 2455.831982] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=1,throttle=1 [ 2455.832006] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=1,throttle=0 [ 2455.832019] thermal cooling_device0: cur_state=1 [ 2455.832032] thermal cooling_device0: old_target=1, target=1 [ 2455.935985] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=0,throttle=1 [ 2455.936013] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=0,throttle=0 [ 2455.936027] thermal cooling_device0: cur_state=1 [ 2455.936040] thermal cooling_device0: old_target=1, target=1 [ 2456.043984] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=0,throttle=1 [ 2456.044009] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=0,throttle=0 [ 2456.044023] thermal cooling_device0: cur_state=1 [ 2456.044036] thermal cooling_device0: old_target=1, target=1 [ 2456.148001] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=1,throttle=1 [ 2456.148028] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=1,throttle=1 [ 2456.148042] thermal cooling_device0: cur_state=1 [ 2456.148055] thermal cooling_device0: old_target=1, target=2 [ 2456.252009] thermal thermal_zone0: Trip0[type=1,temp=65000]:trend=2,throttle=1 [ 2456.252041] thermal thermal_zone0: Trip1[type=1,temp=75000]:trend=2,throttle=0 [ 2456.252058] thermal cooling_device0: cur_state=2 [ 2456.252075] thermal cooling_device0: old_target=2, target=1 IOW, this change is needed to keep the state for a cooling device if the temperature trend is oscillating while the temperature increases slightly. Without this change, the situation above leads to a catastrophic crash by a hardware reset on hikey. This issue has been reported to happen on an OMAP dra7xx also. Signed-off-by: Daniel Lezcano Cc: Keerthy Cc: John Stultz Cc: Leo Yan Tested-by: Keerthy Reviewed-by: Keerthy --- drivers/thermal/step_wise.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index be95826..ee047ca 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c @@ -31,8 +31,7 @@ * If the temperature is higher than a trip point, * a. if the trend is THERMAL_TREND_RAISING, use higher cooling * state for this trip point - * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling - * state for this trip point + * b. if the trend is THERMAL_TREND_DROPPING, do nothing * c. if the trend is THERMAL_TREND_RAISE_FULL, use upper limit * for this trip point * d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit @@ -94,9 +93,11 @@ static unsigned long get_target_state(struct thermal_instance *instance, if (!throttle) next_target = THERMAL_NO_TARGET; } else { - next_target = cur_state - 1; - if (next_target > instance->upper) - next_target = instance->upper; + if (!throttle) { + next_target = cur_state - 1; + if (next_target > instance->upper) + next_target = instance->upper; + } } break; case THERMAL_TREND_DROP_FULL: