From patchwork Wed Oct 4 03:56:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 114720 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2632076qgn; Tue, 3 Oct 2017 20:57:38 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBrb69O4REOslDlqa9a3vo71e4obSAWWzne64UHlaZcfM6qjc2IhGgpDTdqjiGxosf2oC6R X-Received: by 10.84.128.103 with SMTP id 94mr18574965pla.96.1507089458049; Tue, 03 Oct 2017 20:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507089458; cv=none; d=google.com; s=arc-20160816; b=mnoCsoNsuxHq4n+QvWVNa7IyAW6ZLIYK/IyTlOFWK+P1Tl0FwbTNX2YRzCa6PJ9yyr UmgcVCMj4KD870+bjH2qr5bZIkMYqfbqLyMEJs8LrUQjb+p956fldGNjyW/GeOqj7Uh+ Ei/BVVRGaBz5LuaGOHg4+ZaGu2rEKP+P/PdDf5O2eSCXyZTZzdlK5At1xD2bKIwEZU9Z czco5RPHf5Vn9rwTutGNpwZfrbKt1fbe9ffBEz+k1z0LRtvTQkDN1hFKiKio2Zz/r6GY 8nygx4AgdfgmJqiXhm1wB+i34IGHoC2UqE7/QE9fN/SpUAALP95weq3A38WXT2qk2CM3 k/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=4Hvn9rLgmS6rf18nqjP/VtHGDL4ZONuweOfitqmJJH4=; b=ulbO9jZ84P8/KABA4L0jp9bGeCsCxrp10zISp2z49WVzX4Yg46gOsfsbwhnl1s5Trm cMVzngVMi8OmVFha5hpF635ROYp4yTsIvTtX0mKYOaB+DHovY5pKRvswMMO918m/oVY2 G4RILbZteSNEoYl9z92xGZd/gIH3VFcchLnJLWzK7ucuxTIFEIzyu8o7oSTFjTiWnIGX ioAcgLACRmshMoeLXhGS9Te1RY41e5DJA1ea96JU7MV+5cv0i20qh0oFuqkvoHjTub6e PD06rWN7z6DJ3G3Ir4wPv3e8RGFRnQYEnYM2AjsUFw6/K2q04IhdqGxh77BQ56ZwozFB cfFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=A7v93bDk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si11534419pla.257.2017.10.03.20.57.37; Tue, 03 Oct 2017 20:57:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=A7v93bDk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdJDD5g (ORCPT + 26 others); Tue, 3 Oct 2017 23:57:36 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:25258 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbdJDD5c (ORCPT ); Tue, 3 Oct 2017 23:57:32 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id v943u8Pn001949; Wed, 4 Oct 2017 12:56:09 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v943u8Pn001949 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1507089369; bh=4Hvn9rLgmS6rf18nqjP/VtHGDL4ZONuweOfitqmJJH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A7v93bDkeGcE0/3uem3b6aG5aOiN9WT7o5sCBv8nd8xumKUfNasmCKaA31y6YtNYZ 5UY7fOXZ8uSOgPJ3qqYdQ9mW70ZW456Kcyl5Zu7B2JurU5rLsQmgHRGUvuPNydnSep xlFOpC/jN6c/5R1yvKkfPfuo9bd4V7CQBWOEYQTgWeNQ2Fx0lLsOw9Q/oB+MlhEAAV ToU/pVPxl+Dpz7WdcPzI5fz/vt86ulTH/h5xWX9fBstpng9+slSxnUqVtfXG/+bUSI Aumv4mKYBrzL+u1zTBCpZe3eInWMh7hFfQWThSSMfYD9AuftF+yfs9TVCLYGWIQj1k SCLXJ42RPTCcg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Douglas Anderson , Sam Ravnborg , linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH 2/4] kbuild: move "_all" target out of $(KBUILD_SRC) conditional Date: Wed, 4 Oct 2017 12:56:05 +0900 Message-Id: <1507089367-10402-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507089367-10402-1-git-send-email-yamada.masahiro@socionext.com> References: <1507089367-10402-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first "_all" occurrence around line 120 is only visible when KBUILD_SRC is unset. If O=... is specified, the working directory is relocated, then the only second occurrence around line 193 is visible, that is not set to PHONY. Move the first one to an always visible place. This clarifies "_all" is our default target and it is always set to PHONY. Signed-off-by: Masahiro Yamada --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 Reviewed-by: Douglas Anderson diff --git a/Makefile b/Makefile index 8d900ba..39a7c03 100644 --- a/Makefile +++ b/Makefile @@ -10,6 +10,10 @@ NAME = Fearless Coyote # Comments in this file are targeted only to the developer, do not # expect to learn how to build the kernel reading this file. +# That's our default target when none is given on the command line +PHONY := _all +_all: + # o Do not use make's built-in rules and variables # (this increases performance and avoids hard-to-debug behaviour); # o Look for make include files relative to root of kernel src @@ -116,10 +120,6 @@ ifeq ("$(origin O)", "command line") KBUILD_OUTPUT := $(O) endif -# That's our default target when none is given on the command line -PHONY := _all -_all: - # Cancel implicit rules on top Makefile $(CURDIR)/Makefile Makefile: ;