From patchwork Wed Sep 20 19:57:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 113172 Delivered-To: patches@linaro.org Received: by 10.140.106.117 with SMTP id d108csp1171381qgf; Wed, 20 Sep 2017 12:57:37 -0700 (PDT) X-Received: by 10.101.64.72 with SMTP id h8mr3345613pgp.110.1505937457409; Wed, 20 Sep 2017 12:57:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505937457; cv=none; d=google.com; s=arc-20160816; b=LCjW974Y7z21ADAc5D9VcOEDfRkAnvdt5GwQBYACFw4XKvf1tkQyE2T0xGVHFhRnJh w9suP1DtxuwnPP1v3RnHuLQpagRWJNHV3xm2BFpv1qnn8P3o95NiT8U9Al13tUQmGKXk qszW8OVa/XOj6JavKgD4XG76mDO5K80g8y8Llcq9N+tNr5T+Ic8WTRDOWGG2IzYJ1MV1 9g2ZnLD+UBN4l9aOtU/2Pl2GmAc2h+Ytl5nZGBPIK9qMsZqLRztdl16YvnYT4Qv6yDIe hNqIraLPB/P4gqYCRF/839u54y/dIX8ujxKjR5ig/pDg+FrrkmKydI/E+1yMDLdS5lMo tK+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=G8DnrRUlKAM749Vbf9PvJpPHAC3WTIikCRv1clO5Sy/5Q9KaKzftjoQZU6fylfBSfp jV9Koa5a02GNTGyf3Wzvi8dA999tBW+EG82BAL1oOHGJJVwI1frAX+mGKrLQzfkaxyMw 6Akeh8xuAzImcOCo5+QUPzNeVYCFHroj44jDTAad+2KN52rj8yA6gNdeUo8Rygjl4xm6 zPpSRCCmB2nhtT572FX/yhHqeJ+IDBNJNvotrvyYDUD3cmsw8Bahhup26hAV71ZQ4MSN uXuUlEqCwWlYQcNqgr2hzW68fbIXReSzyVz1yCYr9PpsCoRPc9vapZxhpnvGgbLk/hC/ KnVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C1+PWnAl; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 1sor159798pli.77.2017.09.20.12.57.37 for (Google Transport Security); Wed, 20 Sep 2017 12:57:37 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C1+PWnAl; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=C1+PWnAlFbD7zV0nEtQhu0RO0DPAOJLV/d0zEwQLF5LjXUYjqlG9vTRaKf8W8cXOsW ga6k7HxvF8dUBznGSIS7N9Xw1IT3xfj1KjAMEE7kVcfrWKrPGa8jgFeEaov2ITT15FjL sG1U2JFLVXunio7JzUduF+/g69TroyNhKUpjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=WibAsiQK65u8mtkqAq5JMYfmL9zyx0FsJ7nvDCxmUAnUyvf4qTYjQ0r59zdvh+g1Hb McjTLxTr6v3Mjig32ISYblqunB25dAWiikkDTTqk9Z3TpRJncZUC+ip1LoOCFcc5OvgS Z3hEbQ2Je4IsxBthIDhKHDZSNMganNSHpria3n+Iv1jl8yU6BCDAE9X1rJq63cReJ0TD SO4pbOOLOkOuktDs2Mk92ZfvzSoO25amWHVldhWkvrRxrtzmEI4lri1G0E3382J+7Dw1 VZb0rhZ1TyzskSf8v3fu5MU6a3dkvhcHhjOnl4OYFBQIvv+9zQcaJKUOnMPfOr5A3t8F /+lg== X-Gm-Message-State: AHPjjUh7T8R284M9LOHUK1YWAFoyhEMdDpOk7L8AKGRbgVMkGB+F53qZ pmDhPdCDhO7KoI/jvJhAFcnfib9j X-Google-Smtp-Source: AOwi7QDXzM/DlKScNCsj9CPfID6PRkmSXfYbNfacDSsYUlxX4P5IpiPnJIwro/NLqAIhUiIPt1Lf5w== X-Received: by 10.84.171.129 with SMTP id l1mr3155142plb.39.1505937457131; Wed, 20 Sep 2017 12:57:37 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id i2sm9991660pfd.21.2017.09.20.12.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 12:57:35 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking Date: Wed, 20 Sep 2017 12:57:28 -0700 Message-Id: <1505937448-13475-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505937448-13475-1-git-send-email-john.stultz@linaro.org> References: <1505937448-13475-1-git-send-email-john.stultz@linaro.org> It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c0000.usb/state file would report "configured" no matter the state of the OTG port. This patch adds a call so that we report to the UDC layer when the gadget device is disconnected. Cc: Wei Xu Cc: Guodong Xu Cc: Amit Pundir Cc: YongQin Liu Cc: John Youn Cc: Minas Harutyunyan Cc: Douglas Anderson Cc: Chen Yu Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Reported-by: Amit Pundir Signed-off-by: John Stultz --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 7fd0e38..603c216 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3202,6 +3202,8 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg) call_gadget(hsotg, disconnect); hsotg->lx_state = DWC2_L3; + + usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED); } /**